[GitHub] madlib pull request #288: Jira:1239: Converts features from multiple columns...

2018-07-03 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/288#discussion_r199981733 --- Diff: src/config/Modules.yml --- @@ -50,3 +50,4 @@ modules: - name: validation depends: ['array_ops', 'regress'] - name: stemm

[GitHub] madlib pull request #288: Jira:1239: Converts features from multiple columns...

2018-07-03 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/288#discussion_r199983404 --- Diff: src/ports/postgres/modules/cols_vec/cols2vec.py_in --- @@ -0,0 +1,110 @@ +""" +@file cols2vec.py_in + +@brief Utility to convert Colu

[GitHub] madlib pull request #288: Jira:1239: Converts features from multiple columns...

2018-07-03 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/288#discussion_r199981970 --- Diff: src/ports/postgres/modules/cols_vec/cols2vec.py_in --- @@ -0,0 +1,110 @@ +""" +@file cols2vec.py_in + +@brief Utility to convert Colu

[GitHub] madlib pull request #288: Jira:1239: Converts features from multiple columns...

2018-07-03 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/288#discussion_r199982049 --- Diff: src/ports/postgres/modules/cols_vec/cols2vec.py_in --- @@ -0,0 +1,110 @@ +""" +@file cols2vec.py_in + +@brief Utility to convert Colu

[GitHub] madlib pull request #288: Jira:1239: Converts features from multiple columns...

2018-07-03 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/288#discussion_r199982717 --- Diff: src/ports/postgres/modules/cols_vec/cols2vec.py_in --- @@ -0,0 +1,110 @@ +""" +@file cols2vec.py_in + +@brief Utility to convert Colu

[GitHub] madlib pull request #288: Jira:1239: Converts features from multiple columns...

2018-07-03 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/288#discussion_r199983644 --- Diff: src/ports/postgres/modules/cols_vec/cols2vec.py_in --- @@ -0,0 +1,110 @@ +""" +@file cols2vec.py_in + +@brief Utility to convert Colu

[GitHub] madlib issue #288: Jira:1239: Converts features from multiple columns into a...

2018-07-03 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/288 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/535/ ---

[GitHub] madlib pull request #288: Madlib 1239

2018-07-03 Thread hpandeycodeit
GitHub user hpandeycodeit opened a pull request: https://github.com/apache/madlib/pull/288 Madlib 1239 JIRA: 1239 Added a new module cols_vec which Converts features from multiple columns of an input table into a feature array in a single column. Following files ar

[GitHub] madlib issue #287: Fix incorrect dict expansion in table header

2018-07-03 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/287 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/534/ ---

[GitHub] madlib pull request #287: Fix incorrect dict expansion in table header

2018-07-03 Thread iyerr3
GitHub user iyerr3 opened a pull request: https://github.com/apache/madlib/pull/287 Fix incorrect dict expansion in table header You can merge this pull request into a Git repository by running: $ git pull https://github.com/madlib/madlib bugfix/svm_cv_output Alternatively yo

[GitHub] madlib issue #282: Utilites: Add CTAS while dropping some columns

2018-07-03 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/282 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/533/ ---

[GitHub] madlib issue #286: Build: Remove symlinks during rpm uninstall

2018-07-03 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/286 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/532/ ---

[GitHub] madlib pull request #286: Build: Remove symlinks during rpm uninstall

2018-07-03 Thread iyerr3
GitHub user iyerr3 opened a pull request: https://github.com/apache/madlib/pull/286 Build: Remove symlinks during rpm uninstall JIRA: MADLIB-1175 `rpm --install` creates three symlinks to `Versions/`, `.../bin`, and `.../doc`. These symlinks should be deleted during `rpm

[GitHub] madlib pull request #285: Madpack: fix install/reinstall not giving proper e...

2018-07-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/285 ---

[GitHub] madlib issue #282: Utilites: Add CTAS while dropping some columns

2018-07-03 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/282 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/531/ ---

[GitHub] madlib issue #282: Utilites: Add CTAS while dropping some columns

2018-07-03 Thread iyerr3
Github user iyerr3 commented on the issue: https://github.com/apache/madlib/pull/282 Thanks @kaknikhil for the review. I've updated per the comments. Will merge after your approval. ---

[GitHub] madlib pull request #282: Utilites: Add CTAS while dropping some columns

2018-07-03 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/282#discussion_r199862080 --- Diff: src/ports/postgres/modules/utilities/test/utilities.sql_in --- @@ -0,0 +1,77 @@ +/* -

[GitHub] madlib pull request #282: Utilites: Add CTAS while dropping some columns

2018-07-03 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/282#discussion_r199861894 --- Diff: src/ports/postgres/modules/utilities/test/utilities.sql_in --- @@ -0,0 +1,77 @@ +/* -

[GitHub] madlib pull request #282: Utilites: Add CTAS while dropping some columns

2018-07-03 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/282#discussion_r199861841 --- Diff: src/ports/postgres/modules/utilities/utilities.py_in --- @@ -853,6 +857,34 @@ def validate_module_input_params(source_table, output_table, independe

[GitHub] madlib pull request #282: Utilites: Add CTAS while dropping some columns

2018-07-03 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/282#discussion_r199861734 --- Diff: src/ports/postgres/modules/utilities/utilities.py_in --- @@ -853,6 +857,34 @@ def validate_module_input_params(source_table, output_table, independe

[GitHub] madlib pull request #282: Utilites: Add CTAS while dropping some columns

2018-07-03 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/282#discussion_r199861396 --- Diff: src/ports/postgres/modules/utilities/test/utilities.ic.sql_in --- @@ -0,0 +1,58 @@ +/* --