[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-04 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r215149356 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name, point_i

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-04 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r215149235 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -264,12 +260,17 @@ def knn(schema_madlib, point_source, point_column_name, point_id,

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-04 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r215148966 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name, point_i

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-04 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r215148640 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name, point_i

[GitHub] madlib pull request #316: Build: Disable AppendOnly if available

2018-09-04 Thread reductionista
Github user reductionista commented on a diff in the pull request: https://github.com/apache/madlib/pull/316#discussion_r215104112 --- Diff: src/ports/postgres/modules/utilities/control.py_in --- @@ -158,6 +159,61 @@ class MinWarning(ContextDecorator):

[GitHub] madlib pull request #316: Build: Disable AppendOnly if available

2018-09-04 Thread reductionista
Github user reductionista commented on a diff in the pull request: https://github.com/apache/madlib/pull/316#discussion_r215102984 --- Diff: src/ports/postgres/modules/utilities/control.py_in --- @@ -158,6 +159,61 @@ class MinWarning(ContextDecorator):

[GitHub] madlib issue #317: Fixed trailing whitespace in many sql_in files

2018-09-04 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/317 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/669/ ---

[GitHub] madlib pull request #313: MLP: Simplify momentum and Nesterov updates

2018-09-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/313 ---

[GitHub] madlib issue #313: MLP: Simplify momentum and Nesterov updates

2018-09-04 Thread fmcquillan99
Github user fmcquillan99 commented on the issue: https://github.com/apache/madlib/pull/313 is this ready to merge? ---

[GitHub] madlib issue #318: Madpack: Add a script for automating changelist creation

2018-09-04 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/318 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/668/ ---

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-04 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/madlib/pull/318 Madpack: Add a script for automating changelist creation You can merge this pull request into a Git repository by running: $ git pull https://github.com/madlib/madlib madpack/auto-changeli