[GitHub] incubator-madlib pull request: Feature: Sessionize funtion

2016-05-31 Thread fmcquillan99
Github user fmcquillan99 commented on the pull request: https://github.com/apache/incubator-madlib/pull/44 Here are the follow on JIRAs on sessionization from product mgmt perspective. Others can chip in on performance and implementation issues, and open other JIRAs as required.

[GitHub] incubator-madlib pull request: Feature: Sessionize funtion

2016-05-31 Thread decibel
Github user decibel commented on the pull request: https://github.com/apache/incubator-madlib/pull/44 I'm not sure why params is better than explicit parameters, but lets move that discussion to the new Jira. I didn't do a full review, but the database stuff looks sane. ---

[GitHub] incubator-madlib pull request: Prediction Metrics: New module

2016-05-31 Thread iyerr3
Github user iyerr3 commented on the pull request: https://github.com/apache/incubator-madlib/pull/42 Along with casting the columns to int in binary classification, we also need to change docs/online-help/tests to reflect that boolean columns allowed for observation columns. --- If

[GitHub] incubator-madlib pull request: Prediction Metrics: New module

2016-05-31 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/42#discussion_r65259392 --- Diff: src/ports/postgres/modules/stats/pred_metrics.py_in --- @@ -0,0 +1,562 @@ +# coding=utf-8 +# +# Licensed to the Apache Software F

[GitHub] incubator-madlib pull request: Prediction Metrics: New module

2016-05-31 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/42#discussion_r65259215 --- Diff: src/ports/postgres/modules/stats/pred_metrics.py_in --- @@ -0,0 +1,562 @@ +# coding=utf-8 +# +# Licensed to the Apache Software F

[GitHub] incubator-madlib pull request: Feature: Sessionize funtion

2016-05-31 Thread njayaram2
Github user njayaram2 commented on the pull request: https://github.com/apache/incubator-madlib/pull/44 @decibel Thank you for the comment. This is certainly useful, and I am planning to implement this as part of sessionization-Phase 2 (I will put in the link of the corresponding JIRA

[GitHub] incubator-madlib pull request: Feature: Sessionize funtion

2016-05-31 Thread decibel
Github user decibel commented on the pull request: https://github.com/apache/incubator-madlib/pull/44 Has consideration been given to allowing for the creation of a view instead of a table? If you only needed session info once, or only for a subset of values in the input table, that c

[GitHub] incubator-madlib pull request: Feature: Sessionize funtion

2016-05-31 Thread njayaram2
GitHub user njayaram2 opened a pull request: https://github.com/apache/incubator-madlib/pull/44 Feature: Sessionize funtion JIRA: MADLIB-909 This contains the implementation of the phase 1 sessionize function. The current input parameters are the input and output table n