Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
I have merged your PR.
Thanks!
Auon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Hi NJ, Orhan
I am done with adding following validation cases:
- Check if train and test table is valid
- if columns specified are present in these tables
- if k>0
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Thanks! I guess it worked for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Its not getting pushed, It says:
To https://github.com/auonhaidar/incubator-madlib.git
! [rejected]features/knn -> features/knn (non-fast-forward)
error: failed
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Hey NJ,
I think the rebase is not happening in the desired way. I first pulled the
changes from apache repo to my local master.
Output:
haidar@haidar-XPS-L501X:~/MADLIB
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Cool. I will have a look and start with the implementations.
Thanks NJ!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
I think you have already covered a lot of validation cases @njayaram2 . I
will work on that and If I get stuck somewhere I will let you know. Meanwhile,
could you please point me to the
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Sure NJ. But I will be free from my work after 5 tomorrow. Would that work
for you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Sure NJ, Orhan,
Thanks!
Auon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Hi Orhan,
Thanks!
Should I merge these changes?
I will try to look for the validations you were talking about. Could you
specifically tell what kind of checks do I need to add
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Hi Orhan,
I have added the documentation. Please have a look. I did not compile it
because of my system issues.
Regards
---
If your project is set up for it, you can
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Sure!
I will make documentation and share it with you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
I ran this command inside build:
$ du -h doc/
4.0Kdoc/design/figures
4.0Kdoc/design/modules
20K doc/design/CMakeFiles/auxclean.dir
44K doc
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Yes.
Then I ran make and then make doc. Its says 'up to date'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Output:
-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is GNU 4.8.4
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
I installed doxygen and latex2html. I ran 'make' and then 'make doc'. But
still I couldn't see folder /doc/user/html/
---
If your project is set up for it, yo
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Okay.
Then, I will install try installing Doxygen and let you know.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Yeah, it worked.
Following is the output:
"-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is GNU 4.8.4
-- Check for working C com
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
It runs with the following output:
_"cmake version 2.8.12.2
Usage
cmake [options]
cmake [options]
Options
-C = Pre-load a scri
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
I couldn't find user/ folder in doc/.
I tried doing make and then make doc. It still says 'it is upto date'.
---
If your project is set up for it, you can reply to
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Where exactly are html files? I tried looking for them in build folder but
I couldn't find them.
I ran make doc after making few changes in kmeans.sql_in and it says:
make:
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
I tried running following command in modules/kmeans/ folder:
make doc
It says:
make: *** No rule to make target `doc'. Stop.
Sure, I will start with the document
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Hi,
What is documentation in pivot.sql.in? Is it the lines written as comments
after m4_include(`SQLCommon.m4')?
How is this thing compiled? How can I see how will it lo
Github user auonhaidar commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Hi Orhan Kislal,
No, it should work. Even I am using 9.4 postgres. I pushed some more
changes 11 days ago. Are you using that version?
---
If your project is set up for it, you can
Github user auonhaidar commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/81#discussion_r94083157
--- Diff: src/ports/postgres/modules/knn/test/knn.sql_in ---
@@ -0,0 +1,41 @@
+m4_include(`SQLCommon.m4
Github user auonhaidar commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/81#discussion_r93988706
--- Diff: src/ports/postgres/modules/knn/test/knn.sql_in ---
@@ -0,0 +1,41 @@
+m4_include(`SQLCommon.m4
Github user auonhaidar commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/81#discussion_r93969163
--- Diff: src/ports/postgres/modules/knn/test/knn.sql_in ---
@@ -0,0 +1,41 @@
+m4_include(`SQLCommon.m4
Github user auonhaidar commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/81#discussion_r93968700
--- Diff: src/ports/postgres/modules/knn/knn.sql_in ---
@@ -0,0 +1,165
Github user auonhaidar commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/81#discussion_r93768626
--- Diff: src/ports/postgres/modules/knn/test/knn.sql_in ---
@@ -0,0 +1,41 @@
+m4_include(`SQLCommon.m4
Github user auonhaidar commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/81#discussion_r93768540
--- Diff: src/ports/postgres/modules/knn/knn.sql_in ---
@@ -0,0 +1,165
GitHub user auonhaidar opened a pull request:
https://github.com/apache/incubator-madlib/pull/81
JIRA: MADLIB-927 Changes made in KNN-help message-test cases-etc
KNN Added
Usage:
select * from madlib.knn()
select * from madlib.knn('help')
sel
Github user auonhaidar closed the pull request at:
https://github.com/apache/incubator-madlib/pull/80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user auonhaidar opened a pull request:
https://github.com/apache/incubator-madlib/pull/80
KNN Added
I have added implementation of K-Nearest Neighbours. The function takes
following arguments in order:
_training table name
training table's column name having ve
33 matches
Mail list logo
