Re: Review Request: MAHOUT-1192 [2]: Speed up Vector Operations

2013-04-29 Thread Robin Anil
After this change the benchmark actually takes about 41 minutes :) Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc. On Mon, Apr 29, 2013 at 9:45 PM, Robin Anil wrote: > After increasing the lead time to 15 seconds, I believe I am giving enough > time for JIT to take place. This w

Re: Review Request: MAHOUT-1192 [2]: Speed up Vector Operations

2013-04-29 Thread Robin Anil
After increasing the lead time to 15 seconds, I believe I am giving enough time for JIT to take place. This way we are measuring only the JITed code not the interpreted code. There is a flag in JVM with which you can change the threshold -XX:+CompileThreshold (default: 1). I didnt want to mess

[jira] [Comment Edited] (MAHOUT-1199) Improve javadoc comments of mahout-integration

2013-04-29 Thread Angel Martinez Gonzalez (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644963#comment-13644963 ] Angel Martinez Gonzalez edited comment on MAHOUT-1199 at 4/29/13 10:21 PM:

[jira] [Updated] (MAHOUT-1199) Improve javadoc comments of mahout-integration

2013-04-29 Thread Angel Martinez Gonzalez (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angel Martinez Gonzalez updated MAHOUT-1199: Attachment: MAHOUT-1199.patch Uploaded patch that adds coments to classes

[jira] [Created] (MAHOUT-1199) Improve javadoc comments of mahout-integration

2013-04-29 Thread Angel Martinez Gonzalez (JIRA)
Angel Martinez Gonzalez created MAHOUT-1199: --- Summary: Improve javadoc comments of mahout-integration Key: MAHOUT-1199 URL: https://issues.apache.org/jira/browse/MAHOUT-1199 Project: Mahout

[jira] [Commented] (MAHOUT-1198) Allow Latex in javadox

2013-04-29 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644874#comment-13644874 ] Ted Dunning commented on MAHOUT-1198: - {quote} But this will work only for as long as

[jira] [Commented] (MAHOUT-1198) Allow Latex in javadox

2013-04-29 Thread Andrew Musselman (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644857#comment-13644857 ] Andrew Musselman commented on MAHOUT-1198: -- Er, I read that wrong. Lets you con

[jira] [Commented] (MAHOUT-1198) Allow Latex in javadox

2013-04-29 Thread Andrew Musselman (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644849#comment-13644849 ] Andrew Musselman commented on MAHOUT-1198: -- The MathJax site says you can config

[jira] [Commented] (MAHOUT-1198) Allow Latex in javadox

2013-04-29 Thread Dmitriy Lyubimov (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644810#comment-13644810 ] Dmitriy Lyubimov commented on MAHOUT-1198: -- But this will work only for as long

Re: [jira] [Created] (MAHOUT-1198) Allow Latex in javadox

2013-04-29 Thread Robin Anil
This is pretty cool! Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc. On Mon, Apr 29, 2013 at 2:42 PM, Ted Dunning (JIRA) wrote: > Ted Dunning created MAHOUT-1198: > --- > > Summary: Allow Latex in javadox > Key: MAHOU

[jira] [Created] (MAHOUT-1198) Allow Latex in javadox

2013-04-29 Thread Ted Dunning (JIRA)
Ted Dunning created MAHOUT-1198: --- Summary: Allow Latex in javadox Key: MAHOUT-1198 URL: https://issues.apache.org/jira/browse/MAHOUT-1198 Project: Mahout Issue Type: Bug Reporter: T

Build failed in Jenkins: Mahout-Examples-Cluster-Reuters-II #470

2013-04-29 Thread Apache Jenkins Server
See -- [...truncated 1657 lines...] A math/src/main/java/org/apache/mahout/math/PersistentObject.java AUmath/src/main/java/org/apache/mahout/math/AbstractMatrix.java A

Re: Review Request: MAHOUT-1192 [2]: Speed up Vector Operations

2013-04-29 Thread Robin Anil
I have a few ideas to tweak around with the JIT to make the benchmarks more stable. I will ping back once I get some time to do something. Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc. On Mon, Apr 29, 2013 at 10:32 AM, Dan Filimon wrote: > That's the weirdness, it's _exactly_ t

Re: Review Request: MAHOUT-1192 [2]: Speed up Vector Operations

2013-04-29 Thread Dan Filimon
That's the weirdness, it's _exactly_ the same code. On Mon, Apr 29, 2013 at 6:31 PM, Robin Anil wrote: > I will pull your Patch in and take a look a close look at it tonight. Whats > different in Run3 in Version7 v/s Run2 and Run1. Because Run3 looks really > good and the regressions of 30% in

Re: Review Request: MAHOUT-1192 [2]: Speed up Vector Operations

2013-04-29 Thread Robin Anil
I will pull your Patch in and take a look a close look at it tonight. Whats different in Run3 in Version7 v/s Run2 and Run1. Because Run3 looks really good and the regressions of 30% in some are actually not as bad and nothing no longer looks ridiculously blocking the patch. On Mon, Apr 29, 2013

Re: Review Request: MAHOUT-1192 [2]: Speed up Vector Operations

2013-04-29 Thread Dan Filimon
I uploaded the latest patch to my vector branch on github [0]. The latest revision is, as always, here [1], "Version 7 (Assign/Aggregate; 1 sec runtime)". Tests pass for this one except for some aggregate tests (it's not clear if aggregate should throw an exception when the vectors are empty or re