Re: Codebase refactoring proposal

2015-01-23 Thread Shannon Quinn
Also +1 iPhone'd > On Jan 23, 2015, at 18:38, Andrew Palumbo wrote: > > +1 > > > Sent from my Verizon Wireless 4G LTE smartphone > > Original message From: Dmitriy Lyubimov > Date:01/23/2015 6:06 PM (GMT-05:00) > To: dev@mahout.apache.org Subject: Codebase refactoring

RE: Codebase refactoring proposal

2015-01-23 Thread Andrew Palumbo
+1 Sent from my Verizon Wireless 4G LTE smartphone Original message From: Dmitriy Lyubimov Date:01/23/2015 6:06 PM (GMT-05:00) To: dev@mahout.apache.org Subject: Codebase refactoring proposal So right now mahout-spark depends on mr-legacy. I did quick refactoring and it

Jenkins build is back to normal : mahout-nightly #1813

2015-01-23 Thread Apache Jenkins Server
See

Jenkins build is back to normal : mahout-nightly ยป Mahout Spark bindings #1813

2015-01-23 Thread Apache Jenkins Server
See

Re: Codebase refactoring proposal

2015-01-23 Thread Dmitriy Lyubimov
sorry i meant _without_ mrlegacy on classpath. On Fri, Jan 23, 2015 at 3:31 PM, Dmitriy Lyubimov wrote: > And in case anyone wonders yes shell starts and runs test script totally > fine with mrlegacy dependency on classpath (startup script modified to use > mahout-hadoop instead) -- both in loc

Re: Codebase refactoring proposal

2015-01-23 Thread Dmitriy Lyubimov
And in case anyone wonders yes shell starts and runs test script totally fine with mrlegacy dependency on classpath (startup script modified to use mahout-hadoop instead) -- both in local and distributed (standalone) mode: $ MASTER=spark://localho

Re: Codebase refactoring proposal

2015-01-23 Thread Suneel Marthi
+1 On Fri, Jan 23, 2015 at 6:04 PM, Dmitriy Lyubimov wrote: > So right now mahout-spark depends on mr-legacy. > I did quick refactoring and it turns out it only _irrevocably_ depends on > the following classes there: > > MatrixWritable, VectorWritable, Varint/Varlong and VarintWritable, and ...

Codebase refactoring proposal

2015-01-23 Thread Dmitriy Lyubimov
So right now mahout-spark depends on mr-legacy. I did quick refactoring and it turns out it only _irrevocably_ depends on the following classes there: MatrixWritable, VectorWritable, Varint/Varlong and VarintWritable, and ... *sigh* o.a.m.common.Pair So I just dropped those five classes into new

Code quality questions

2015-01-23 Thread Dmitriy Lyubimov
in TextDelimitedReaderWriter.scala: === val itemList: collection.mutable.MutableList[org.apache.mahout.common.Pair[Integer, Double]] = new collection.mutable.MutableList[org.apache.mahout.common.Pair[Integer, Double]] for (ve <- itemVector.nonZeroes) { va

Build failed in Jenkins: Mahout-Examples-Cluster-Reuters-II #1077

2015-01-23 Thread Apache Jenkins Server
See -- [...truncated 1701 lines...] A mrlegacy/src/main/java/org/apache/mahout/cf/taste/impl/recommender/svd A mrlegacy/src/main/java/org/apache/mahout/cf/taste/impl/re

Jenkins build is back to normal : Mahout-Quality #2937

2015-01-23 Thread Apache Jenkins Server
See