de of JIRA or confluence?
>
> > From: ted.dunn...@gmail.com
> > Date: Tue, 9 Apr 2013 07:13:34 -0700
> > Subject: Re: Code reviews and reviewers
> > To: dev@mahout.apache.org
> >
> > On Tue, Apr 9, 2013 at 5:03 AM, Dan Filimon >wrote:
> >
> > > T
If it's ok with other folks I'd love to participate in code reviews. Having
never used review board before do we need a separate review board account
outside of JIRA or confluence?
> From: ted.dunn...@gmail.com
> Date: Tue, 9 Apr 2013 07:13:34 -0700
> Subject: Re: Code re
On Tue, Apr 9, 2013 at 5:03 AM, Dan Filimon wrote:
> Thanks Sebastian!
>
> But let's talk about policy. Wouldn't everyone agree that more code reviews
> are a good thing?
>
Absolutely.
> Ideally, everyone does it and becomes familiar with the code base.
>
> So, even though I, for instance would
+3
From: Andrew Musselman
To: dev@mahout.apache.org
Sent: Tuesday, April 9, 2013 9:16 AM
Subject: Re: Code reviews and reviewers
+1 for code reviews
+1 for Review Board
+1 for unit tests and integration tests
On Tue, Apr 9, 2013 at 5:03 AM, Dan Filimon
+1 for code reviews
+1 for Review Board
+1 for unit tests and integration tests
On Tue, Apr 9, 2013 at 5:03 AM, Dan Filimon wrote:
> Thanks Sebastian!
>
> But let's talk about policy. Wouldn't everyone agree that more code reviews
> are a good thing?
> Ideally, everyone does it and becomes famil
Thanks Sebastian!
But let's talk about policy. Wouldn't everyone agree that more code reviews
are a good thing?
Ideally, everyone does it and becomes familiar with the code base.
So, even though I, for instance wouldn't be able to say much about
something I haven't worked on, like recommendation
Dan,
it's a pleasure to review your code. Ask me anytime :)
On 09.04.2013 13:31, Dan Filimon wrote:
> Hi everyone,
>
> Sebastian has been reviewing my code on ReviewBoard [1] for a while now and
> I feel bad for always asking him to do it. :)
>
> Is there anyone else who could have a look (I'll
Hi everyone,
Sebastian has been reviewing my code on ReviewBoard [1] for a while now and
I feel bad for always asking him to do it. :)
Is there anyone else who could have a look (I'll also volunteer when you
need a reviewer)?
[1] https://reviews.apache.org/r/10372/
