[jira] [Comment Edited] (CONNECTORS-1680) WebConnector: Support the Document Base URL element

2021-12-17 Thread Markus Schuch (Jira) 


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461592#comment-17461592
 ] 

Markus Schuch edited comment on CONNECTORS-1680 at 12/17/21, 5:52 PM:
--

thanks [~kwri...@metacarta.com], fixed with r1896101


was (Author: schuchm):
fixed with r1896101

> WebConnector: Support the Document Base URL element
> ---
>
> Key: CONNECTORS-1680
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1680
> Project: ManifoldCF
>  Issue Type: Improvement
>  Components: Web connector
>Reporter: Markus Schuch
>Assignee: Karl Wright
>Priority: Major
> Fix For: ManifoldCF 2.21
>
>
> HTML allows to specifiy the base URL to use for all relative URLs in a 
> document:
> {code:java}
> 
>   
>
> https://example.org/"/>
> ...
>   
>...
> {code}
> [https://developer.mozilla.org/de/docs/Web/HTML/Element/base]
> The Web Connector should respect this element when handling relative links.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Comment Edited] (CONNECTORS-1680) WebConnector: Support the Document Base URL element

2021-12-17 Thread Karl Wright (Jira) 


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461575#comment-17461575
 ] 

Karl Wright edited comment on CONNECTORS-1680 at 12/17/21, 5:22 PM:


The baseDocumentIdentifier code is new for adding the ability to set the base 
URL for all relative references, a change you requested and I implemented.

All relative document urls should be based on baseDocumentIdentifier, and that 
is initialized to be documentIdentifier at the start.  Since this is obviously 
not happening you are correct in your diagnosis.



was (Author: kwri...@metacarta.com):
The baseDocumentIdentifier code is new for adding the ability to set the base 
URL for all relative references, a change you requested and I implemented.

All relative document urls should be based on baseDocumentIdentifier, and that 
is initialized to be documentIdentifier at the start.


> WebConnector: Support the Document Base URL element
> ---
>
> Key: CONNECTORS-1680
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1680
> Project: ManifoldCF
>  Issue Type: Improvement
>  Components: Web connector
>Reporter: Markus Schuch
>Assignee: Karl Wright
>Priority: Major
> Fix For: ManifoldCF 2.21
>
>
> HTML allows to specifiy the base URL to use for all relative URLs in a 
> document:
> {code:java}
> 
>   
>
> https://example.org/"/>
> ...
>   
>...
> {code}
> [https://developer.mozilla.org/de/docs/Web/HTML/Element/base]
> The Web Connector should respect this element when handling relative links.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Comment Edited] (CONNECTORS-1680) WebConnector: Support the Document Base URL element

2021-12-17 Thread Markus Schuch (Jira) 


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461555#comment-17461555
 ] 

Markus Schuch edited comment on CONNECTORS-1680 at 12/17/21, 4:44 PM:
--

I think this is actually causes the issue:
{quote}
I also looked over the code changes. One minor issue: the assignment of 
{{baseDocumentIdentifier}} in the constructor of {{ProcessActivityLinkHandler}} 
looks useless (assigned to itself) --> 
[https://github.com/apache/manifoldcf/commit/8b88d6d44aba54ee276619340ad36a9cc441932d#diff-9fff09bc306de2115d24403a5fe1c3c9fe831d30a54448291f1f90b4d5c6b2a7R3889]
{quote}

This should be the fix, right?
{code:java}
this.baseDocumentIdentifier = documentIdentifier; 
{code}
 


was (Author: schuchm):
I think this is actually causes the issue:
{quote}I also looked over the code changes. One minor issue: the assignment of 
{{baseDocumentIdentifier}} in the constructor of {{ProcessActivityLinkHandler}} 
looks useless (assigned to itself) --> 
[https://github.com/apache/manifoldcf/commit/8b88d6d44aba54ee276619340ad36a9cc441932d#diff-9fff09bc306de2115d24403a5fe1c3c9fe831d30a54448291f1f90b4d5c6b2a7R3889]
{quote}

This should be the fix, right?
{code:java}
this.baseDocumentIdentifier = documentIdentifier; 
{code}
 

> WebConnector: Support the Document Base URL element
> ---
>
> Key: CONNECTORS-1680
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1680
> Project: ManifoldCF
>  Issue Type: Improvement
>  Components: Web connector
>Reporter: Markus Schuch
>Assignee: Karl Wright
>Priority: Major
> Fix For: ManifoldCF 2.21
>
>
> HTML allows to specifiy the base URL to use for all relative URLs in a 
> document:
> {code:java}
> 
>   
>
> https://example.org/"/>
> ...
>   
>...
> {code}
> [https://developer.mozilla.org/de/docs/Web/HTML/Element/base]
> The Web Connector should respect this element when handling relative links.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)