[jira] [Commented] (CONNECTORS-1712) Broken Velocity UI

2022-05-09 Thread Markus Schuch (Jira)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533638#comment-17533638
 ] 

Markus Schuch commented on CONNECTORS-1712:
---

[~kwri...@metacarta.com] can confirm, r1900711 fixes the problem.

Sidenote: The maven pom.xml still contains a reference to velocity 1.7.

> Broken Velocity UI
> --
>
> Key: CONNECTORS-1712
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1712
> Project: ManifoldCF
>  Issue Type: Bug
>  Components: API
>Affects Versions: ManifoldCF 2.22
>Reporter: Julien Massiera
>Assignee: Karl Wright
>Priority: Critical
> Fix For: ManifoldCF 2.23, ManifoldCF 2.22.1
>
>
> In the mcf-crawler-ui, we cannot enter in edition mode for any connector 
> because there is a problem with Velocity.
> We obtain the following error in the logs:
>  
> {code:java}
> java.lang.NoSuchMethodError: 'void 
> org.apache.velocity.app.VelocityEngine.setExtendedProperties(org.apache.commons.collections.ExtendedProperties)'
>     at 
> org.apache.manifoldcf.core.i18n.Messages.createVelocityEngine(Messages.java:62)
>  ~[mcf-core.jar:?]
>     at 
> org.apache.manifoldcf.ui.i18n.Messages.outputResourceWithVelocity(Messages.java:132)
>  ~[mcf-ui-core.jar:?]
>     at 
> com.francelabs.datafari.connectors.share.Messages.outputResourceWithVelocity(Messages.java:111)
>  ~[?:?]
>     at 
> com.francelabs.datafari.connectors.share.SharedDriveConnector.outputSpecificationHeader(SharedDriveConnector.java:2829)
>  ~[?:?]
>     at org.apache.jsp.editjob_jsp._jspService(editjob_jsp.java:977) 
> ~[mcf-crawler-ui.jar:?]
>     at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:466)
>  ~[jasper.jar:9.0.56]
>     at 
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:379) 
> ~[jasper.jar:9.0.56]
>     at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:327) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> ~[tomcat-websocket.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:687)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357) 
> [catalina.jar:9.0.56]
>     at org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:433) 
> [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:895)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1732)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
>  [tomcat-util.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
>  [tomcat-util.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  [tomcat-util.jar:9.0.56]
>     at 

[jira] [Commented] (CONNECTORS-1712) Broken Velocity UI

2022-05-08 Thread Karl Wright (Jira)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533542#comment-17533542
 ] 

Karl Wright commented on CONNECTORS-1712:
-

Committed r1900711 which I confirmed does fix the problem.

The functionality that was there before still exists but you cannot do it with 
a simple "setConfiguration".  You have to add a property afterwards with 
another command.  I could only find this by inspecting the code.



> Broken Velocity UI
> --
>
> Key: CONNECTORS-1712
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1712
> Project: ManifoldCF
>  Issue Type: Bug
>  Components: API
>Affects Versions: ManifoldCF 2.22
>Reporter: Julien Massiera
>Assignee: Karl Wright
>Priority: Critical
>
> In the mcf-crawler-ui, we cannot enter in edition mode for any connector 
> because there is a problem with Velocity.
> We obtain the following error in the logs:
>  
> {code:java}
> java.lang.NoSuchMethodError: 'void 
> org.apache.velocity.app.VelocityEngine.setExtendedProperties(org.apache.commons.collections.ExtendedProperties)'
>     at 
> org.apache.manifoldcf.core.i18n.Messages.createVelocityEngine(Messages.java:62)
>  ~[mcf-core.jar:?]
>     at 
> org.apache.manifoldcf.ui.i18n.Messages.outputResourceWithVelocity(Messages.java:132)
>  ~[mcf-ui-core.jar:?]
>     at 
> com.francelabs.datafari.connectors.share.Messages.outputResourceWithVelocity(Messages.java:111)
>  ~[?:?]
>     at 
> com.francelabs.datafari.connectors.share.SharedDriveConnector.outputSpecificationHeader(SharedDriveConnector.java:2829)
>  ~[?:?]
>     at org.apache.jsp.editjob_jsp._jspService(editjob_jsp.java:977) 
> ~[mcf-crawler-ui.jar:?]
>     at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:466)
>  ~[jasper.jar:9.0.56]
>     at 
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:379) 
> ~[jasper.jar:9.0.56]
>     at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:327) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> ~[tomcat-websocket.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:687)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357) 
> [catalina.jar:9.0.56]
>     at org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:433) 
> [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:895)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1732)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
>  [tomcat-util.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
>  [tomcat-util.jar:9.0.56]
>     at 
> 

[jira] [Commented] (CONNECTORS-1712) Broken Velocity UI

2022-05-08 Thread Karl Wright (Jira)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533538#comment-17533538
 ] 

Karl Wright commented on CONNECTORS-1712:
-

[~schuch], yes, this approach will not work.

There is no other way than to get an object through that can be seen when the 
Resource Loader's init(ExtProperties) method is called.  There does not seem to 
be documentation on how to do it if indeed it is possible.  I would suggest 
reviewing the Velocity 2.x codebase to see if there might be a way.  If not I 
propose attempting to extend the VelocityEngine class to allow the addition of 
a method that does what we need.


> Broken Velocity UI
> --
>
> Key: CONNECTORS-1712
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1712
> Project: ManifoldCF
>  Issue Type: Bug
>  Components: API
>Affects Versions: ManifoldCF 2.22
>Reporter: Julien Massiera
>Assignee: Karl Wright
>Priority: Critical
>
> In the mcf-crawler-ui, we cannot enter in edition mode for any connector 
> because there is a problem with Velocity.
> We obtain the following error in the logs:
>  
> {code:java}
> java.lang.NoSuchMethodError: 'void 
> org.apache.velocity.app.VelocityEngine.setExtendedProperties(org.apache.commons.collections.ExtendedProperties)'
>     at 
> org.apache.manifoldcf.core.i18n.Messages.createVelocityEngine(Messages.java:62)
>  ~[mcf-core.jar:?]
>     at 
> org.apache.manifoldcf.ui.i18n.Messages.outputResourceWithVelocity(Messages.java:132)
>  ~[mcf-ui-core.jar:?]
>     at 
> com.francelabs.datafari.connectors.share.Messages.outputResourceWithVelocity(Messages.java:111)
>  ~[?:?]
>     at 
> com.francelabs.datafari.connectors.share.SharedDriveConnector.outputSpecificationHeader(SharedDriveConnector.java:2829)
>  ~[?:?]
>     at org.apache.jsp.editjob_jsp._jspService(editjob_jsp.java:977) 
> ~[mcf-crawler-ui.jar:?]
>     at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:466)
>  ~[jasper.jar:9.0.56]
>     at 
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:379) 
> ~[jasper.jar:9.0.56]
>     at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:327) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> ~[tomcat-websocket.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:687)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357) 
> [catalina.jar:9.0.56]
>     at org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:433) 
> [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:895)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1732)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
>  

[jira] [Commented] (CONNECTORS-1712) Broken Velocity UI

2022-05-08 Thread Markus Schuch (Jira)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533451#comment-17533451
 ] 

Markus Schuch commented on CONNECTORS-1712:
---

{{Class.forName}} seems not be able to resolve 
{{org.apache.manifoldcf.crawler.connectors.webcrawler.Messages}}. 
{{Class.forName}} uses the ClassLoader of the calling class. Presumably this is 
the wrong ClassLoader?

> Broken Velocity UI
> --
>
> Key: CONNECTORS-1712
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1712
> Project: ManifoldCF
>  Issue Type: Bug
>  Components: API
>Affects Versions: ManifoldCF 2.22
>Reporter: Julien Massiera
>Assignee: Karl Wright
>Priority: Critical
>
> In the mcf-crawler-ui, we cannot enter in edition mode for any connector 
> because there is a problem with Velocity.
> We obtain the following error in the logs:
>  
> {code:java}
> java.lang.NoSuchMethodError: 'void 
> org.apache.velocity.app.VelocityEngine.setExtendedProperties(org.apache.commons.collections.ExtendedProperties)'
>     at 
> org.apache.manifoldcf.core.i18n.Messages.createVelocityEngine(Messages.java:62)
>  ~[mcf-core.jar:?]
>     at 
> org.apache.manifoldcf.ui.i18n.Messages.outputResourceWithVelocity(Messages.java:132)
>  ~[mcf-ui-core.jar:?]
>     at 
> com.francelabs.datafari.connectors.share.Messages.outputResourceWithVelocity(Messages.java:111)
>  ~[?:?]
>     at 
> com.francelabs.datafari.connectors.share.SharedDriveConnector.outputSpecificationHeader(SharedDriveConnector.java:2829)
>  ~[?:?]
>     at org.apache.jsp.editjob_jsp._jspService(editjob_jsp.java:977) 
> ~[mcf-crawler-ui.jar:?]
>     at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:466)
>  ~[jasper.jar:9.0.56]
>     at 
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:379) 
> ~[jasper.jar:9.0.56]
>     at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:327) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> ~[tomcat-websocket.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:687)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357) 
> [catalina.jar:9.0.56]
>     at org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:433) 
> [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:895)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1732)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
>  [tomcat-util.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
>  [tomcat-util.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  

[jira] [Commented] (CONNECTORS-1712) Broken Velocity UI

2022-05-08 Thread Markus Schuch (Jira)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533432#comment-17533432
 ] 

Markus Schuch commented on CONNECTORS-1712:
---

I saw the following Stacktrace when trying to create a web connector repository 
connection:

{code}
Stacktrace:
at 
org.apache.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrapper.java:521)
at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:430)
at 
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:313)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:260)
at 
org.eclipse.jetty.jsp.JettyJspServlet.service(JettyJspServlet.java:102)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at 
org.eclipse.jetty.servlet.ServletHolder$NotAsyncServlet.service(ServletHolder.java:1395)
at 
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:755)
at 
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:547)
at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
at 
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:608)
at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
at 
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1607)
at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
at 
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1297)
at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
at 
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:485)
at 
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1577)
at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
at 
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1212)
at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at org.eclipse.jetty.server.Dispatcher.forward(Dispatcher.java:220)
at org.eclipse.jetty.server.Dispatcher.forward(Dispatcher.java:79)
at 
org.apache.jasper.runtime.PageContextImpl.doForward(PageContextImpl.java:709)
at 
org.apache.jasper.runtime.PageContextImpl.forward(PageContextImpl.java:680)
at org.apache.jsp.execute_jsp._jspService(execute_jsp.java:338)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:388)
... 39 more
Caused by: java.lang.RuntimeException: Velocity could not be initialized!
at 
org.apache.velocity.runtime.RuntimeInstance.requireInitialization(RuntimeInstance.java:376)
at 
org.apache.velocity.runtime.RuntimeInstance.getTemplate(RuntimeInstance.java:1674)
at 
org.apache.velocity.app.VelocityEngine.mergeTemplate(VelocityEngine.java:284)
at 
org.apache.manifoldcf.ui.i18n.Messages.outputResourceWithVelocity(Messages.java:159)
at 
org.apache.manifoldcf.crawler.connectors.webcrawler.Messages.outputResourceWithVelocity(Messages.java:136)
at 
org.apache.manifoldcf.crawler.connectors.webcrawler.WebcrawlerConnector.outputConfigurationHeader(WebcrawlerConnector.java:1575)
at 
org.apache.manifoldcf.core.interfaces.ConnectorFactory.outputThisConfigurationHeader(ConnectorFactory.java:71)
at 
org.apache.manifoldcf.crawler.interfaces.RepositoryConnectorFactory.outputConfigurationHeader(RepositoryConnectorFactory.java:147)
at 
org.apache.jsp.editconnection_jsp._jspService(editconnection_jsp.java:451)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:388)
... 67 more
Caused by: java.lang.NullPointerException
at 
org.apache.manifoldcf.core.i18n.MCFVelocityResourceLoader.getResourceStream(MCFVelocityResourceLoader.java:57)
at 
org.apache.manifoldcf.core.i18n.MCFVelocityResourceLoader.getResourceReader(MCFVelocityResourceLoader.java:48)
at 
org.apache.velocity.runtime.resource.loader.ResourceLoader.resourceExists(ResourceLoader.java:245)
at 
org.apache.velocity.runtime.resource.ResourceManagerImpl.getLoaderForResource(ResourceManagerImpl.java:598)
at 
org.apache.velocity.runtime.resource.ResourceManagerImpl.getLoaderNameForResource(ResourceManagerImpl.java:582)

[jira] [Commented] (CONNECTORS-1712) Broken Velocity UI

2022-05-08 Thread Karl Wright (Jira)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533414#comment-17533414
 ] 

Karl Wright commented on CONNECTORS-1712:
-

I committed a tentative fix to trunk: r1900677

The way this fix works is to convert the class instance to a fully-qualified 
class name and pass that.  Then, inside the custom resource loader, I turn the 
class name back to a Class object using Class.forName().  That, of course, uses 
the class loader in place at that moment, which (crosses fingers) may always be 
one for which the Class can be loaded, even it it's inside a connector and we 
need the connector class path loader.  The VelocityContext is initialized 
inside a Connector method, after all, so that should be the case.

[~julienFL], you should be able to try this for your example using the 
following steps:

(1) Check out a fresh copy of mcf trunk.
(2) ant make-core-deps (should not download 1.7 anymore)
(3) ant build
(4) cd dist/example
(5) start, and try this out.

Please let me know ASAP if this is working as expected, or if there are 
problems.


> Broken Velocity UI
> --
>
> Key: CONNECTORS-1712
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1712
> Project: ManifoldCF
>  Issue Type: Bug
>  Components: API
>Affects Versions: ManifoldCF 2.22
>Reporter: Julien Massiera
>Assignee: Karl Wright
>Priority: Critical
>
> In the mcf-crawler-ui, we cannot enter in edition mode for any connector 
> because there is a problem with Velocity.
> We obtain the following error in the logs:
>  
> {code:java}
> java.lang.NoSuchMethodError: 'void 
> org.apache.velocity.app.VelocityEngine.setExtendedProperties(org.apache.commons.collections.ExtendedProperties)'
>     at 
> org.apache.manifoldcf.core.i18n.Messages.createVelocityEngine(Messages.java:62)
>  ~[mcf-core.jar:?]
>     at 
> org.apache.manifoldcf.ui.i18n.Messages.outputResourceWithVelocity(Messages.java:132)
>  ~[mcf-ui-core.jar:?]
>     at 
> com.francelabs.datafari.connectors.share.Messages.outputResourceWithVelocity(Messages.java:111)
>  ~[?:?]
>     at 
> com.francelabs.datafari.connectors.share.SharedDriveConnector.outputSpecificationHeader(SharedDriveConnector.java:2829)
>  ~[?:?]
>     at org.apache.jsp.editjob_jsp._jspService(editjob_jsp.java:977) 
> ~[mcf-crawler-ui.jar:?]
>     at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:466)
>  ~[jasper.jar:9.0.56]
>     at 
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:379) 
> ~[jasper.jar:9.0.56]
>     at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:327) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> ~[tomcat-websocket.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:687)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357) 
> [catalina.jar:9.0.56]
>     at org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:433) 
> [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> 

[jira] [Commented] (CONNECTORS-1712) Broken Velocity UI

2022-05-07 Thread Karl Wright (Jira)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533366#comment-17533366
 ] 

Karl Wright commented on CONNECTORS-1712:
-

This was the Velocity 1.x code:

{code}
/**
 * Resource loader can be loaded either via class name or be passed 
 * in as an instance. 
 */ 
ExtendedProperties configuration = (ExtendedProperties) it.next(); 
 
String loaderClass = 
StringUtils.nullTrim(configuration.getString("class")); 
ResourceLoader loaderInstance = (ResourceLoader) 
configuration.get("instance"); 
 
if (loaderInstance != null) 
{ 
resourceLoader = loaderInstance; 
} 
else if (loaderClass != null) 
{ 
resourceLoader = ResourceLoaderFactory.getLoader(rsvc, 
loaderClass); 
} 
else 
{ 
String msg = "Unable to find '" + 
  configuration.getString(RESOURCE_LOADER_IDENTIFIER) + 
  ".resource.loader.class' specification in 
configuration." + 
  " This is a critical value.  Please adjust 
configuration."; 
log.error(msg); 
throw new VelocityException(msg); 
} 
 
resourceLoader.commonInit(rsvc, configuration); 
resourceLoader.init(configuration); 
resourceLoaders.add(resourceLoader); 
{code}

Note how you had your choice of providing the class (as a string), or the 
instance (as an object of type ResourceLoader).  AFAICT, they simply removed 
the "instance" option entirely in Velocity 2.x.  We need to find a way of doing 
the same thing.


> Broken Velocity UI
> --
>
> Key: CONNECTORS-1712
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1712
> Project: ManifoldCF
>  Issue Type: Bug
>  Components: API
>Affects Versions: ManifoldCF 2.22
>Reporter: Julien Massiera
>Assignee: Karl Wright
>Priority: Critical
>
> In the mcf-crawler-ui, we cannot enter in edition mode for any connector 
> because there is a problem with Velocity.
> We obtain the following error in the logs:
>  
> {code:java}
> java.lang.NoSuchMethodError: 'void 
> org.apache.velocity.app.VelocityEngine.setExtendedProperties(org.apache.commons.collections.ExtendedProperties)'
>     at 
> org.apache.manifoldcf.core.i18n.Messages.createVelocityEngine(Messages.java:62)
>  ~[mcf-core.jar:?]
>     at 
> org.apache.manifoldcf.ui.i18n.Messages.outputResourceWithVelocity(Messages.java:132)
>  ~[mcf-ui-core.jar:?]
>     at 
> com.francelabs.datafari.connectors.share.Messages.outputResourceWithVelocity(Messages.java:111)
>  ~[?:?]
>     at 
> com.francelabs.datafari.connectors.share.SharedDriveConnector.outputSpecificationHeader(SharedDriveConnector.java:2829)
>  ~[?:?]
>     at org.apache.jsp.editjob_jsp._jspService(editjob_jsp.java:977) 
> ~[mcf-crawler-ui.jar:?]
>     at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:466)
>  ~[jasper.jar:9.0.56]
>     at 
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:379) 
> ~[jasper.jar:9.0.56]
>     at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:327) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> ~[tomcat-websocket.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135) 
> [catalina.jar:9.0.56]
>     at 
> 

[jira] [Commented] (CONNECTORS-1712) Broken Velocity UI

2022-05-07 Thread Karl Wright (Jira)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533364#comment-17533364
 ] 

Karl Wright commented on CONNECTORS-1712:
-

See:

framework\core\src\main\java\org\apache\manifoldcf\core\i18n\Messages.java

This is where the velocity engine initialization takes place, and a Class 
instance needs to make it somehow into the resource loader for this to all work 
right.  Any ideas?  I've got a modernized version of the resource loader 
updated that looks for this Class in the ExtProperties object passed into the 
init() method but I don't know how I can push it into there during Velocity 
engine setup.  Help???


> Broken Velocity UI
> --
>
> Key: CONNECTORS-1712
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1712
> Project: ManifoldCF
>  Issue Type: Bug
>  Components: API
>Affects Versions: ManifoldCF 2.22
>Reporter: Julien Massiera
>Assignee: Karl Wright
>Priority: Critical
>
> In the mcf-crawler-ui, we cannot enter in edition mode for any connector 
> because there is a problem with Velocity.
> We obtain the following error in the logs:
>  
> {code:java}
> java.lang.NoSuchMethodError: 'void 
> org.apache.velocity.app.VelocityEngine.setExtendedProperties(org.apache.commons.collections.ExtendedProperties)'
>     at 
> org.apache.manifoldcf.core.i18n.Messages.createVelocityEngine(Messages.java:62)
>  ~[mcf-core.jar:?]
>     at 
> org.apache.manifoldcf.ui.i18n.Messages.outputResourceWithVelocity(Messages.java:132)
>  ~[mcf-ui-core.jar:?]
>     at 
> com.francelabs.datafari.connectors.share.Messages.outputResourceWithVelocity(Messages.java:111)
>  ~[?:?]
>     at 
> com.francelabs.datafari.connectors.share.SharedDriveConnector.outputSpecificationHeader(SharedDriveConnector.java:2829)
>  ~[?:?]
>     at org.apache.jsp.editjob_jsp._jspService(editjob_jsp.java:977) 
> ~[mcf-crawler-ui.jar:?]
>     at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:466)
>  ~[jasper.jar:9.0.56]
>     at 
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:379) 
> ~[jasper.jar:9.0.56]
>     at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:327) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> ~[tomcat-websocket.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:687)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357) 
> [catalina.jar:9.0.56]
>     at org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:433) 
> [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:895)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1732)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
>  

[jira] [Commented] (CONNECTORS-1712) Broken Velocity UI

2022-05-07 Thread Karl Wright (Jira)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533362#comment-17533362
 ] 

Karl Wright commented on CONNECTORS-1712:
-

The problem is that we allow velocity templates to be associated with a class 
instance, and in order for that to work right somehow the class instance has to 
get into our custom velocity resource loader.  We were passing it as a 
constructor argument but we no longer are allowed to instantiate it ourselves.  
The velocity resource loader does receive an ExtProperties object which can 
include a Class property, but I don't know how to set this in the velocity 
properties so that it makes it through somehow to the resource loader.

There's also a fundamental change to how logging is done by Velocity that will 
require work, but it is not insurmountable.  The first problem is currently 
insurmountable however and we may need to request Velocity changes to allow 
this to be done again.


> Broken Velocity UI
> --
>
> Key: CONNECTORS-1712
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1712
> Project: ManifoldCF
>  Issue Type: Bug
>  Components: API
>Affects Versions: ManifoldCF 2.22
>Reporter: Julien Massiera
>Assignee: Karl Wright
>Priority: Critical
>
> In the mcf-crawler-ui, we cannot enter in edition mode for any connector 
> because there is a problem with Velocity.
> We obtain the following error in the logs:
>  
> {code:java}
> java.lang.NoSuchMethodError: 'void 
> org.apache.velocity.app.VelocityEngine.setExtendedProperties(org.apache.commons.collections.ExtendedProperties)'
>     at 
> org.apache.manifoldcf.core.i18n.Messages.createVelocityEngine(Messages.java:62)
>  ~[mcf-core.jar:?]
>     at 
> org.apache.manifoldcf.ui.i18n.Messages.outputResourceWithVelocity(Messages.java:132)
>  ~[mcf-ui-core.jar:?]
>     at 
> com.francelabs.datafari.connectors.share.Messages.outputResourceWithVelocity(Messages.java:111)
>  ~[?:?]
>     at 
> com.francelabs.datafari.connectors.share.SharedDriveConnector.outputSpecificationHeader(SharedDriveConnector.java:2829)
>  ~[?:?]
>     at org.apache.jsp.editjob_jsp._jspService(editjob_jsp.java:977) 
> ~[mcf-crawler-ui.jar:?]
>     at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:466)
>  ~[jasper.jar:9.0.56]
>     at 
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:379) 
> ~[jasper.jar:9.0.56]
>     at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:327) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> ~[tomcat-websocket.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:687)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357) 
> [catalina.jar:9.0.56]
>     at org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:433) 
> [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:895)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> 

[jira] [Commented] (CONNECTORS-1712) Broken Velocity UI

2022-05-07 Thread Karl Wright (Jira)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533358#comment-17533358
 ] 

Karl Wright commented on CONNECTORS-1712:
-

So what changed was that Tika now requires Velocity 2.x and our UI requires 
Velocity 1.7 still.
The upgrade is nowhere near as simple as just what is stated; I'm working on it 
but seems like we need to fundamentally change much more about how we set up 
Velocity under 2.x.



> Broken Velocity UI
> --
>
> Key: CONNECTORS-1712
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1712
> Project: ManifoldCF
>  Issue Type: Bug
>  Components: API
>Affects Versions: ManifoldCF 2.22
>Reporter: Julien Massiera
>Priority: Critical
>
> In the mcf-crawler-ui, we cannot enter in edition mode for any connector 
> because there is a problem with Velocity.
> We obtain the following error in the logs:
>  
> {code:java}
> java.lang.NoSuchMethodError: 'void 
> org.apache.velocity.app.VelocityEngine.setExtendedProperties(org.apache.commons.collections.ExtendedProperties)'
>     at 
> org.apache.manifoldcf.core.i18n.Messages.createVelocityEngine(Messages.java:62)
>  ~[mcf-core.jar:?]
>     at 
> org.apache.manifoldcf.ui.i18n.Messages.outputResourceWithVelocity(Messages.java:132)
>  ~[mcf-ui-core.jar:?]
>     at 
> com.francelabs.datafari.connectors.share.Messages.outputResourceWithVelocity(Messages.java:111)
>  ~[?:?]
>     at 
> com.francelabs.datafari.connectors.share.SharedDriveConnector.outputSpecificationHeader(SharedDriveConnector.java:2829)
>  ~[?:?]
>     at org.apache.jsp.editjob_jsp._jspService(editjob_jsp.java:977) 
> ~[mcf-crawler-ui.jar:?]
>     at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:466)
>  ~[jasper.jar:9.0.56]
>     at 
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:379) 
> ~[jasper.jar:9.0.56]
>     at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:327) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> ~[tomcat-websocket.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:687)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357) 
> [catalina.jar:9.0.56]
>     at org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:433) 
> [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:895)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1732)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
>  [tomcat-util.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
>  [tomcat-util.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  

[jira] [Commented] (CONNECTORS-1712) Broken Velocity UI

2022-05-07 Thread Karl Wright (Jira)


[ 
https://issues.apache.org/jira/browse/CONNECTORS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533351#comment-17533351
 ] 

Karl Wright commented on CONNECTORS-1712:
-

Looking into why the old dependency is still downloaded.  It should not be 
unless it was not properly cleaned.


> Broken Velocity UI
> --
>
> Key: CONNECTORS-1712
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1712
> Project: ManifoldCF
>  Issue Type: Bug
>  Components: API
>Affects Versions: ManifoldCF 2.22
>Reporter: Julien Massiera
>Priority: Critical
>
> In the mcf-crawler-ui, we cannot enter in edition mode for any connector 
> because there is a problem with Velocity.
> We obtain the following error in the logs:
>  
> {code:java}
> java.lang.NoSuchMethodError: 'void 
> org.apache.velocity.app.VelocityEngine.setExtendedProperties(org.apache.commons.collections.ExtendedProperties)'
>     at 
> org.apache.manifoldcf.core.i18n.Messages.createVelocityEngine(Messages.java:62)
>  ~[mcf-core.jar:?]
>     at 
> org.apache.manifoldcf.ui.i18n.Messages.outputResourceWithVelocity(Messages.java:132)
>  ~[mcf-ui-core.jar:?]
>     at 
> com.francelabs.datafari.connectors.share.Messages.outputResourceWithVelocity(Messages.java:111)
>  ~[?:?]
>     at 
> com.francelabs.datafari.connectors.share.SharedDriveConnector.outputSpecificationHeader(SharedDriveConnector.java:2829)
>  ~[?:?]
>     at org.apache.jsp.editjob_jsp._jspService(editjob_jsp.java:977) 
> ~[mcf-crawler-ui.jar:?]
>     at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:466)
>  ~[jasper.jar:9.0.56]
>     at 
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:379) 
> ~[jasper.jar:9.0.56]
>     at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:327) 
> ~[jasper.jar:9.0.56]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> ~[servlet-api.jar:4.0.FR]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> ~[tomcat-websocket.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  ~[catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:687)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)
>  [catalina.jar:9.0.56]
>     at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357) 
> [catalina.jar:9.0.56]
>     at org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:433) 
> [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:895)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1732)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
>  [tomcat-coyote.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
>  [tomcat-util.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
>  [tomcat-util.jar:9.0.56]
>     at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  [tomcat-util.jar:9.0.56]
>     at java.lang.Thread.run(Thread.java:829) [?:?] {code}
>  
>  
> After some investigations it seems related to the updated velocity lib