Re: MCF transformation connector contribution

2018-05-09 Thread Karl Wright
I committed the latest code changes. As far as the doc is concerned, that's going to take longer because a conversion to Forrest will need to be done. Karl On Wed, May 9, 2018 at 10:21 AM Olivier Tavard < olivier.tav...@francelabs.com> wrote: > Hi, > > OK thank you for the explanation and for

Re: MCF transformation connector contribution

2018-05-09 Thread Olivier Tavard
Hi, OK thank you for the explanation and for the contribution integration. I did not know that the contribution was already part of the 2.10 release. I submitted a patch englobing the first patch and the new code on the JIRA issue : CONNECTORS-1500. It is a diff against the html extractor

Re: MCF transformation connector contribution

2018-05-05 Thread Piergiorgio Lucidi
Hi, I have just updated the CHANGES.txt adding CONNECTORS-1500 included in the 2.10 release with a mention to Olivier. Olivier, thank you so much for your contribution. We should find a good way to also create a test suite for this new connector. Cheers, PJ 2018-05-05 11:57 GMT+02:00 Karl

Re: MCF transformation connector contribution

2018-05-05 Thread Karl Wright
Hi Olivier, This was actually already committed. But it was renamed as the html-extractor connector, not "datafari", which didn't mean anything to me. Any changes you want to make should therefore be supplied as a diff against the html-extractor connector. Sorry for the confusion!! Karl On

Re: MCF transformation connector contribution

2018-05-04 Thread Karl Wright
Yes, please do update the patch. I'm sorry I did not get to this; many other things intruded. I created the branch but did not apply the original patch onto it, so please supply a whole new patch. Karl On Fri, May 4, 2018 at 11:28 AM Olivier Tavard < olivier.tav...@francelabs.com> wrote: >

Re: MCF transformation connector contribution

2018-05-04 Thread Olivier Tavard
Hi, I wanted to know if the code remains interesting for the MCF community. I updated it since the initial release so please tell me if I need to submit a new patch into the issue already created : https://issues.apache.org/jira/projects/CONNECTORS/issues/CONNECTORS-1500

Re: MCF transformation connector contribution

2018-03-15 Thread Karl Wright
Excellent!! Thank you again. I'll try to set up the branch this weekend. Karl On Thu, Mar 15, 2018 at 10:52 AM, Olivier Tavard < olivier.tav...@francelabs.com> wrote: > Hi Karl, > > Sure thing, I created a ticket : https://issues.apache.org/ > jira/projects/CONNECTORS/issues/CONNECTORS-1500

Re: MCF transformation connector contribution

2018-03-15 Thread Olivier Tavard
Hi Karl, Sure thing, I created a ticket : https://issues.apache.org/jira/projects/CONNECTORS/issues/CONNECTORS-1500 with the code in attachment. No specific libraries used, just JSOUP library that is already in the MCF core project. Best regards, Olivier > Le 15 mars 2018 à 11:51, Karl

Re: MCF transformation connector contribution

2018-03-15 Thread Karl Wright
Hi Oliver, Thank you very much for your contribution! To have a legal trail, I usually prefer the following approach -- (1) Create a ticket (2) Attach a diff to the ticket We'll then integrate the diff into a branch, and then finally into trunk. Can you also let us know what kinds of

MCF transformation connector contribution

2018-03-15 Thread Olivier Tavard
Hello MCF community, I developed a transformation connector based on Jsoup. The goal of this code id to simply choose an encompassing tag in a HTML document for text extracting. And inside this tag, this connector allows you to remove subparts that you do no want : all the tags corresponding