Updating documentation for artifactId

2008-10-20 Thread Rodney Beede
It'd be nice if the documentation for maven included what characters were invalid for the value of artifactId in the pom. Rodney - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Eugene Kuleshov
Oleg, please make a large bold warning in the documentation for those parameters about issues they could cause in the IDE. I still think it is a huge mistake to encourage such features for Maven, which supposed to support best practices. regards, Eugene Oleg Gusakov wrote: > > Chang

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Oleg Gusakov
I made the easiest and straightforward change, fully backward compatible. I will look at toolchains later on, when I make more serious changes. Thanks, Oleg Brett Porter wrote: What about considering toolchains? - Brett On 21/10/2008, at 2:41 AM, Oleg Gusakov wrote: Looks like we reached a

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Oleg Gusakov
Changes made on 2.1-SNAPSHOT trunk, binary snapshot published on apache snapshots. Added support for: * testSource * testSource * testCompilerArgument * testCompilerArguments Details, sample config: http://jira.codehaus.org/browse/MCOMPILER-83 Brian E. Fox wrote: Well yeah, that’s the correc

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Brett Porter
What about considering toolchains? - Brett On 21/10/2008, at 2:41 AM, Oleg Gusakov wrote: Looks like we reached a consensus here, I will add the params. Thanks everyone for discussion and guidance! Michael McCallum wrote: eclipse already blends test and compile scopes... if it plays havoc

RE: compiler plugin: separate test compiler configuration

2008-10-20 Thread Brian E. Fox
Well yeah, that’s the correct fix but requires maven core changes. -Original Message- From: Oleg Gusakov [mailto:[EMAIL PROTECTED] Sent: Monday, October 20, 2008 1:18 PM To: Maven Developers List Subject: Re: compiler plugin: separate test compiler configuration Or if plugin instance wer

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Oleg Gusakov
Or if plugin instance were created per execution invocation. Right now it seems like plugin instance is created and initialized once, and execution is passed the same instance. The above is speculation, based on the observed effect. I did not check the actual code. Brian E. Fox wrote: It co

RE: compiler plugin: separate test compiler configuration

2008-10-20 Thread Brian E. Fox
It could work if the plugin took different params for test mode. -Original Message- From: Oleg Gusakov [mailto:[EMAIL PROTECTED] Sent: Monday, October 20, 2008 12:38 PM To: Maven Developers List Subject: Re: compiler plugin: separate test compiler configuration Milos - it does not :( Mi

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Oleg Gusakov
Milos - it does not :( Milos Kleint wrote: I'm not sure we did. The execution based config for testCompile doesn't really work? Milos On Mon, Oct 20, 2008 at 5:41 PM, Oleg Gusakov <[EMAIL PROTECTED]> wrote: Looks like we reached a consensus here, I will add the params. Thanks everyone for

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Milos Kleint
I'm not sure we did. The execution based config for testCompile doesn't really work? Milos On Mon, Oct 20, 2008 at 5:41 PM, Oleg Gusakov <[EMAIL PROTECTED]> wrote: > Looks like we reached a consensus here, I will add the params. > > Thanks everyone for discussion and guidance! > > Michael McCallu

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Oleg Gusakov
Looks like we reached a consensus here, I will add the params. Thanks everyone for discussion and guidance! Michael McCallum wrote: eclipse already blends test and compile scopes... if it plays havoc with your build just don't use the feature... Brian E. Fox wrote: Milos, you can say that's

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Michael McCallum
eclipse already blends test and compile scopes... if it plays havoc with your build just don't use the feature... On Mon, 20 Oct 2008 20:16:18 Daniel Le Berre wrote: > Brian E. Fox a écrit : > >> Milos, you can say that's eclipse's problem. But is't a majority of > >> users, whether it's good or

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Daniel Le Berre
Brian E. Fox a écrit : Milos, you can say that's eclipse's problem. But is't a majority of users, whether it's good or bad, we need to respect that use case. I think it should be allowed. Just because Eclipse can't do it doesn't mean maven shouldn't. It just means if you want to use eclipse an