Re: Latest modello breaks maven core unit test

2013-08-05 Thread Kristian Rosenvold
FYI; I reverted the entire change to MODELLO-209, since there were significant problems with that change. I'll be releasing 1.8 tonight (or tomorrow night); if Simone fixes MODELLO-209 after I have released I'll go for a quick 1.9 release. Kristian 2013/8/5 Barrie Treloar : > On 5 August 2013 21

Re: [DISCUSS] On the Maven PMC roles... (was [DISCUSS] Should the Maven PMC be an example of how we want the Maven Community to behave...)

2013-08-05 Thread Brian Fox
Yes, I will take a pass tonight. On Mon, Aug 5, 2013 at 6:55 AM, Stephen Connolly wrote: > Brian, > > Did you have any suggested changes to the forks section wording to clear up > my intent for that section? > > I'd like to start wrapping this up and move towards making it "official" > > Everyone

Re: Latest modello breaks maven core unit test

2013-08-05 Thread Barrie Treloar
On 5 August 2013 21:15, Barrie Treloar wrote: > On 5 August 2013 20:55, Kristian Rosenvold > wrote: >> "no" :) >> >> I used m3 core as a case for trying out some new & interesting >> strategies for using a profiler, which I'll >> try to blog about pretty soon. Stupid mail... Remember to send b

Re: Latest modello breaks maven core unit test

2013-08-05 Thread Barrie Treloar
On 5 August 2013 20:55, Kristian Rosenvold wrote: > "no" :) > > I used m3 core as a case for trying out some new & interesting > strategies for using a profiler, which I'll > try to blog about pretty soon. - To unsubscribe, e-mai

Re: [DISCUSS] On the Maven PMC roles... (was [DISCUSS] Should the Maven PMC be an example of how we want the Maven Community to behave...)

2013-08-05 Thread Baptiste MATHUS
Some small formating or typos. Added commas in a long sentence around line 280 and another one around l298. I generally find it hard to concentrate on a whole sentence without commas (or even periods separating ideas). See https://gist.github.com/Batmat/6155302 for proposed patch. If you need any o

Re: Latest modello breaks maven core unit test

2013-08-05 Thread Kristian Rosenvold
"no" :) I used m3 core as a case for trying out some new & interesting strategies for using a profiler, which I'll try to blog about pretty soon. Remember that m3 core is pretty efficient as-is, so the gains are pretty marginal; in the area of a couple of seconds faster on a 1 minute build, give o

Re: Latest modello breaks maven core unit test

2013-08-05 Thread Kristian Rosenvold
Yes Robert, that is the URL of the commit that broke the unit test. Did you mean to say something more ? Kristian 2013/8/5 Robert Scholte : > https://github.com/sonatype/modello/commit/1284d155417209d2e1a063606a2c692f89e32152 > > Op Mon, 05 Aug 2013 12:38:42 +0200 schreef Barrie Treloar > : > > >

Re: Latest modello breaks maven core unit test

2013-08-05 Thread Robert Scholte
https://github.com/sonatype/modello/commit/1284d155417209d2e1a063606a2c692f89e32152 Op Mon, 05 Aug 2013 12:38:42 +0200 schreef Barrie Treloar : On 5 August 2013 17:54, Kristian Rosenvold wrote: the next core release; I did some pretty significant performance improvements to maven core tha

Re: [DISCUSS] On the Maven PMC roles... (was [DISCUSS] Should the Maven PMC be an example of how we want the Maven Community to behave...)

2013-08-05 Thread Stephen Connolly
Brian, Did you have any suggested changes to the forks section wording to clear up my intent for that section? I'd like to start wrapping this up and move towards making it "official" Everyone else, Time to shout out if you have any issues / suggested improvements on the content - Stephen On

Re: Latest modello breaks maven core unit test

2013-08-05 Thread Barrie Treloar
On 5 August 2013 17:54, Kristian Rosenvold wrote: > the next core release; I did some pretty significant > performance improvements to maven core that I'd like to have in the > next release :) You got links/changelog for those so I can look? --

Latest modello breaks maven core unit test

2013-08-05 Thread Kristian Rosenvold
Hervé/Simone: The latest version of modello breaks a unit test in m3 core, DefaultModelValidatorTest#testEmptyModule. I've tracked the problem down to commit 1284d155417209d2e1a063606a2c692f89e32152 in modello, and I was wondering if any of you could take a look at it ? I would like to push mode