Re: Open Test Alliance

2015-11-21 Thread Tibor Digana
@Johaness I introduced a concept [1] with new JUnit Runner for Lambda based JUnit. I was inspired by Proxy Test and the old concept [2]. This maybe helps. [1] https://github.com/junit-team/junit/issues/1078#issuecomment-158706736 [2] https://github.com/junit-team/junit/wiki/Quo-Vadis-JUnit Cheer

[GitHub] maven pull request: String handling issues identified by PMD

2015-11-21 Thread alexhenrie
Github user alexhenrie commented on the pull request: https://github.com/apache/maven/pull/72#issuecomment-158709078 @jvanzyl I can wait until you've finished your other changes, that's no problem. I haven't been able to measure the performance improvement because Maven's execution ti

Re: to delete windows build ?

2015-11-21 Thread Hervé BOUTEMY
ok, IIUC, this tweak seems about internal m-shade-p leaks: in such conditions, now that leaks are fixed, yes, let's just remove the code (or fix the plugin if another leak is found later) Regards, Hervé Le samedi 21 novembre 2015 15:13:15 Kristian Rosenvold a écrit : > Some background is in or

[GitHub] maven pull request: String handling issues identified by PMD

2015-11-21 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven/pull/72#issuecomment-158668300 Nowadays execution time of array allocation is logarithmic function(array.length). One way or another since of Java 6 the the objects are allocated in the stack instea

Re: to delete windows build ?

2015-11-21 Thread Tibor Digana
Who nowadays can rely on System.gc(). It may or may not trigger finalize(). Good job Kristian! I guess Kristian closed streams in MOJO execution() with no shutdown hook or something like that. On Sat, Nov 21, 2015 at 3:13 PM, Kristian Rosenvold < kristian.rosenv...@gmail.com> wrote: > Some back

Re: to delete windows build ?

2015-11-21 Thread Kristian Rosenvold
Some background is in order here; there are several file handle "leaks" that will actually lead to the file handle being closed in a finalizer. Which is why "shaking" System.gc a couple of times with a sleep/retry or two sometimes actually is effective if weird :) Within shade I just fixed all of

Re: to delete windows build ?

2015-11-21 Thread Martin W. Kirst
Hi regarding the System.gc() hack it's close to impossible to say how much gets freed. According to http://bugs.java.com/view_bug.do?bug_id=6668279 only unsed object references are discovered and _may_ get released. AFAIK streams or file handles aren't closed by GC directly, but sometimes when the

Re: to delete windows build ?

2015-11-21 Thread Hervé BOUTEMY
yes, should be deleted from a plugin silently doing such hacks: if we try to work around leaks issues, it should at least advertise that a leak was found, trying to show where the issue is Since there is currently no warning, I don't know how much issues will now be visible if the plugin simply

Re: to delete windows build ?

2015-11-21 Thread Karl Heinz Marbaise
Hi Kristian, On 11/21/15 9:33 AM, Kristian Rosenvold wrote: As some of you may have noticed, I have fixed a bunch of file handle leaks in the last weeks. This may eventually make running a CI on windows feasible :) The shade plugin was leaking like a sieve, and should now be fully watertight. T

Re: to delete windows build ?

2015-11-21 Thread Kristian Rosenvold
As some of you may have noticed, I have fixed a bunch of file handle leaks in the last weeks. This may eventually make running a CI on windows feasible :) The shade plugin was leaking like a sieve, and should now be fully watertight. There seems to be a few bits of silly code that I'd just like to