Github user mryan43 commented on the issue:
https://github.com/apache/maven/pull/114
Unfortunately, the system property is read only once in a static init block
in the JansiConsole class before the cli main method is invoked, so my change
doesn't work.
We have a kind of
Github user mryan43 commented on the issue:
https://github.com/apache/maven/pull/114
I will test with less and jenkins and comment again with results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/114
I think yes, grep doesn't do different. Please try the patch thoroughly!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mryan43 commented on the issue:
https://github.com/apache/maven/pull/114
Good idea to align the name of choices with grep, I just changed it.
About "isatty", do you think we should set the jansi.force system property
when --color is set to "always" ?
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/114
Two issues:
1. Unfortunately, Commons CLI does not offer valid values. If it would, it
would fail if the option value is wrong. I would do so too.
2. You blindly `return` from `always`,
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/114
They are several issues. People are used to
[GNU](https://www.gnu.org/software/grep/manual/grep.html#General-Output-Control)
and [BSD](https://www.freebsd.org/cgi/man.cgi?query=grep=opensearch)
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/114
I will comment shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user mryan43 opened a pull request:
https://github.com/apache/maven/pull/114
MNG-6220 add color CLI option
https://issues.apache.org/jira/browse/MNG-6220
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mryan43/maven master
Dear community,
It would be great if we could update the versions of archetype-samples
to be servlet 3.1 and JDK 8. Do you agree?
I can make a patch of that.
Kind regards,
Vitalij
-
To unsubscribe, e-mail:
