Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.0.0

2018-01-06 Thread Hervé BOUTEMY
+1 Regards, Hervé Le jeudi 4 janvier 2018, 11:27:02 CET Robert Scholte a écrit : > Hi, > > We solved 13 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&ve > rsion=12334384&styleName=Text > > There are still a couple of issues left in JIRA: > https://issues.a

[GitHub] maven issue #151: [MNG-5968] Default plugin version updates

2018-01-06 Thread hboutemy
Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/151 other topics: - MNG-5968 is closed - MNG-5968 is not about default plugins versions, but about Maven core build if you rework this PR to focus on MNG-5992, ie providing a more secure

[GitHub] maven issue #151: [MNG-5968] Default plugin version updates

2018-01-06 Thread hboutemy
Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/151 I'm not a fan of default plugins updates in core: - depending on default versions is a bad practice, we expect users to explicitely choose their version through pluginManagement (and we display a

[GitHub] maven issue #151: [MNG-5968] Default plugin version updates

2018-01-06 Thread slachiewicz
Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/151 I found this changes in abdoned 3.4 line. Should also fix MNG-5992 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.o

[GitHub] maven pull request #151: [MNG-5968] Default plugin version updates

2018-01-06 Thread slachiewicz
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/151 [MNG-5968] Default plugin version updates o Updated default plugin versions to latest release version to bring in the latest fixes (and issues to report). o Updated to correct the 'ear' packa

Re: Questions regarding improving the Apache Commons release process.

2018-01-06 Thread Rob Tompkins
I’ve found some success now using org.apache.maven.plugin-testing:maven-plugin-testing-harness:3.3.0. You may disregard the following questions. Cheers, -Rob > On Jan 6, 2018, at 2:03 PM, Rob Tompkins wrote: > > Hello again Maven Team, > > I’ve made substantive progress towards getting the c

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.0.0

2018-01-06 Thread Tibor Digana
+1 On Thu, Jan 4, 2018 at 11:27 AM, Robert Scholte wrote: > Hi, > > We solved 13 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje > ctId=12317223&version=12334384&styleName=Text > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/issues/?jq

[GitHub] maven pull request #150: [ MNG-6335] Update Mockito to 2.12.0

2018-01-06 Thread slachiewicz
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/150 [ MNG-6335] Update Mockito to 2.12.0 Also change scope to test You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven feature/mocki

[GitHub] maven issue #149: Upgrade maven-checkstyle-plugin to 3.0.0 (Checkstyle 6.18)...

2018-01-06 Thread slachiewicz
Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/149 Please verify after planned plugin release --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional comman

[GitHub] maven pull request #149: Upgrade maven-checkstyle-plugin to 3.0.0 (Checkstyl...

2018-01-06 Thread slachiewicz
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/149 Upgrade maven-checkstyle-plugin to 3.0.0 (Checkstyle 6.18) and fix errors You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.0.0

2018-01-06 Thread Sylwester Lachiewicz
+1 (non binding) Tested to build latest Maven snapshot and checkstyle project. Sylwester czw., 4 sty 2018 o 11:27 użytkownik Robert Scholte napisał: > Hi, > > We solved 13 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&version=12334384&styleName=Text > >

Re: Maven - Plugin / Shared Components etc.

2018-01-06 Thread Hervé BOUTEMY
there is an Apache Sonar server [1] with a quite outdated documentation [2] but I didn't dig too much into details (and didn't put this as a prerequisite to Git migration, even if I'm eager to see how we'll be able to analyze our 100+ components) Regards, Hervé [1] https://builds.apache.org/a

Re: Maven - Plugin / Shared Components etc.

2018-01-06 Thread Robert Scholte
That should be https://analysis.apache.org/ but seems slow/unreachable at the moment... On Sat, 06 Jan 2018 21:36:53 +0100, Karl Heinz Marbaise wrote: Hi sorry was too fast to press the button... So the question is: Do we have some kind of support for SonarQube for the whole code? Do

Re: Maven - Plugin / Shared Components etc.

2018-01-06 Thread Karl Heinz Marbaise
Hi sorry was too fast to press the button... So the question is: Do we have some kind of support for SonarQube for the whole code? Do we like to have some sort of that? Some ideas? Does someone know if there is something related from INFRA (If i correctly remember there is no support anymo

Maven - Plugin / Shared Components etc.

2018-01-06 Thread Karl Heinz Marbaise
Hi, I would like to know if we have some SonarQube analysis somewhere running for all the plugins / shared components etc. I have found some of the projects on SonarCloud.io for example maven-enforcer[1] which is outdated.. [1]: https://sonarcloud.io/dashboard?id=org.apache.maven.enforc

Re: Maven 3.5.3 - MNG-6096 - Deprecate DefaultArtifactVersion class

2018-01-06 Thread Robert Scholte
Hi Karl Heinz, what would be the alternative? IMHO we can only deprecate if we can point people to the preferred way. Just adding an @Deprecated will confuse me, knowing this class is probably used a lot. thanks, Robert On Sat, 06 Jan 2018 21:24:02 +0100, Karl Heinz Marbaise wrote: Hi

Maven 3.5.3 - MNG-6096 - Deprecate DefaultArtifactVersion class

2018-01-06 Thread Karl Heinz Marbaise
Hi, are there any objections against MNG-6096[1] to put that on schedule for Maven 3.5.3 ? Kind regards Karl Heinz Marbaise [1]: https://issues.apache.org/jira/browse/MNG-6096 - To unsubscribe, e-mail: dev-unsubscr...@m

Re: Maven 3.5.3 - MNG-6298

2018-01-06 Thread Arnaud Héritier
LGTM +1 On Sat, Jan 6, 2018 at 9:00 PM, Karl Heinz Marbaise wrote: > Hi, > > I would like to know if someone can second this issue[1]. > > CI Build is fine[2]. > > Commit to Core[3]..and the commit to the integration tests can be found > here[4] > > > Kind regards > Karl Heinz Marbaise > > [1]

Re: Maven 3.5.3 - MNG-6298

2018-01-06 Thread Robert Scholte
Hi Karl Heinz, it looks like test IT is not added to the IntegrationTestSuite. And I would like to have the folder ( mng-6298 ) being extended with a short description. Fix looks good. thanks, Robert On Sat, 06 Jan 2018 21:00:30 +0100, Karl Heinz Marbaise wrote: Hi, I would like to

Re: Questions regarding improving the Apache Commons release process.

2018-01-06 Thread Robert Scholte
Hi Rob, at the moment I'm busy upgrading the maven-release-plugin to Maven3 (i.e. dropping Maven2 support) That meant rewriting quite some unittests and upgrading the maven-plugin-testing-harness (current one is really old). In some cases the maven-plugin-testing-harness is hard to use, so

Maven 3.5.3 - MNG-6298

2018-01-06 Thread Karl Heinz Marbaise
Hi, I would like to know if someone can second this issue[1]. CI Build is fine[2]. Commit to Core[3]..and the commit to the integration tests can be found here[4] Kind regards Karl Heinz Marbaise [1]: https://issues.apache.org/jira/browse/MNG-6298 [2]: https://builds.apache.org/view/M-R/v

Re: Questions regarding improving the Apache Commons release process.

2018-01-06 Thread Rob Tompkins
Hello again Maven Team, I’ve made substantive progress towards getting the commons team a release plugin (https://github.com/chtompki/commons-release-plugin ). However, in my attempt at writing plugin unit tests for the first time, I’ve found

Re: [maven-plugin-tools] 01/02: [MPLUGIN-331] Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()

2018-01-06 Thread Hervé BOUTEMY
in fact, this update is done for situation where the report documents plugins not created with Maven Plugin Tools: perhaps the other build tool may change the location of generated plugins.xml IMHO, this has to be discussed with the issue reporter: I don't know if the parameter is only a way to

Re: Maven 3.5.3 - MNG-6331/6332

2018-01-06 Thread Arnaud Héritier
+1 for them On Sat, Jan 6, 2018 at 5:43 PM, Karl Heinz Marbaise wrote: > Hi, > > anyone to second this? > > Kind regards > Karl Heinz Marbaise > > On 31/12/17 14:06, Karl Heinz Marbaise wrote: > >> Hi, >> >> I would like to integrate the following issues into Maven 3.5.3 (master): >> >> o MNG-

Re: Maven 3.5.3 - MNG-6331/6332

2018-01-06 Thread Karl Heinz Marbaise
Hi, anyone to second this? Kind regards Karl Heinz Marbaise On 31/12/17 14:06, Karl Heinz Marbaise wrote: Hi, I would like to integrate the following issues into Maven 3.5.3 (master):  o MNG-6332[1][2][3]  o MNG-6331[4][5][6] any objections? Kind regards Karl Heinz Marbaise [1]: https:

Re: [maven-plugin-tools] 01/02: [MPLUGIN-331] Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()

2018-01-06 Thread Robert Scholte
I would like to see this as a readOnly parameter. Changing it value will break things. On Sat, 06 Jan 2018 01:50:51 +0100, wrote: +@Parameter( defaultValue = "${project.build.outputDirectory}/META-INF/maven/plugin.xml", required = true ) +private File pluginXmlFile; ---