Re: Welcome Christian Stein to the Apache Maven Team

2018-05-07 Thread Christian Stein
On Mon, May 7, 2018 at 11:48 PM Tibor Digana wrote: > Welcome! > I hope Christian is online. > No, wasn't online when you wrote the mail. > We are working on JUnit5 provider in Surefire together and I see we have > quite a good progress step by step. So I think we will produce a new > version

Re: Welcome Christian Stein to the Apache Maven Team

2018-05-07 Thread Karl Heinz Marbaise
Hello Christian, welcome... Kind regards Karl Heinz Marbaise On 07/05/18 22:01, Robert Scholte wrote: Hi, On behalf of the Apache Maven PMC I am pleased to announce that Christian Stein (sor) has been voted in as a new Apache Maven committer. Christian, welcome on board and have a lot of f

Re: Welcome Christian Stein to the Apache Maven Team

2018-05-07 Thread Christian Stein
Thank you very much for the warm welcome, everybody. As Tibor said, my first plan is getting the code donation from JUnit to Maven Surefire finally finished [1]. Then, there're some open ends which need some care and improvements [2]. And when the testing dust settles down, I'd like to get modular

Re: Second MNG-6403

2018-05-07 Thread Michael Osipov
Am 2018-05-07 um 23:35 schrieb Robert Scholte: On Sun, 06 May 2018 21:32:18 +0200, Karl Heinz Marbaise wrote: Hi Michael, two things are coming into my mind: I stumbled over one thing which is: Why do we have the tests in maven-compat and not in maven-artifact ? Shouldn't they be in maven

Re: Welcome Christian Stein to the Apache Maven Team

2018-05-07 Thread Tibor Digana
Welcome! I hope Christian is online. We are working on JUnit5 provider in Surefire together and I see we have quite a good progress step by step. So I think we will produce a new version 2.22.0. On Mon, May 7, 2018 at 10:01 PM, Robert Scholte wrote: > Hi, > > On behalf of the Apache Maven PMC I

Re: Second MNG-5756

2018-05-07 Thread Michael Osipov
Am 2018-05-07 um 23:27 schrieb Robert Scholte: On Mon, 07 May 2018 23:14:18 +0200, Michael Osipov wrote: Am 2018-05-07 um 22:40 schrieb Robert Scholte: That's indeed better. Maybe a comment that when Maven requires Java9 it could be reverted to "Java Home"? Maybe, but still remains not te

Re: Second MNG-6403

2018-05-07 Thread Robert Scholte
On Sun, 06 May 2018 21:32:18 +0200, Karl Heinz Marbaise wrote: Hi Michael, two things are coming into my mind: I stumbled over one thing which is: Why do we have the tests in maven-compat and not in maven-artifact ? Shouldn't they be in maven-artifact instead of maven-compat ? +1

Re: Second MNG-5756

2018-05-07 Thread Michael Osipov
Am 2018-05-07 um 22:40 schrieb Robert Scholte: That's indeed better. Maybe a comment that when Maven requires Java9 it could be reverted to "Java Home"? Maybe, but still remains not technically Java, but the bundled JRE as Oracle documents and can be confused with JAVA_HOME. What about this

Re: Welcome Christian Stein to the Apache Maven Team

2018-05-07 Thread Olivier Lamy
Welcome! On Tue, 8 May 2018 at 08:01, Robert Scholte wrote: > Hi, > > On behalf of the Apache Maven PMC I am pleased to announce that Christian > Stein (sor) has been voted in as a new Apache Maven committer. > > Christian, welcome on board and have a lot of fun! > > thanks, > Robert > > ---

Re: Welcome Christian Stein to the Apache Maven Team

2018-05-07 Thread Martin Gainty
Willkommen Christian! martin __ From: Robert Scholte Sent: Monday, May 7, 2018 4:01 PM To: dev@maven.apache.org; Apache Maven Users Subject: Welcome Christian Stein to the Apache Maven Team Hi, On behalf of the Apac

Re: Second MNG-5756

2018-05-07 Thread Robert Scholte
That's indeed better. Maybe a comment that when Maven requires Java9 it could be reverted to "Java Home"? Robert On Mon, 07 May 2018 22:30:51 +0200, Michael Osipov wrote: Am 2018-05-07 um 21:46 schrieb Robert Scholte: I understand the fix, but it'll be no issue anymore with Java 9+ I

Re: Second MNG-5756

2018-05-07 Thread Michael Osipov
Am 2018-05-07 um 21:46 schrieb Robert Scholte: I understand the fix, but it'll be no issue anymore with Java 9+ I have my doubts about "used"? "JRE used" could also refer to a version. This is actually the JRE *location*, but that's quite long "JRE Home"? Or just do a Java check and only adjust

Welcome Christian Stein to the Apache Maven Team

2018-05-07 Thread Robert Scholte
Hi, On behalf of the Apache Maven PMC I am pleased to announce that Christian Stein (sor) has been voted in as a new Apache Maven committer. Christian, welcome on board and have a lot of fun! thanks, Robert - To unsubscribe

Re: ASM library not compatible with plexus-java:0.9.3 in Maven build

2018-05-07 Thread Robert Scholte
Seems all is fine now (and it actually wasn't a bug :) ) Robert On Sun, 06 May 2018 13:13:33 +0200, Tibor Digana wrote: We have a problem [1] with old version of plexus-java:0.9.3 and ASM library. We should use plexus-java:0.9.7 which is dependent on ASM 6.1.1. This would fix our problem

Re: Second MNG-5756

2018-05-07 Thread Robert Scholte
I understand the fix, but it'll be no issue anymore with Java 9+ I have my doubts about "used"? "JRE used" could also refer to a version. This is actually the JRE *location*, but that's quite long "JRE Home"? Or just do a Java check and only adjust it for Java 8 and before. In the end it really i

Re: Second MNG-6386

2018-05-07 Thread Robert Scholte
+1 Robert On Sat, 05 May 2018 13:46:45 +0200, Michael Osipov wrote: Am 2018-05-05 um 13:23 schrieb Stephen Connolly: On Sat 5 May 2018 at 09:13, Michael Osipov wrote: Am 2018-05-05 um 09:15 schrieb Stephen Connolly: On Thu 3 May 2018 at 22:10, Michael Osipov wrote: Am 2018-05-02

Re: ASM library not compatible with plexus-java:0.9.3 in Maven build

2018-05-07 Thread Christian Stein
Thanks a lot. Karl Heinz Marbaise schrieb am Mo., 7. Mai 2018, 17:52: > Hi, > > Release plexus-java 0.9.8... > > now available via Maven Central.. > > Kind regards > Karl Heinz Marbaise > On 07/05/18 10:39, Karl Heinz Marbaise wrote: > > Hi, > > > > On 07/05/18 10:23, Christian Stein wrote: > >>

Re: ASM library not compatible with plexus-java:0.9.3 in Maven build

2018-05-07 Thread Karl Heinz Marbaise
Hi, Release plexus-java 0.9.8... now available via Maven Central.. Kind regards Karl Heinz Marbaise On 07/05/18 10:39, Karl Heinz Marbaise wrote: Hi, On 07/05/18 10:23, Christian Stein wrote: Nit: plexus-java:0.9.7 refers to ASM 6.1 which was superseded by ASM 6.1.1 So, an upgrade to ASM 6

Re: Second MNG-5756

2018-05-07 Thread Stephen Connolly
+1 On Sat 5 May 2018 at 23:11, Michael Osipov wrote: > Hi folks, > > who seconds MNG-5756 for 3.5.4? Several folks complain that "mvn -v" > does not correspond to the reality, therefore two PRs have been created. > I have just changed the output to "JRE used:" instead of "Java home:". > > Michae

Re: ASM library not compatible with plexus-java:0.9.3 in Maven build

2018-05-07 Thread Tibor Digana
@Karl, thx that you will release new plexus-java:0.9.8. @Christian, yesterday I came late, but I concentrated on permanent issue on Windows Jenkins nodes. The issues is that java compiles won't compile and I guess it is again because on windows paths. The problem appears only on windows-2012-3. I

Re: ASM library not compatible with plexus-java:0.9.3 in Maven build

2018-05-07 Thread Tibor Digana
@Karl, thx that you will release new plexus-java:0.9.8. @Christian, yesterday I came late, but I concentrated on permanent issue on Windows Jenkins nodes. The issues is that java compiles won't compile and I guess it is again because on windows paths. The problem appears only on windows-2012-3. I a

Re: ASM library not compatible with plexus-java:0.9.3 in Maven build

2018-05-07 Thread Karl Heinz Marbaise
Hi, On 07/05/18 10:23, Christian Stein wrote: Nit: plexus-java:0.9.7 refers to ASM 6.1 which was superseded by ASM 6.1.1 So, an upgrade to ASM 6.1.1 in plexus-java:0.9.8 would be great as that version [1] fixed two bugs in ClassReader. [1] http://asm.ow2.io/versions.html Created issue[1] fo

Re: ASM library not compatible with plexus-java:0.9.3 in Maven build

2018-05-07 Thread Christian Stein
Nit: plexus-java:0.9.7 refers to ASM 6.1 which was superseded by ASM 6.1.1 So, an upgrade to ASM 6.1.1 in plexus-java:0.9.8 would be great as that version [1] fixed two bugs in ClassReader. [1] http://asm.ow2.io/versions.html