Re: [VOTE] Release Apache Maven Dependency Plugin version 3.1.2

2020-03-07 Thread Tibor Digana
+1, the build and sha512 ok On Sat, Mar 7, 2020 at 12:56 PM Karl Heinz Marbaise wrote: > We solved 23 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317227=12343772 > > There are still a couple of issues left in JIRA: > >

Re: Maven version support

2020-03-07 Thread Tibor Digana
It is always a big investment, especially when migrated from Maven 2 to Maven 3.0 API. For me it make sense to make minimum viable migration steps, and therefore migrate the plugins with major versions only. In this case it would be a migration with Java version 8.0 and Maven API 4.0 or 5.0. On

Re: [DISCUSS] checking reproducible builds

2020-03-07 Thread Elliotte Rusty Harold
On Sat, Mar 7, 2020 at 11:39 AM Michael Osipov wrote: > > As note, reproducibility after some time is not always possible if > nessary compilers/tools aren't available anymore -- as you can see. > That's an important point. Some organizations archive their entire build chain including compilers

Re: [DISCUSS] checking reproducible builds

2020-03-07 Thread Michael Osipov
Diff on OpenJDK 11: ├── META-INF/MANIFEST.MF │ @@ -1,10 +1,10 @@ │ Manifest-Version: 1.0 │ +Implementation-Vendor: The Apache Software Foundation^M │ +Implementation-Title: Apache Maven Site Plugin^M │ +Implementation-Version: 3.9.0^M │ +Build-Jdk-Spec: 1.7^M │ +Specification-Vendor: The Apache

Re: [DISCUSS] checking reproducible builds

2020-03-07 Thread Michael Osipov
Am 2020-03-07 um 19:04 schrieb Hervé BOUTEMY: Le samedi 7 mars 2020, 17:39:20 CET Michael Osipov a écrit : This is expected because I am on 1.8.0_242. I don't have Java 7 installed anymore on the server. for the discussion I wanted us to have, just being able to test and see how we detect

Re: [VOTE] Release Apache Maven Dependency Plugin version 3.1.2

2020-03-07 Thread Elliotte Rusty Harold
I have four open PRs on the maven-dependency-plugin if anyone cares to review: https://github.com/apache/maven-dependency-plugin/pull/34 https://github.com/apache/maven-dependency-plugin/pull/35 https://github.com/apache/maven-dependency-plugin/pull/36

Re: [VOTE] Release Apache Maven Site Plugin version 3.9.0

2020-03-07 Thread Tibor Digana
+1, build passes successfully and SHA512 ok On Sat, Mar 7, 2020 at 4:01 AM Hervé BOUTEMY wrote: > Hi, > > We solved 5 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317923=12345725=Text > > Staging repo: >

Re: [VOTE] Release Apache Maven Dependency Plugin version 3.1.2

2020-03-07 Thread Hervé BOUTEMY
+1 FYI, I was able to reproduce and check on my Linux box with JDK 8, using followin command: $ mvn -Prun-its,apache-release clean verify buildinfo:save -Dgpg.skip -Dreference.repo=https://repository.apache.org/content/repositories/maven-1555/ [...] [INFO] Reproducible Build output summary: 3

Re: [VOTE] Release Apache Maven Dependency Plugin version 3.1.2

2020-03-07 Thread Eric Lilja
It would be very nice to release maven-artifact-transfer first (both 0.12.1 and 0.13.0 look ready in Jira, with one and two issues closed respectively, so I would go for 0.13.0 to get all ready fixes out), and integrate into this release. Please consider doing that! - Eric L On Sat, Mar 7, 2020

Re: [DISCUSS] checking reproducible builds

2020-03-07 Thread Hervé BOUTEMY
Le samedi 7 mars 2020, 17:39:20 CET Michael Osipov a écrit : > This is expected because I am on 1.8.0_242. I don't have Java 7 > installed anymore on the server. for the discussion I wanted us to have, just being able to test and see how we detect issues, this is perfect, isn't it? how did you

MavenProject - replacement for deprecated method

2020-03-07 Thread Slawomir Jaranowski
Hi, In my plugin I need list of report plugins, I use method: org.apache.maven.project.MavenProject#getReportArtifacts but this method (and many other) is deprecated in class MavenProject - maven-core version 3.5.0 What method / class / library I should use instead of this. In source code

Re: [DISCUSS] checking reproducible builds

2020-03-07 Thread Michael Osipov
Am 2020-03-07 um 11:36 schrieb Hervé BOUTEMY: Hi, Yesterday, I made a key step forward for Reproducible Builds with Maven: I wrote code to easily check that your local build produces the same binaries as the reference binaries published either to staging or to Central repository. For a live

Re: [VOTE] Release Apache Maven Site Plugin version 3.9.0

2020-03-07 Thread Hervé BOUTEMY
Le samedi 7 mars 2020, 13:05:47 CET Karl Heinz Marbaise a écrit : > Hi, > > +1 from me. > > > I've tried to check reproducibility of the build but got a number of > JavaDoc errors (JDK8 1.8.0.232 MacOS) which failed the checking... yes, that's why I did this release using JDK 7 > That > means

Re: [DISCUSS] checking reproducible builds

2020-03-07 Thread Hervé BOUTEMY
thank you for testing little bug fixed: stupid me, I should have tested this case before asking for feedback: I tested only with central repository, provided as "central" id... please fetch the latest plugin update and retest :) Le samedi 7 mars 2020, 13:12:08 CET Karl Heinz Marbaise a écrit :

Re: [DISCUSS] checking reproducible builds

2020-03-07 Thread Karl Heinz Marbaise
Hi, On 07.03.20 14:19, Michael Osipov wrote: Am 2020-03-07 um 11:36 schrieb Hervé BOUTEMY: Hi, Yesterday, I made a key step forward for Reproducible Builds with Maven: I wrote code to easily check that your local build produces the same binaries as the reference binaries published either to

Re: [DISCUSS] checking reproducible builds

2020-03-07 Thread Michael Osipov
Am 2020-03-07 um 11:36 schrieb Hervé BOUTEMY: Hi, Yesterday, I made a key step forward for Reproducible Builds with Maven: I wrote code to easily check that your local build produces the same binaries as the reference binaries published either to staging or to Central repository. For a live

Re: [DISCUSS] checking reproducible builds

2020-03-07 Thread Michael Osipov
Am 2020-03-07 um 13:45 schrieb Michael Osipov: Am 2020-03-07 um 11:36 schrieb Hervé BOUTEMY: Hi, Yesterday, I made a key step forward for Reproducible Builds with Maven: I wrote code to easily check that your local build produces the same binaries as the reference binaries published either

Re: [DISCUSS] checking reproducible builds

2020-03-07 Thread Michael Osipov
Am 2020-03-07 um 11:36 schrieb Hervé BOUTEMY: Hi, Yesterday, I made a key step forward for Reproducible Builds with Maven: I wrote code to easily check that your local build produces the same binaries as the reference binaries published either to staging or to Central repository. For a live

Re: [DISCUSS] checking reproducible builds

2020-03-07 Thread Michael Osipov
Am 2020-03-07 um 13:12 schrieb Karl Heinz Marbaise: Hi Hervé, I've tried to check my release via the suggested recipe... Downloaded the maven-studies repo and build the following commit: 90b426758363123af6fcc9aa7190b837c0551359 (mvn clean install) Downloaded the source package curl -O

Re: [DISCUSS] checking reproducible builds

2020-03-07 Thread Karl Heinz Marbaise
Hi Hervé, I've tried to check my release via the suggested recipe... Downloaded the maven-studies repo and build the following commit: 90b426758363123af6fcc9aa7190b837c0551359 (mvn clean install) Downloaded the source package curl -O

Re: [VOTE] Release Apache Maven Site Plugin version 3.9.0

2020-03-07 Thread Karl Heinz Marbaise
Hi, +1 from me. I've tried to check reproducibility of the build but got a number of JavaDoc errors (JDK8 1.8.0.232 MacOS) which failed the checking...That means that the javadoc issues should be fixed for the next release... Kind regards Karl Heinz Marbaise On 06.03.20 22:03, Hervé

[VOTE] Release Apache Maven Dependency Plugin version 3.1.2

2020-03-07 Thread Karl Heinz Marbaise
We solved 23 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317227=12343772 There are still a couple of issues left in JIRA:

[DISCUSS] checking reproducible builds

2020-03-07 Thread Hervé BOUTEMY
Hi, Yesterday, I made a key step forward for Reproducible Builds with Maven: I wrote code to easily check that your local build produces the same binaries as the reference binaries published either to staging or to Central repository. For a live example, see the last paragraph of Maven Site

Re: [VOTE] Release Apache Maven Site Plugin version 3.9.0

2020-03-07 Thread Michael Osipov
Am 2020-03-06 um 22:03 schrieb Hervé BOUTEMY: Hi, We solved 5 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317923=12345725=Text Staging repo: https://repository.apache.org/content/repositories/maven-1554/