[GitHub] [maven-site] elharo commented on pull request #184: On branch edburns-cognitive-tax-nit-01 Don't make me think: use graph…

2020-07-25 Thread GitBox
elharo commented on pull request #184: URL: https://github.com/apache/maven-site/pull/184#issuecomment-663912026 You'd have to ask the PMC about that. Some folks object to squash and merge. Not my call. This is an

[GitHub] [maven-site] mkarg edited a comment on pull request #184: On branch edburns-cognitive-tax-nit-01 Don't make me think: use graph…

2020-07-25 Thread GitBox
mkarg edited a comment on pull request #184: URL: https://github.com/apache/maven-site/pull/184#issuecomment-663911012 > You didn't take that screenshot in this repo. It doesn't allow squash commits. I don't know why. I am pretty sure there is a PMC that could simply instruct their

[GitHub] [maven-site] mkarg commented on pull request #184: On branch edburns-cognitive-tax-nit-01 Don't make me think: use graph…

2020-07-25 Thread GitBox
mkarg commented on pull request #184: URL: https://github.com/apache/maven-site/pull/184#issuecomment-663911012 > You didn't take that screenshot in this repo. It doesn't allow squash commits. I don't know why. I am pretty sure there is a PMC that could simply instruct their

[GitHub] [maven-site] elharo commented on pull request #184: On branch edburns-cognitive-tax-nit-01 Don't make me think: use graph…

2020-07-25 Thread GitBox
elharo commented on pull request #184: URL: https://github.com/apache/maven-site/pull/184#issuecomment-663910007 You didn't take that screenshot in this repo. It doesn't allow squash commits. I don't know why. This is an

[GitHub] [maven-site] mkarg commented on pull request #184: On branch edburns-cognitive-tax-nit-01 Don't make me think: use graph…

2020-07-25 Thread GitBox
mkarg commented on pull request #184: URL: https://github.com/apache/maven-site/pull/184#issuecomment-663903450 > Can you squash this into a single commit? Thanks. Why should he invest time into doing that? Any committer can simply click on that green arrow button to do that *on the

Re: Absolute location of settings files help

2020-07-25 Thread Falko Modler
Inject the MavenSession: @Parameter(defaultValue ="${session}", readonly = true) private MavenSession mavenSession; and then: mavenSession.getRequest() -> getUserSettingsFile() or getGlobalSettingsFile() Cheers, Falko Am 23.07.2020 um 13:42 schrieb John Patrick: From within a plugin,

Re: Second MNG-6964 and MNG-6967

2020-07-25 Thread Robert Scholte
LGTM On 24-7-2020 08:47:47, Dennis Lundberg wrote: Hi, First up, I'm sorry. I made a commit to maven core on gitbox without requesting a review first. Thanks to Sylwester for pointing that out. So here comes a belated request for review. MNG-6964 describes an edge case where rather unusual

maven-script-interpreter next version - please help

2020-07-25 Thread Slawomir Jaranowski
Hi, I made changes to maven-script-interpreter which will resolve some issues in invoker plugin. Last my changes brake compatibility, so next version should be: *2.0* according to semVer Here is a list of change: https://issues.apache.org/jira/projects/MSHARED/versions/12341132 And the last PR