Re: Maven Assembly / Common Artifact Filters issues and defect

2021-11-16 Thread Václav Haisman
On 16. 11. 21 17:36, Slawomir Jaranowski wrote: > Hi, > Thanks for reporting. > > Does your issue is similar to [1] - If yes please comment, vote > or if it is something else you can create a new issue. I have created a new issue. In my case, Assembly plugin 2.5.5 works and 3.0.0+ breaks. New iss

Re: Maven Assembly / Common Artifact Filters issues and defect

2021-11-16 Thread Slawomir Jaranowski
Hi, Thanks for reporting. Does your issue is similar to [1] - If yes please comment, vote or if it is something else you can create a new issue. [1] https://issues.apache.org/jira/browse/MASSEMBLY-607 wt., 16 lis 2021 o 14:51 Václav Haisman napisał(a): > Hi. > > I think I found a defect in th

[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-16 Thread GitBox
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970426760 From wrapper perspective should not be important what `mvn` command is and what happen inside `mvn`. We should assume that `mvn` command from Maven distri

[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-16 Thread GitBox
rfscholte commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970356340 The only potential problem I see is that a script calls another script that calls java. Should be easy to validate. -- This is an automated message from the Apache G

[GitHub] [maven-wrapper-plugin] jvanzyl edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-16 Thread GitBox
jvanzyl edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970336499 Historically the Maven Wrapper has been separate, and I believe works well that way. Its concern to bring Maven into existence for build, and I would argue that s

[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-16 Thread GitBox
jvanzyl commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970336499 Historically the Maven Wrapper has been separate, and I believe works well that way. Its concern to bring Maven into existence for build, and I would argue that should b

[GitHub] [maven-wrapper-plugin] jvanzyl edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-16 Thread GitBox
jvanzyl edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970322319 > Another idea ... why not simply call `mvn*` scripts from Maven distribution ... of course after needed job for wrapper like downloading > > In this case c

[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-16 Thread GitBox
jvanzyl commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970322319 > Another idea ... why not simply call `mvn*` scripts from Maven distribution ... of course after needed job for wrapper like downloading > > In this case code wil

Maven Assembly / Common Artifact Filters issues and defect

2021-11-16 Thread Václav Haisman
Hi. I think I found a defect in the latest currently available Maven Assembly plugin version 3.3.0. The Assembly plugin uses Common Artifact Filters's class `PatternIncludesArtifactFilter`. This class, in its method `matchAgainst()` loops over include patterns. If one of the include patterns conta

Re: [VOTE] Release Apache Maven version 3.8.4

2021-11-16 Thread Guillaume Nodet
+1 Le dim. 14 nov. 2021 à 14:28, Michael Osipov a écrit : > Hi, > > We solved 5 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12350685 > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/?jql=project%20%3D

JDK 18 Early-Access builds 23 are available

2021-11-16 Thread david . delabassee
Robert, I’m happy to announce that moving forward Oracle’s Java DevRel Team will manage the Quality Outreach Program. I would like to thank Rory for all the efforts he's put into this program and wish him all the joy and happiness that retirement can bring! We have big shoes to fill but we’re