[GitHub] [maven-wrapper-plugin] rfscholte commented on a change in pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

rfscholte commented on a change in pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#discussion_r754017815 ## File path: maven-wrapper/src/main/java/org/apache/maven/wrapper/MavenWrapperMain.java ## @@ -0,0 +1,110 @@ +package

[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #5: [MWRAPPER-16] PoC call mvn(.cmd) script from mvnw(.cmd)

hboutemy commented on pull request #5: URL: https://github.com/apache/maven-wrapper-plugin/pull/5#issuecomment-975190407 ok, I deleted my local parent POMs and now I see the issue: just need to define newer plugin version than inherited issue fixed in MWRAPPER-14, MWRAPPER-16 rebased

[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #5: [MWRAPPER-16] PoC call mvn(.cmd) script from mvnw(.cmd)

slawekjaranowski commented on pull request #5: URL: https://github.com/apache/maven-wrapper-plugin/pull/5#issuecomment-974921184 Confirm on mac with m-assembly-p 3.3.0 it is ok ... maybe #4 can help to detect early such problems -- This is an automated message from the Apache Git

[GitHub] [maven-wrapper-plugin] cstamas edited a comment on pull request #5: [MWRAPPER-16] PoC call mvn(.cmd) script from mvnw(.cmd)

cstamas edited a comment on pull request #5: URL: https://github.com/apache/maven-wrapper-plugin/pull/5#issuecomment-974885783 ~~Sources tag (that we fail on) was added in this issue https://issues.apache.org/jira/browse/MASSEMBLY-934 present in 3.3.0 but not 3.2.0. Something is off re

[GitHub] [maven-wrapper-plugin] cstamas commented on pull request #5: [MWRAPPER-16] PoC call mvn(.cmd) script from mvnw(.cmd)

cstamas commented on pull request #5: URL: https://github.com/apache/maven-wrapper-plugin/pull/5#issuecomment-974885783 Sources tag (that we fail on) was added in this issue https://issues.apache.org/jira/browse/MASSEMBLY-934 present in 3.3.0 but not 3.2.0. Something is off re @hboutemy

[GitHub] [maven-wrapper-plugin] cstamas commented on pull request #5: [MWRAPPER-16] PoC call mvn(.cmd) script from mvnw(.cmd)

cstamas commented on pull request #5: URL: https://github.com/apache/maven-wrapper-plugin/pull/5#issuecomment-974885261 Just checked out and build: ``` [INFO] --- maven-assembly-plugin:3.2.0:single (default) @ maven-wrapper-distribution --- [INFO] Reading assembly descriptor:

[GitHub] [maven-wrapper-plugin] cstamas commented on pull request #5: [MWRAPPER-16] PoC call mvn(.cmd) script from mvnw(.cmd)

cstamas commented on pull request #5: URL: https://github.com/apache/maven-wrapper-plugin/pull/5#issuecomment-974884996 @hboutemy you somehow locally use 3.3.0 of m-assembly-p, but sources does NOT make that be used. Are you sure you have correct parent or committed all? -- This is an

[GitHub] [maven-wrapper-plugin] hboutemy commented on a change in pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

hboutemy commented on a change in pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#discussion_r753846928 ## File path: maven-wrapper/src/main/java/org/apache/maven/wrapper/MavenWrapperMain.java ## @@ -0,0 +1,110 @@ +package org.apache.maven.wrapper;

[GitHub] [maven-wrapper-plugin] cstamas commented on pull request #5: [MWRAPPER-16] PoC call mvn(.cmd) script from mvnw(.cmd)

cstamas commented on pull request #5: URL: https://github.com/apache/maven-wrapper-plugin/pull/5#issuecomment-974884340 Same here, same error (Linux) as for @jvanzyl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #5: [MWRAPPER-16] PoC call mvn(.cmd) script from mvnw(.cmd)

hboutemy commented on pull request #5: URL: https://github.com/apache/maven-wrapper-plugin/pull/5#issuecomment-974882805 uh, strange, I don't have any issue here on my Linux box when launching ` mvn clean install && mvn org.apache.maven.plugins:maven-wrapper-plugin:3.0.3-SNAPSHOT:wrapper

[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

hboutemy edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974664732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

jvanzyl commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974671779 @rfscholte are you fine with a first step of dynamically importing the scripts and implementing the more sophisticated https://issues.apache.org/jira/browse/MWRAPPER-16

[GitHub] [maven-site] michael-o merged pull request #274: Add release notes for Maven 3.8.4

michael-o merged pull request #274: URL: https://github.com/apache/maven-site/pull/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974609919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

rfscholte commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974648100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #5: [MWRAPPER-16] PoC call mvn(.cmd) script from mvnw(.cmd)

jvanzyl commented on pull request #5: URL: https://github.com/apache/maven-wrapper-plugin/pull/5#issuecomment-974858103 @hboutemy I tried to build it locally and have the following: ``` INFO] Reading assembly descriptor: src/assembly/script.xml [INFO]

[GitHub] [maven-wrapper-plugin] rfscholte commented on a change in pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

rfscholte commented on a change in pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#discussion_r753767354 ## File path: maven-wrapper-distribution/src/assembly/script/download ## @@ -0,0 +1,51 @@

[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #5: [MWRAPPER-16] PoC call mvn(.cmd) script from mvnw(.cmd)

jvanzyl commented on pull request #5: URL: https://github.com/apache/maven-wrapper-plugin/pull/5#issuecomment-974858103 @hboutemy I tried to build it locally and have the following: ``` INFO] Reading assembly descriptor: src/assembly/script.xml [INFO]

[GitHub] [maven-wrapper-plugin] rfscholte commented on a change in pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

rfscholte commented on a change in pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#discussion_r753829576 ## File path: maven-wrapper/src/main/java/org/apache/maven/wrapper/MavenWrapperMain.java ## @@ -0,0 +1,110 @@ +package

[GitHub] [maven-wrapper-plugin] rfscholte commented on a change in pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

rfscholte commented on a change in pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#discussion_r753767354 ## File path: maven-wrapper-distribution/src/assembly/script/download ## @@ -0,0 +1,51 @@

[VOTE] Release Maven Plugin Tools version 3.6.2

Hi, We solved 11 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820=12350123 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MPLUGIN%20AND%20resolution%20%3D%20Unresolved Staging repo:

Re: Request for Enhancement: Dependency Overrides

Hi, Delany, thanks for the feedback. I get your point that management and overrides can be seen as independent. To be honest, I'm really not picky about where in the POM overrides should be located. I was hoping for opinions on this from others (and was not disappointed) and at least one

Re: [VOTE] Release Maven Resolver Ant Tasks version 1.4.0

+1 On Sat, Nov 20, 2021, 21:32 Michael Osipov wrote: > Hi, > > We solved 13 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12350366 > > There are still a couple of issues left in JIRA: > >

Re: [VOTE] Release Maven Resolver Ant Tasks version 1.4.0

Am 2021-11-20 um 21:32 schrieb Michael Osipov: Hi, We solved 13 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12350366 There are still a couple of issues left in JIRA:

[GitHub] [maven-wrapper-plugin] rfscholte commented on a change in pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

rfscholte commented on a change in pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#discussion_r753767354 ## File path: maven-wrapper-distribution/src/assembly/script/download ## @@ -0,0 +1,51 @@