Re: Commit Review Policy

2022-01-25 Thread Benjamin Marwell
Hi! Aside from typo fixes, PRs might slow down the dev speed, but greatly improve code quality. Even small PRs might have side effects you might not notice at first glance. But then, even with typo fixes I have seen people introducing more fixes or unintentionally thought they would fix

Re: Commit Review Policy

2022-01-25 Thread Olivier Lamy
Hi, I'm happy with the current rule/process CTR and not sure we want to receive more notification emails... when someone creates a PR to fix a typo in some documentation/javadoc or some very easy changes. We have enough experience to create a PR when really necessary. On Wed, 26 Jan 2022 at

Commit Review Policy

2022-01-25 Thread Slawomir Jaranowski
Hi, On the page "Apache Maven Project Roles" [1] we have paragraph about Committers with: The Apache Maven project uses a Commit then Review policy and has a number of conventions which should be followed. Looks like Review then Commit policy is from svn time, so should be refreshed or