Re: [VOTE] Release Apache Maven 4.0.0-alpha-2

2022-10-20 Thread Romain Manni-Bucau
Hi, Agree it will be a surprise and it is actually a pretty big regression to not enable to override a configuration from a file with inline/env values. We should finish the impl to not copy twice the same options IMHO since we have the info or at least keep the overriding working as expected (com

Re: [VOTE] Release Apache Maven 4.0.0-alpha-2

2022-10-20 Thread Hervé Boutemy
there is no Jira issue associated? Le jeudi 20 octobre 2022, 18:15:28 CEST Guillaume Nodet a écrit : > This will be fixed by https://github.com/apache/maven/pull/836. > > Guillaume > > Le jeu. 20 oct. 2022 à 09:27, Delany a écrit : > > hi. I just changed .mvn/wrapper/maven-wrapper.properties to

Re: Re: [VOTE] Release Apache Maven 4.0.0-alpha-2

2022-10-20 Thread Olivier Lamy
fair enough. but this might be a (bad?) surprise for few people On Fri, 21 Oct 2022 at 01:25, Michael Osipov wrote: > > > On 2022/10/19 21:38:47 Olivier Lamy wrote: > > +1 > > > > I only have a small issue. > > I have this env var > > MAVEN_OPTS=-Djava.awt.headless=true -client -Xmx2048m -Xms

Re: [VOTE] Release Apache Maven EAR Plugin version 3.3.0

2022-10-20 Thread Hervé Boutemy
+1 Reproducible Build ok: reference done with JDK 8 on *nix Regards, Hervé Le mardi 18 octobre 2022, 19:38:21 CEST Slawomir Jaranowski a écrit : > Hi, > > We solved 18 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317422&ve > rsion=12349537 > > There are still a

Re: API changes - was [VOTE] Release Apache Maven 4.0.0-alpha-2

2022-10-20 Thread Mark Derricutt
On 21/10/2022 at 12:41:54 AM, Mark Derricutt wrote: > Merged and I’ll release in the morning - and run our main projects thru > with Maven 4.0.0 and see how it fares. > Doh - released the new tiles this morning ( should really have tested it again $work’s main project first tho) ): When runni

Re: [VOTE] Release Apache Maven 4.0.0-alpha-2

2022-10-20 Thread Guillaume Nodet
This will be fixed by https://github.com/apache/maven/pull/836. Guillaume Le jeu. 20 oct. 2022 à 09:27, Delany a écrit : > hi. I just changed .mvn/wrapper/maven-wrapper.properties to > distributionUrl= > > https://repository.apache.org/service/local/repositories/maven-1811/content/org/apache/ma

RE: Re: [VOTE] Release Apache Maven 4.0.0-alpha-2

2022-10-20 Thread Michael Osipov
On 2022/10/19 21:38:47 Olivier Lamy wrote: +1 I only have a small issue. I have this env var MAVEN_OPTS=-Djava.awt.headless=true -client -Xmx2048m -Xms2048m a project has .mvn/jvm.config with -Xmx1100m Maven 3.8.5 does this + exec /Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Ho

Re: API changes - was [VOTE] Release Apache Maven 4.0.0-alpha-2

2022-10-20 Thread Mark Derricutt
On 20/10/2022 at 11:49:48 PM, Tamás Cservenák wrote: > created PR that should restore compatibility, moreover, it remains mvn 3 > and 4 compatible > (and some little cosmetic change to plexus xml) > Oh sweet! Kudos. Just triggered the build jobs with IT tests and all passed. Merged and I’ll

Re: API changes - was [VOTE] Release Apache Maven 4.0.0-alpha-2

2022-10-20 Thread Tamás Cservenák
Howdy, created PR that should restore compatibility, moreover, it remains mvn 3 and 4 compatible (and some little cosmetic change to plexus xml) https://github.com/repaint-io/maven-tiles/pull/133 Thanks T On Thu, Oct 20, 2022 at 1:37 AM Mark Derricutt wrote: > Trying out the new 4.0.0-alpha-2

Re: Install / Deploy plugins at the end

2022-10-20 Thread Christofer Dutz
Hi all, In PLC4X’s build we wanted to use the deployAtEnd and were having issues (But this was a long time ago) We settled on overriding the remote repo location to a directory relative to the build: https://github.com/apache/plc4x/blob/develop/Jenkinsfile#L118 And then simply bulk deploy that

[VOTE] Release Maven Plugin Tools 3.7.0

2022-10-20 Thread Guillaume Nodet
Hi, We solved 18 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820&version=12344367 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/browse/?jql=project%20%3D%20MPLUGIN%20and%20resolution%20%3D%20Unresolved Staging repo: https://repo

Re: Install / Deploy plugins at the end

2022-10-20 Thread Tamás Cservenák
Howdy On Thu, Oct 20, 2022 at 9:21 AM Slawomir Jaranowski wrote: > You are right - issues should be closed - I will review it. > > Be careful, many reproducers are INCOMPLETE. For example, MINSTALL-102 attached test.zip is WRONG: it mixes m-install-p versions from pom packaging and maven-archety

Re: [VOTE] Release Apache Maven 4.0.0-alpha-2

2022-10-20 Thread Delany
hi. I just changed .mvn/wrapper/maven-wrapper.properties to distributionUrl= https://repository.apache.org/service/local/repositories/maven-1811/content/org/apache/maven/apache-maven/4.0.0-alpha-2/apache-maven-4.0.0-alpha-2-bin.zip The options now require an equals: --threads=1C, but the help page

Re: Install / Deploy plugins at the end

2022-10-20 Thread Tamás Cservenák
Howdy, an example solution, please verify it: https://github.com/apache/maven-install-plugin/pull/38 T On Thu, Oct 20, 2022 at 9:21 AM Slawomir Jaranowski wrote: > czw., 20 paź 2022 o 09:04 Tamás Cservenák > napisał(a): > > > Howdy, > > > > I cannot reproduce any of the issues you linked, mo

Re: Install / Deploy plugins at the end

2022-10-20 Thread Slawomir Jaranowski
czw., 20 paź 2022 o 09:04 Tamás Cservenák napisał(a): > Howdy, > > I cannot reproduce any of the issues you linked, moreover all the other > issues are IMHO non reproducible with m-install-p 3.0.1 and m-deploy-p > 3.0.0. > > You are right - issues should be closed - I will review it. > There is

Re: Install / Deploy plugins at the end

2022-10-20 Thread Tamás Cservenák
Howdy, I cannot reproduce any of the issues you linked, moreover all the other issues are IMHO non reproducible with m-install-p 3.0.1 and m-deploy-p 3.0.0. There is ONE issue that still stands, and it is the one you mention: when m-install-p/m-deploy-p is not part of a module build at all, but I