[GitHub] maven issue #114: MNG-6220 add color CLI option

2017-08-16 Thread agudian
Github user agudian commented on the issue: https://github.com/apache/maven/pull/114 @rfscholte: looks good! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] maven-surefire pull request: Adding individual rerun times to XML ...

2015-09-28 Thread agudian
Github user agudian commented on the pull request: https://github.com/apache/maven-surefire/pull/96#issuecomment-143957705 I agree that it makes sense to add the same information to the xml report that we provide in the console output. Regarding what time to take for the test case

[GitHub] maven pull request: Locate .mvn in current directory

2015-07-16 Thread agudian
Github user agudian commented on the pull request: https://github.com/apache/maven/pull/58#issuecomment-121962243 Hi, Thanks for the patch! Are the windows-scripts also affected by the bug and could use a fix? --- If your project is set up for it, you can reply to

[GitHub] maven pull request: [MNG-5812] Project base dir not fully working ...

2015-06-22 Thread agudian
Github user agudian commented on the pull request: https://github.com/apache/maven/pull/46#issuecomment-114251594 Works as it should, I'd say... :grinning: @tssp, I have rebased your commit, so this PR won't close automatically. Would you please close it?

[GitHub] maven pull request: [MNG-5812] Project base dir not fully working ...

2015-06-22 Thread agudian
Github user agudian commented on the pull request: https://github.com/apache/maven/pull/46#issuecomment-114223364 Sure, I'll take care of it. :wink: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

maven-surefire pull request: [SUREFIRE-946] prevent hanging main process if...

2013-02-14 Thread agudian
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/20 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-surefire pull request: [SUREFIRE-956] make forkNumber unique among co...

2013-02-14 Thread agudian
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/22 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-surefire pull request: [SUREFIRE-949] add forkCount parameter

2013-02-14 Thread agudian
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/21 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-surefire pull request: [SUREFIRE-956] make forkNumber unique among co...

2013-02-05 Thread agudian
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/22 [SUREFIRE-956] make forkNumber unique among concurrent surefire-executions in a parallel maven build This pull request builds upon some changes from https://github.com/apache/maven-surefire

maven-shared pull request: [SUREFIRE-946] Allow execution of a callback aft...

2013-01-21 Thread agudian
Github user agudian closed the pull request at: https://github.com/apache/maven-shared/pull/2 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-surefire pull request: [SUREFIRE-949] add forkCount parameter

2013-01-18 Thread agudian
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/21 [SUREFIRE-949] add forkCount parameter [SUREFIRE-949] add forkCount parameter, making the inconsitent forkMode parameter deprecated. - All defaulting works as in the previous

maven-surefire pull request: [SUREFIRE-946] prevent hanging main process if...

2013-01-13 Thread agudian
GitHub user agudian reopened a pull request: https://github.com/apache/maven-surefire/pull/20 [SUREFIRE-946] prevent hanging main process if forked process was killed... ... (softly) You can merge this pull request into a Git repository by running: $ git pull https

maven-surefire pull request: [SUREFIRE-946] prevent hanging main process if...

2013-01-13 Thread agudian
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/20 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-shared pull request: [SUREFIRE-946] Allow execution of a callback aft...

2013-01-11 Thread agudian
GitHub user agudian opened a pull request: https://github.com/apache/maven-shared/pull/2 [SUREFIRE-946] Allow execution of a callback after the process finished,... ... or the timeout ran up. The callback is invoked, before calling waitForPumpers, allowing clients to

maven-shared pull request: Make ShutdownHookUtils public

2013-01-07 Thread agudian
Github user agudian closed the pull request at: https://github.com/apache/maven-shared/pull/1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-shared pull request: Make ShutdownHookUtils public

2013-01-07 Thread agudian
GitHub user agudian opened a pull request: https://github.com/apache/maven-shared/pull/1 Make ShutdownHookUtils public It can be re-used in surefire to remove some code-duplication You can merge this pull request into a Git repository by running: $ git pull https://github.com

maven-surefire pull request: [SUREFIRE-946] prevent hanging main process if...

2013-01-05 Thread agudian
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/20 [SUREFIRE-946] prevent hanging main process if forked process was killed... ... (softly) You can merge this pull request into a Git repository by running: $ git pull https://github.com

maven-surefire pull request: Initial draft of a new "examples" page explain...

2013-01-04 Thread agudian
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/19 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-surefire pull request: Initial draft of a new "examples" page explain...

2013-01-03 Thread agudian
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/19 Initial draft of a new "examples" page explaining the fork and parallel options Needs some proof-reading... :) Did I miss something? Do you have suggestions for a better

maven-surefire pull request: [SUREFIRE-943] fix test name in XML report

2012-12-31 Thread agudian
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/18 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-surefire pull request: [SUREFIRE-943] fix test name in XML report

2012-12-29 Thread agudian
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/18 [SUREFIRE-943] fix test name in XML report Added an integration test for the issue and included a proposed fix. All other ITs still pass, but I have no clue if there might be other side

maven-surefire pull request: [SUREFIRE-933] repair parallel=classes

2012-12-16 Thread agudian
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/15 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-surefire pull request: [SUREFIRE-933] repair parallel=classes

2012-12-15 Thread agudian
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/15 [SUREFIRE-933] repair parallel=classes You can merge this pull request into a Git repository by running: $ git pull https://github.com/agudian/maven-surefire SUREFIRE-933

maven-surefire pull request: [SUREFIRE-934] remove getLocatedClasses() and ...

2012-12-10 Thread agudian
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/14 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-surefire pull request: [SUREFIRE-934] remove getLocatedClasses() and ...

2012-12-09 Thread agudian
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/14 [SUREFIRE-934] remove getLocatedClasses() and size() from TestsToRun .. to avoid potential programming errors with forkMode=onceperthread You can merge this pull request into a Git

maven-surefire pull request: [SUREFIRE-933] Fix forkMode onceperthread afte...

2012-12-09 Thread agudian
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/13 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-surefire pull request: [SUREFIRE-839] Tests not matching categories w...

2012-12-08 Thread agudian
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/13 [SUREFIRE-839] Tests not matching categories would fail build Fixed in a way that does not break forkMode=onceperthread (enhanced the IT for that). Tests are now filtered right before

maven-surefire pull request: [SUREFIRE-839] Tests not matching categories w...

2012-12-08 Thread agudian
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/12 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-surefire pull request: [SUREFIRE-839] Tests not matching categories w...

2012-12-08 Thread agudian
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/12 [SUREFIRE-839] Tests not matching categories would fail build Fixed in a way that does not break forkMode=onceperthread (enhanced the IT for that), refined the logic of

maven-surefire pull request: forkMode onceperthread (SUREFIRE-751) (licence...

2012-11-17 Thread agudian
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/10 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-surefire pull request: forkMode onceperthread (SUREFIRE-751)

2012-11-16 Thread agudian
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/8 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-surefire pull request: forkMode onceperthread (SUREFIRE-751) (licence...

2012-11-16 Thread agudian
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/10 forkMode onceperthread (SUREFIRE-751) (licence headers included) In relation to http://jira.codehaus.org/browse/SUREFIRE-751 Adds a new forkMode option "onceperthread&q

maven-surefire pull request: forkMode onceperthread (SUREFIRE-751)

2012-11-12 Thread agudian
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/8 forkMode onceperthread (SUREFIRE-751) In relation to http://jira.codehaus.org/browse/SUREFIRE-751 - Adds a new forkMode option "onceperthread", that creates one reusable fork