>correctly even if the encoding changes, because that will lead to the file
>being overwritten.
Once again: decoding does **not** guarantee you get **invalid** string when
decoding fails.
The replacement string might look like a regular string, and it might even
collide with the input string.
Le mar. 15 févr. 2022 à 08:19, Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> a écrit :
> >the result string will be corrupted when read
>
> The javadoc does not guarantee the string will be "corrupted" :-/
>
> The "default replacement string" is quite a vague definition,
> so there might be an
>the result string will be corrupted when read
The javadoc does not guarantee the string will be "corrupted" :-/
The "default replacement string" is quite a vague definition,
so there might be an encoding where "default replacement string"
means regular ASCII question mark "?".
All in all,
I slightly disagree with your analysis.
If the file has been written with a different encoding, the result string
will be corrupted when read and unmappable chars replaced as
indicated by [1], but then, the consequence is that the two strings
will differ and the file will be overwritten anyway.
I believe the added CachingWriter is might become a cause of silent
failures.
What CachingWriter does is an attempt to read the file and decode it with
the provided encoding.
Apparently, the decoding might fail since the file might be written in
another encoding or it might be corrupted.
A
great, the new report is really nice
thank you Olivier
Le lundi 14 février 2022, 03:38:00 CET Olivier Lamy a écrit :
> normally there should be a draft one generated by release-drafter and you
> only have to associate the tag and publish it.
> Dependabot updates are under the label dependencies.
normally there should be a draft one generated by release-drafter and you
only have to associate the tag and publish it.
Dependabot updates are under the label dependencies.
some PRs didn't have any label associated so I added some to have a correct
category.
anyway I have regenerated it
Frankly, it is very hard to filter human changes from the dependabot noise.
Am 2022-02-13 um 16:48 schrieb Hervé BOUTEMY:
I did it, but I'm not convinced by the result
if someone knows how to do better, please help :)
Regards,
Hervé
Le dimanche 13 février 2022, 15:54:08 CET Slawomir
I did it, but I'm not convinced by the result
if someone knows how to do better, please help :)
Regards,
Hervé
Le dimanche 13 février 2022, 15:54:08 CET Slawomir Jaranowski a écrit :
> Hi,
>
> Hervé can you add release notes?
> You should have a option "Auto-generate release notes." on tag
>
Hi,
Hervé can you add release notes?
You should have a option "Auto-generate release notes." on tag
https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0
niedz., 13 lut 2022 o 15:42 Hervé BOUTEMY
napisał(a):
> Modello 2.0.0 released
>
>
Modello 2.0.0 released
https://codehaus-plexus.github.io/modello/
Regards,
Hervé
Le lundi 31 janvier 2022, 08:30:08 CET Guillaume Nodet a écrit :
> I was looking at why the maven builds are a bit slow and found out one of
> the culprit is modello which overwrites its generated files even if
On 31. 01. 22 8:30, Guillaume Nodet wrote:
> I was looking at why the maven builds are a bit slow and found out one of
> the culprit is modello which overwrites its generated files even if there
> are no changes: that cascades to recompiling the module, checking the style
> again, making a new
Fwiw, the following branch allows rebuilding the maven-core tree without
any change at all, i.e. if you do a subsequent build, none of the output
files or jars is rewritten.
https://github.com/gnodet/maven/commits/stale-compiler
There are still a few PR that needs to be merged and released in
Awesome ! Thx
Le mar. 1 févr. 2022 à 10:25, Olivier Lamy a écrit :
> On Mon, 31 Jan 2022 at 19:08, Guillaume Nodet wrote:
>
> > Btw, the same thing applies to animal-sniffer with the inclusion of
> > https://github.com/mojohaus/animal-sniffer/pull/165
>
>
> fyi animal-sniffer has just been
On Mon, 31 Jan 2022 at 19:08, Guillaume Nodet wrote:
> Btw, the same thing applies to animal-sniffer with the inclusion of
> https://github.com/mojohaus/animal-sniffer/pull/165
fyi animal-sniffer has just been released ;)
>
>
> Le lun. 31 janv. 2022 à 08:30, Guillaume Nodet a
> écrit :
>
Howdy,
As I see, the current master of modello is 2.0.0 and requires Java 8
I can lend a hand if needed, though I have never released any plexus stuff
yet...
(but am a committer, so maybe it is time for myself to set up my local env?)
T
On Mon, Jan 31, 2022 at 8:30 AM Guillaume Nodet
Btw, the same thing applies to animal-sniffer with the inclusion of
https://github.com/mojohaus/animal-sniffer/pull/165
Le lun. 31 janv. 2022 à 08:30, Guillaume Nodet a écrit :
> I was looking at why the maven builds are a bit slow and found out one of
> the culprit is modello which
I was looking at why the maven builds are a bit slow and found out one of
the culprit is modello which overwrites its generated files even if there
are no changes: that cascades to recompiling the module, checking the style
again, making a new archive and then recompiling the dependant modules
18 matches
Mail list logo
