[GitHub] [maven-shared-incremental] elharo commented on a diff in pull request #23: [MCOMPILER-333] Clean generatedSourcesDirectory along with outputDirectory

2023-04-21 Thread via GitHub
elharo commented on code in PR #23: URL: https://github.com/apache/maven-shared-incremental/pull/23#discussion_r1173926787 ## src/main/java/org/apache/maven/shared/incremental/IncrementalBuildHelper.java: ## @@ -323,25 +362,23 @@ public String[] beforeRebuildExecution( Increme

[GitHub] [maven-shared-incremental] elharo commented on a diff in pull request #23: [MCOMPILER-333] Clean generatedSourcesDirectory along with outputDirectory

2023-04-21 Thread via GitHub
elharo commented on code in PR #23: URL: https://github.com/apache/maven-shared-incremental/pull/23#discussion_r1173925890 ## src/main/java/org/apache/maven/shared/incremental/IncrementalBuildHelper.java: ## @@ -129,6 +146,30 @@ public void setDirectoryScanner( DirectoryScanner

[GitHub] [maven-shared-incremental] elharo commented on a diff in pull request #23: [MCOMPILER-333] Clean generatedSourcesDirectory along with outputDirectory

2023-04-21 Thread via GitHub
elharo commented on code in PR #23: URL: https://github.com/apache/maven-shared-incremental/pull/23#discussion_r1173657637 ## src/main/java/org/apache/maven/shared/incremental/IncrementalBuildHelper.java: ## @@ -129,6 +146,30 @@ public void setDirectoryScanner( DirectoryScanner