[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980633392 Of course, `wrapperUrl` in properties is wrong, but release (even staging) should resolve it ```

[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980632912 in `maven-wrapper` ``` mvn clean install -P run-its ``` and in other project ``` mvn

[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980598578 @hboutemy great job. I've tested by: - build project - unit and IT test are executed, plugin and artifacts are installed - use in another project

[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-16 Thread GitBox
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970426760 From wrapper perspective should not be important what `mvn` command is and what happen inside `mvn`. We should assume that `mvn` command from Maven

[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-10-27 Thread GitBox
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-952590460 I think that running `mvn` from Maven distribution will be better ... Some change to maven scripts can be depend on Maven core code like:

[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-10-26 Thread GitBox
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951775639 Another idea ... why not simply call `mvn*` scripts from Maven distribution ... of course after needed job for wrapper like downloading In this case code