[GitHub] maven pull request: String handling issues identified by PMD

2016-02-09 Thread alexhenrie
Github user alexhenrie closed the pull request at: https://github.com/apache/maven/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] maven pull request: String handling issues identified by PMD

2016-02-09 Thread alexhenrie
Github user alexhenrie commented on the pull request: https://github.com/apache/maven/pull/72#issuecomment-181991785 OK, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] maven pull request: String handling issues identified by PMD

2016-02-09 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/72#issuecomment-181984267 This has been committed. See MNG-5934. Please close this pull request manually. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] maven pull request: String handling issues identified by PMD

2015-11-21 Thread alexhenrie
Github user alexhenrie commented on the pull request: https://github.com/apache/maven/pull/72#issuecomment-158709078 @jvanzyl I can wait until you've finished your other changes, that's no problem. I haven't been able to measure the performance improvement because Maven's execution ti

[GitHub] maven pull request: String handling issues identified by PMD

2015-11-21 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven/pull/72#issuecomment-158668300 Nowadays execution time of array allocation is logarithmic function(array.length). One way or another since of Java 6 the the objects are allocated in the stack instea

[GitHub] maven pull request: String handling issues identified by PMD

2015-11-20 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/72#issuecomment-158483928 I have some code that touches a lot of this so I'd like to apply that first. Also what's the performance difference you observe? --- If your project is set up for it, you

[GitHub] maven pull request: String handling issues identified by PMD

2015-11-20 Thread alexhenrie
GitHub user alexhenrie opened a pull request: https://github.com/apache/maven/pull/72 String handling issues identified by PMD The code linting tool [PMD](http://pmd.sourceforge.net/pmd-5.2.0/) identified numerous places where Maven's string handling is inefficient. I've prepared a