[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_52094 ] Brett Porter commented on MNG-710: -- Mark - yes. But what do you mean will? Add ability to fork the maven-compiler-plugin - Key:

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_52044 ] Mark Proctor commented on MNG-710: -- Will this allow different java versions to be specified on a per module basis, in a multi module build? Add ability to fork the

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_51744 ] jan gunnar grønningsæter commented on MNG-710: -- Thanks again, Brett ! - I'll do that. Jan G. Add ability to fork the maven-compiler-plugin

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_51642 ] jan gunnar grønningsæter commented on MNG-710: -- Hello again ! - Seems I'm in serious trouble. This is the successful part - [INFO] Scanning for projects... [INFO]

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_51704 ] Brett Porter commented on MNG-710: -- Jan, please send your information to users@maven.apache.org - we can't really answer questions effectively in JIRA. Add ability to fork the

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_51530 ] jan gunnar grønningsæter commented on MNG-710: -- Hello. Regarding the M2 forking jdk : forktrue/fork basedirc:/jdk1.3/bin/basedir Do I have wrong release (Maven 2.0)? I'm

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_51562 ] jan gunnar grønningsæter commented on MNG-710: -- Thanks for your quick answer, Brett ! Reports back first thing in the morning. Jan G Add ability to fork the

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_51567 ] jan gunnar grønningsæter commented on MNG-710: -- Brett - Well, I did it right away. - Just to say *it worked*, really do appreciate that, Sir! Jan G Add ability to fork

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_45100 ] Trygve Laugstol commented on MNG-710: - Hm, woops, must've missed that part. I'll fix that asap. Add ability to fork the maven-compiler-plugin

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_45107 ] Trygve Laugstol commented on MNG-710: - This should have been fixed now. Add ability to fork the maven-compiler-plugin - Key:

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_45116 ] Rod Coffin commented on MNG-710: Works great now, thanks Trygve! Add ability to fork the maven-compiler-plugin - Key: MNG-710

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_45086 ] Rod Coffin commented on MNG-710: I just tried compiling with a forked JDK 1.3 compiler and it seems that the source parameter is still being passed to the compiler. I think this is

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44177 ] Rod Coffin commented on MNG-710: I've tried out these changes and the only problem I see at this point is that the source argument is always being passed, even if forking to a jdk 1.3

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44178 ] Trygve Laugstol commented on MNG-710: - I'll look into this soon, just a few comments: 1) Do not change how the code looks, at least not when you're not using the existing style 2)

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44179 ] Rod Coffin commented on MNG-710: My bad with the style, I had it applied and must have messed up my settings. Would you like me to reapply the style and submit the diff? I'll also keep

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44181 ] Rod Coffin commented on MNG-710: I think checking the fork flag would work if you specify source and target in your plugin configuration. Basically if forking those flags wouldn't be

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44185 ] Trygve Laugstol commented on MNG-710: - If you are compiling this with a (internal or external) 1.4 compiler you will have to set the same flags by default (-source 1.3 -target 1.1).

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44186 ] Rod Coffin commented on MNG-710: So it sounds like we will need to add a comiler version parameter to the plexus compiler and add arguments based on this setting. I would be ok with

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44188 ] Trygve Laugstol commented on MNG-710: - Yeah, I think that would make most sense. We really need some test cases for this now. Add ability to fork the maven-compiler-plugin

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44190 ] Rod Coffin commented on MNG-710: I can write some test cases for this but won't have the time until tomorrow night. When I get the chance I'll create a few and upload them as a diff to

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44129 ] Trygve Laugstol commented on MNG-710: - Why don't you pass the same arguments list to both the internal and external compiler? Add ability to fork the maven-compiler-plugin

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44133 ] Rod Coffin commented on MNG-710: Valid compiler arguements differ based on the version of the compiler used. For example, we don't want to pass the 'source' argument to a 1.3 compiler

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44134 ] Trygve Laugstol commented on MNG-710: - Is this the only different option? If so it's best to build that into the compiler instead of having to pass in all the arguments all over

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44135 ] Rod Coffin commented on MNG-710: The problem is that users of this plugin can specify any arbitrary java compiler. So the compiler type (IBM, Sun, etc.) and version could all vary. I

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44136 ] Trygve Laugstol commented on MNG-710: - Ok, I see your argument but this implementation is Sun javac specific because all the compilers have their own output format. I would like to

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44139 ] Trygve Laugstol commented on MNG-710: - I've collapsed the generation of the arguments now and will try it out on with the different compilers I have here. Add ability to fork the

[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin

[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44140 ] Trygve Laugstol commented on MNG-710: - Plexus parts committed. Add ability to fork the maven-compiler-plugin - Key: MNG-710