[jira] Commented: (MPECLIPSE-25) Add the capability of specifying more builders

2004-05-05 Thread jira
The following comment has been added to this issue: Author: dion gillard Created: Wed, 5 May 2004 8:18 PM Body: Thanks for the tests. I can add some checks on the xml similar to the tests in the ear plugin. - View

Re: [jira] Commented: (MPECLIPSE-25) Add the capability of specifying more builders

2004-05-05 Thread Miguel Griffa
Hi I don't think (excuse me all for giving my opinion like this being so unknown) supporting eclipse plugins directy should be added to maven. This would be a lot of work and little payoff. I think that the current plugin shuold be improved to support all data for .project and .classpath (pr

Re: [jira] Commented: (MPECLIPSE-25) Add the capability of specifying more builders

2004-05-05 Thread Miguel Griffa
I submited a patch that adds tests for the builders and natures, I made the tests separated because I think that the test shuold include some validation over the expected contents of the generated file I don't know how to do this with jelly yet... Miguel Griffa wrote: I'll go for the test case n

Re: [jira] Commented: (MPECLIPSE-25) Add the capability of specifying more builders

2004-05-05 Thread Miguel Griffa
I'll go for the test case now, I'm sorry, but being newbie is a bit unfamiliar for me testing maven plugin I'll submit a patch for the test case if I manage to get one :) [EMAIL PROTECTED] wrote: The following comment has been added to this issue: Author: dion gillard Created: Tue, 4 May 2

Re: [jira] Commented: (MPECLIPSE-25) Add the capability of specifying more builders

2004-05-05 Thread Felipe Leme
Hi all, Regardless of this patche fixing the bug or not, I think we could go a step further on the Eclipse project/nature/builder support. Let me explain better. For the case of 'less intrusive' Eclipse plugins (like Checkstyle), I think the patch is fine. But that is not enough for plugins th

[jira] Commented: (MPECLIPSE-25) Add the capability of specifying more builders

2004-05-04 Thread jira
The following comment has been added to this issue: Author: dion gillard Created: Tue, 4 May 2004 9:04 PM Body: This patch looks ok to me. It would be nice if we had a test case for it, but I can apply and test if everyone is ok with it