[shade] which java version

2021-07-20 Thread Romain Manni-Bucau
Hi all, shade plugin pom defines java version to 7 (1.7) but it uses streams which are java 8 only, should javaVersion property be updated? Romain Manni-Bucau @rmannibucau | Blog | Old Blog |

Re: [shade] which java version

2021-07-21 Thread Slawomir Jaranowski
Hi, very interesting case but I can't see 1.8 streams in https://github.com/apache/maven-shade-plugin/tree/master Can you point where you found it? By the way, maybe it's time to start switching plugins to 1.8 ... śr., 21 lip 2021 o 08:09 Romain Manni-Bucau napisał(a): > Hi all, > > shade pl

Re: [shade] which java version

2021-07-21 Thread Tibor Digana
What's the cost of this task? A day? Do you want to include it in the release version 3.4.0? On Wed, Jul 21, 2021 at 8:09 AM Romain Manni-Bucau wrote: > Hi all, > > shade plugin pom defines java version to 7 (1.7) but it uses streams which > are java 8 only, should javaVersion property be upda

Re: [shade] which java version

2021-07-21 Thread Romain Manni-Bucau
@Slawomir: It is mainly due to some dependencies like jdepndency which is java 8 only so the plugin is overall java 8 now. @Tibor: changing a 7 to a 8 in a pom, hope it does not take us a day ;) If we say it is java 8, it will not change much but if we say it is java 7 we must revert a few things