Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-02-16 Thread Tibor Digana
-Archiver-multithreaded-Zip-edition-tp5822942p5826591.html Sent from the Maven Developers mailing list archive at Nabble.com. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-12 Thread tibor17
ation should have DMA access to that memory this way. - BR, tibor17 -- View this message in context: http://maven.40175.n5.nabble.com/Preview-release-Plexus-Archiver-multithreaded-Zip-edition-tp5822942p5823268.html Sent from the Maven Developers mailing list archive at Nabbl

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-12 Thread Igor Fedorenko
byte array, might be interesting too. - BR, tibor17 -- View this message in context: http://maven.40175.n5.nabble.com/Preview-release-Plexus-Archiver-multithreaded-Zip-edition-tp5822942p5823241.html Sent from the Maven Developers mailing list archive at Nabbl

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-12 Thread tibor17
in ThreadLocal copy for certainly small thread pool. I didn't measure the time spent on flushing ByteBuffer with 256KB byte array, might be interesting too. - BR, tibor17 -- View this message in context: http://maven.40175.n5.nabble.com/Preview-release-Plexus-Archiver-multithreade

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-12 Thread Kristian Rosenvold
t; Thread as it was before with more fancy join-functionality for us developers > - nothing special - no direct selection of processor in Java code. > > > > - > BR, tibor17 > -- > View this message in context: > http://maven.40175.n5.nabble.com/Preview-release-Plexus-Archiver

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-12 Thread tibor17
rkJoinPool is a pure pool with Java Threads - it's still the same Thread as it was before with more fancy join-functionality for us developers - nothing special - no direct selection of processor in Java code. - BR, tibor17 -- View this message in context: http://maven.40175.n5.nabble.com/P

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-12 Thread Anders Hammar
> > TL;DR we should let the OS be responsible for applying resource limits, we > should use every resource we are given to the full in order to reduce the > build time as that shortens the feedback loop and makes developers mire > productive I guess I agree. Guidelines doesn't work anyways as the

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-12 Thread Kristian Rosenvold
2015-01-12 9:24 GMT+01:00 Kristian Rosenvold : > Creating a 256MB zip file with typical jar content has a compression > phase of 4 seconds on my 6 core machine, with 1.4 seconds in the > "gather" phase. You'd need some really huge zips for this to become a > real problem, and in that case I someho

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-12 Thread Kristian Rosenvold
2015-01-12 9:03 GMT+01:00 Anders Hammar : > Do you foresee any issues with "use all available CPU cores" when used on a > shared resource like CI server? > When writing guidelines for my customers' devs I'm always very firm on that > build jobs are not allowed to fork (or similar) freely and thereb

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-12 Thread Stephen Connolly
On Monday, 12 January 2015, Anders Hammar wrote: > Do you foresee any issues with "use all available CPU cores" when used on a > shared resource like CI server? > When writing guidelines for my customers' devs I'm always very firm on that > build jobs are not allowed to fork (or similar) freely a

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-12 Thread Kristian Rosenvold
vity" tool gave me this measurement results. > The same test was done on Unix & Sun machine with RAID and the minimum > latency was not such significant - even worse than with Windows. > > > > -- > View this message i

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-12 Thread Anders Hammar
Do you foresee any issues with "use all available CPU cores" when used on a shared resource like CI server? When writing guidelines for my customers' devs I'm always very firm on that build jobs are not allowed to fork (or similar) freely and thereby occupy more than their share of the resources on

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-11 Thread Tibor Digana
p; Sun machine with RAID and the minimum latency was not such significant - even worse than with Windows. -- View this message in context: http://maven.40175.n5.nabble.com/Preview-release-Plexus-Archiver-multithreaded-Zip-edition-tp5822942p5823154.html Sent from the Maven Developers mailing l

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Kristian Rosenvold
Nope, I did not miss it. DeferredFileOutputStream writes everything to disk once it reaches the treshold, so it basically frees the allocated memory buffers. Mine keeps the allocated buffers and creates a SequenceInputStream over allocated buffers + disk file Kristian 2015-01-10 23:14 GMT+01:00

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Jörg Schaible
Kristian Rosenvold wrote: [snip] > Inside commons-compress this target is always a > tempfile. Inside plexus-archiver OffloadingOutputStream (a > commons-compress ScatterOutputStream) is used. This writes to some > pretty huge memory buffers, but when a certain treshold is reached it > offloads t

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Kristian Rosenvold
DMA on >> mapped memory really gains the performance. >> >> >> >> -- >> View this message in context: >> http://maven.40175.n5.nabble.com/Preview-release-Plexus-Archiver-multithreaded-Zip-edition-tp5822942p5823032.html >> Sent from the Maven Developers ma

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Igor Fedorenko
. So this DMA on mapped memory really gains the performance. -- View this message in context: http://maven.40175.n5.nabble.com/Preview-release-Plexus-Archiver-multithreaded-Zip-edition-tp5822942p5823032.html Sent from the Maven Developers mailing list archive at Nabble.com

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Kristian Rosenvold
omAccessFile on > very large files 1GB got terribly fast throughput 400MB/s on ordinal hard > drive however the flush/close operation was obviously slow. So this DMA on > mapped memory really gains the performance. > > > > -- > View this message in context: > http://maven.

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Tibor Digana
/close operation was obviously slow. So this DMA on mapped memory really gains the performance. -- View this message in context: http://maven.40175.n5.nabble.com/Preview-release-Plexus-Archiver-multithreaded-Zip-edition-tp5822942p5823032.html Sent from the Maven Developers mailing list archive at

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Kristian Rosenvold
Where was the hotspot you gained the performance? Was it just the Java code > you add ZipEntries in the stream, or parallel writes in file, or this > improvement is specific on the hard drive? Does it apply to normal hard > drive or SSD better maybe? > > > > -- > View this messa

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Tibor Digana
context: http://maven.40175.n5.nabble.com/Preview-release-Plexus-Archiver-multithreaded-Zip-edition-tp5822942p5823013.html Sent from the Maven Developers mailing list archive at Nabble.com. - To unsubscribe, e-mail: dev-unsubscr

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Kristian Rosenvold
2015-01-10 16:46 GMT+01:00 Stefan Bodewig : >> I originally had ConcurrentJarCreator in my c-compress fork. We discussed >> this (arguably somewhat briefly) on the commons mailing list and to my >> understanding Stefan wants c-c to be more of a toolkit (at a slightly lower >> level) and did not wan

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Jason van Zyl
Cool. I'm going to try it on my project and a couple other tests and if it makes things better I'll push a change for review. On Jan 10, 2015, at 11:29 AM, Kristian Rosenvold wrote: > When I look at this code I see that there's probably a fair bit of > work to do to bring this up to a level th

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Kristian Rosenvold
When I look at this code I see that there's probably a fair bit of work to do to bring this up to a level that would fit for commons. Since this does not really add any value for maven users I'm not immediately willing to do this; I have other higher-value targets in sight. Maybe sometime later. If

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Kristian Rosenvold
2015-01-10 16:58 GMT+01:00 Michael Osipov : > the writeTo method uses currentTimeMillis to calculate elapsed time. You > should rather turn that to nanoTime, see MNG-5626. Damn. At my age System.currentTimeInMinutes() feels more appropriate K -

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Michael Osipov
Am 2015-01-10 um 16:51 schrieb Kristian Rosenvold: I'm probably mixing threads here. Better to do so in email than in code :) The file we're talking about is https://github.com/sonatype/plexus-archiver/blob/2.x/src/main/java/org/codehaus/plexus/archiver/zip/ConcurrentJarCreator.java Kristian,

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Kristian Rosenvold
I'm probably mixing threads here. Better to do so in email than in code :) The file we're talking about is https://github.com/sonatype/plexus-archiver/blob/2.x/src/main/java/org/codehaus/plexus/archiver/zip/ConcurrentJarCreator.java Kristian 2015-01-10 16:46 GMT+01:00 Stefan Bodewig : > On 20

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Stefan Bodewig
On 2015-01-10, Kristian Rosenvold wrote: > 10. jan. 2015 15:19 skrev "Jason van Zyl" : >> So I took a look and my feedback: >> You have a blurb about how to use the parallel code in commons-compress >> but there is no test or example that actually shows how to make one. The >> actual working exa

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Kristian Rosenvold
10. jan. 2015 15:19 skrev "Jason van Zyl" : > So I took a look and my feedback: > > You have a blurb about how to use the parallel code in commons-compress > but there is no test or example that actually shows how to make one. The > actual working example is in plexus-archiver and if you don't min

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Jason van Zyl
In the project I'm working on there is one module that has a very large JAR, and the final application ZIP is super massive. So I'll try with those next and report back with some metrics as well. On Jan 10, 2015, at 9:06 AM, Kristian Rosenvold wrote: > Yes. Everything should be noticeably fas

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Jason van Zyl
So I took a look and my feedback: You have a blurb about how to use the parallel code in commons-compress but there is no test or example that actually shows how to make one. The actual working example is in plexus-archiver and if you don't mind I'd like to put a utility in commons-compress so

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Kristian Rosenvold
Yes. Everything should be noticeably faster. I have also been working on features that allows transfer of compressed entries from one jar file to another without packing/unpacking, which should be great for all kinds of exploded archives inside zips/jars. I hope to get that into a second beta soon.

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Jeff Jensen
Sounds like an awesome improvement! Will we see speed improvement on war file creation with many megs of jars in the lib dir or only with compressing of files into the archive (ignoring the web files for this question)? On Sat, Jan 10, 2015 at 7:43 AM, Kristian Rosenvold < kristian.rosenv...@gma

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Kristian Rosenvold
I had 950% CPU usage on my 6 core + HT machine here the other day. Kristian 2015-01-10 14:42 GMT+01:00 Kristian Rosenvold : > It's faster; a lot faster - and it scales beautifully. But then > again you probably need "war/ear/zip" heavy builds to really get max > effect. The average "jar" plugi

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Kristian Rosenvold
It's faster; a lot faster - and it scales beautifully. But then again you probably need "war/ear/zip" heavy builds to really get max effect. The average "jar" plugin does not usually consume that large a percentage the average build. I'll try to make some nice graphs and a blog post some time th

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Jason van Zyl
Do you have any metrics? I use compress-compress directly so I can certainly try it on some large archives. Anything special need to be done? Or do the same code paths still work they just use the cores available with the new version? On Jan 10, 2015, at 7:23 AM, Kristian Rosenvold wrote: > I

Preview release: Plexus Archiver multithreaded Zip edition

2015-01-10 Thread Kristian Rosenvold
I just released plexus-archiver version 2.10-beta-1 to maven central. This is a "technology preview" of the multithreaded Zip feature I have been adding to commons-compress for the last few weeks, and will basically use all available CPU cores when compressing the archive. To test/use this featur