Re: Second MNG-6344

2018-06-11 Thread Stuart McCulloch
I posted some background why Maven currently uses the no-AOP build in https://github.com/apache/maven/pull/169#issuecomment-396177378 On 10 June 2018 at 19:42, Michael Osipov wrote: > Am 2018-06-10 um 15:45 schrieb Robert Scholte: > >> I'm a bit worried about the no_aop drop. I'm pretty sure Stu

Re: Second MNG-6344

2018-06-10 Thread Michael Osipov
Am 2018-06-10 um 15:45 schrieb Robert Scholte: I'm a bit worried about the no_aop drop. I'm pretty sure Stuart would have noticed this in the past. I'm very proud we can say that even Maven 3.0 still runs on the latest JDK version, introducing bytecode parsers like ASM might block this benefit

Re: Second MNG-6344

2018-06-10 Thread Robert Scholte
I'm a bit worried about the no_aop drop. I'm pretty sure Stuart would have noticed this in the past. I'm very proud we can say that even Maven 3.0 still runs on the latest JDK version, introducing bytecode parsers like ASM might block this benefit with future versions. Don't think we need it.

Re: Second MNG-6344

2018-06-10 Thread Stephen Connolly
+1 On Sun 10 Jun 2018 at 09:32, Michael Osipov wrote: > Folks, > > who seconds MNG-6344 (Guice upgrade) for 3.5.4? All ITs pass. > > > Michael > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional com

Second MNG-6344

2018-06-10 Thread Michael Osipov
Folks, who seconds MNG-6344 (Guice upgrade) for 3.5.4? All ITs pass. Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org