Re: Should the Dependency interface contains a getPath() method?

2024-08-10 Thread Martin Desruisseaux
Le 2024-08-08 à 11 h 04, Martin Desruisseaux a écrit : It would be great to have this summary in the package-info Javadoc, and also the relevant parts in each interface Javadoc. I will try to do a PR next weekend for that. Done as pull request #1640. Relevant commit is: https://github.c

Re: Should the Dependency interface contains a getPath() method?

2024-08-08 Thread Guillaume Nodet
Le jeu. 8 août 2024 à 11:05, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit : > Hello Guillaume > > Le 2024-08-07 à 22 h 23, Guillaume Nodet a écrit : > > > * ArtifactCoordinate are used to locate artifacts in a repository, > > it's basically a pointer to a file in maven rep

Re: Should the Dependency interface contains a getPath() method?

2024-08-08 Thread Martin Desruisseaux
Hello Guillaume Le 2024-08-07 à 22 h 23, Guillaume Nodet a écrit : * ArtifactCoordinate are used to locate artifacts in a repository, it's basically a pointer to a file in maven repository * Artifact is the pointed artifact in the repository. They are created when *resolving* an Art

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Guillaume Nodet
Le lun. 5 août 2024 à 14:07, Martin Desruisseaux a écrit : > > Maven 4 has two very similar public interfaces for dependencies: > > * Dependency > * DependencyCoordinate > > They both have groupId, artifactId, classifier, version, extension, type > and scope. Differences that I observed are: >

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 18 h 25, Guillaume Nodet a écrit : Can it load non JPMS jars too ? Yes, as an "automatic" or "unnamed" module.     Martin - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands,

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Guillaume Nodet
Can it load non JPMS jars too ? Maybe this has changed, but my understanding is that everything had to be JPMS modules, meaning that any plugin that has a dependency which is not a JPMS module would not be loadable… That’s a too big constraint imho. Guillaume Nodet Le m

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 17 h 38, Guillaume Nodet a écrit : Did I miss something ? We need to load plugins at runtime, I thought JPMS was static… JPMS can load plugins at runtime as well. However, the way to do that is very different. It is no longer with ClassLoader, we have to use ModuleLayer instead

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Guillaume Nodet
Le mer. 7 août 2024 à 15:30, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit : > Le 2024-08-07 à 14 h 21, Guillaume Nodet a écrit : > > > > Why do we care ? If we provide a well defined API (with a known set of > > jars), people should be aware if they use maven-core jar directly….

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 14 h 21, Guillaume Nodet a écrit : Why do we care ? If we provide a well defined API (with a known set of jars), people should be aware if they use maven-core jar directly…. It is a matter of reputation for the Maven project. A Murphy law is that given a sufficiently large am

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Guillaume Nodet
I’ll reply to that one later… Guillaume Nodet Le lun. 5 août 2024 à 14:07, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit : > Maven 4 has two very similar public interfaces for dependencies: > > * Dependency > * DependencyCoordinate > > They both h

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Guillaume Nodet
Guillaume Nodet Le mer. 7 août 2024 à 13:24, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit : > Le 2024-08-07 à 12 h 55, Guillaume Nodet a écrit : > > > I'm not a big fan of reducing the visibility of implementation > > classes. The API is well defined,

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 12 h 55, Guillaume Nodet a écrit : I'm not a big fan of reducing the visibility of implementation classes. The API is well defined, i.e. all org.apache.maven.api.* packages. It is because while the API does not expose Eclipse Aether, the implementation does. If, in the future

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Guillaume Nodet
Le mar. 6 août 2024 à 11:08, Martin Desruisseaux a écrit : > > Le 2024-08-05 à 14 h 19, Tamás Cservenák a écrit : > > > You are on the right track and Guillame and I had a lot of discussions > > about this. IMO, best would be to wait for him (is on PTO I think) and > > have a chat face to face? >

Re: Should the Dependency interface contains a getPath() method?

2024-08-06 Thread Martin Desruisseaux
Le 2024-08-05 à 14 h 19, Tamás Cservenák a écrit : You are on the right track and Guillame and I had a lot of discussions about this. IMO, best would be to wait for him (is on PTO I think) and have a chat face to face? Yes I'm fine with a talk. I'm available most time of the day (except toda

Re: Should the Dependency interface contains a getPath() method?

2024-08-05 Thread Tamás Cservenák
Howdy, You are on the right track and Guillame and I had a lot of discussions about this. IMO, best would be to wait for him (is on PTO I think) and have a chat face to face? Thanks T On Mon, Aug 5, 2024 at 2:07 PM Martin Desruisseaux < martin.desruisse...@geomatys.com> wrote: > Maven 4 has two

Re: Should the Dependency interface contains a getPath() method?

2024-08-05 Thread Martin Desruisseaux
Le 2024-08-05 à 14 h 07, Martin Desruisseaux a écrit : * Optional getModuleModuleDescriptor() Typo: should be getModuleDescription(). It was a copy-and-paste error.     Martin