Re: Use of jspecify in Maven

2024-02-15 Thread Gary D. Gregory
FTR: - JSR305 https://jcp.org/en/jsr/detail?id=305 Status: Dormant - JSR308 https://jcp.org/en/jsr/detail?id=308 Status: Final - https://dzone.com/articles/when-to-use-jsr-305-for-nullability-in-java - The endless reddit references With more links on the above pages. Gary On 2024/02/

Re: Use of jspecify in Maven

2024-02-15 Thread Benjamin Marwell
OK, let's wait for the JEP to arrive then. > Such a dependency would only be useful if compilers. > IDEs, and incremental compilers within IDEs (like in Eclipse) would > know about them to report warnings. Luckily, at least the IDEs do. For maven builds, you'd need sth like the checker framework

Re: Use of jspecify in Maven

2024-02-12 Thread Gary Gregory
On Mon, Feb 12, 2024 at 6:33 AM Matthias Bünger wrote: > > (I'm neither a Maven core or plugin maintainer) > > I don't like such annotations as in my opinion, they save you nothing, > but bring an addional dependency and problems with the tools that > (don't) support (only a specific version of) t

Re: Use of jspecify in Maven

2024-02-12 Thread Tamás Cservenák
https://github.com/apache/incubator-kie-drools/pull/5674#issuecomment-1928931840 On Mon, Feb 12, 2024 at 12:33 PM Matthias Bünger wrote: > (I'm neither a Maven core or plugin maintainer) > > I don't like such annotations as in my opinion, they save you nothing, > but bring an addional dependency

Re: Use of jspecify in Maven

2024-02-12 Thread Matthias Bünger
(I'm neither a Maven core or plugin maintainer) I don't like such annotations as in my opinion, they save you nothing, but bring an addional dependency and problems with the tools that (don't) support (only a specific version of) them. If my method needs arguments that are not null than I have t

Re: Use of jspecify in Maven

2024-02-11 Thread Romain Manni-Bucau
Rather -0 on my side by experience cause this kind of tool is often abused, in particular using an IoC or a codebase with indirections like maven. One prerequisite being all the stack uses it - plexus, sisu, commons etc - Im not sure we can get the benefits without the downsides. That said you can

Re: Use of jspecify in Maven

2024-02-11 Thread Elliotte Rusty Harold
I'd prefer not. Every additional dependency we add is a liability. It's not clear we need something like this and even if we do, JSpecify is only a few months old. This is only the latest of many efforts to establish a standard for nullness annotations. I don't see why JSpecify will be the one ring