Re: about MCOMPILER-80 (set compiler default to 1.5)

2009-06-06 Thread nicolas de loof
2009/6/6 Brian Fox > On Sat, Jun 6, 2009 at 8:28 AM, nicolas de loof >wrote: > > > Could we also : > > - set 2.0.9+ as maven version prerequisite in a compiler 2.1 branch, so > > that > > any user running an older maven version (and may use this 2.1 plugin from > > LATEST rule) would be warned e

Re: about MCOMPILER-80 (set compiler default to 1.5)

2009-06-06 Thread Brian Fox
On Sat, Jun 6, 2009 at 8:28 AM, nicolas de loof wrote: > Could we also : > - set 2.0.9+ as maven version prerequisite in a compiler 2.1 branch, so > that > any user running an older maven version (and may use this 2.1 plugin from > LATEST rule) would be warned early during the build and not when d

Re: about MCOMPILER-80 (set compiler default to 1.5)

2009-06-06 Thread nicolas de loof
Could we also : - set 2.0.9+ as maven version prerequisite in a compiler 2.1 branch, so that any user running an older maven version (and may use this 2.1 plugin from LATEST rule) would be warned early during the build and not when deploying its app on a Java 1.4 runtime. - set java 5 as plugin ru

Re: about MCOMPILER-80 (set compiler default to 1.5)

2009-06-04 Thread nicolas de loof
Right, so do we agree to upgrade default-value to 1.5 in a new 2.1 branch of the compiler plugin (with required warnings in release note) ? 2009/6/5 Olivier Lamy > 2009/6/4 Brian Fox : > > On Thu, Jun 4, 2009 at 9:44 AM, nicolas de loof > wrote: > > > >> Hi, > >> just an suggestion for a poten

Re: about MCOMPILER-80 (set compiler default to 1.5)

2009-06-04 Thread Olivier Lamy
2009/6/4 Brian Fox : > On Thu, Jun 4, 2009 at 9:44 AM, nicolas de loof wrote: > >> Hi, >> just an suggestion for a potential fix to >> http://jira.codehaus.org/browse/MCOMPILER-80 >> >> as maven 2.0.9 fixes the plugin version in super POM, we can consider that >> - if maven 2.0.9 + is detected - a

Re: about MCOMPILER-80 (set compiler default to 1.5)

2009-06-04 Thread Brian Fox
On Thu, Jun 4, 2009 at 9:44 AM, nicolas de loof wrote: > Hi, > just an suggestion for a potential fix to > http://jira.codehaus.org/browse/MCOMPILER-80 > > as maven 2.0.9 fixes the plugin version in super POM, we can consider that > - if maven 2.0.9 + is detected - any version of maven compiler >

Re: about MCOMPILER-80 (set compiler default to 1.5)

2009-06-04 Thread Benjamin Bentmann
nicolas de loof wrote: So my idea would be to (pseudo-code) : if ( mavenSession.getVersion() > 2.0.9 && source == null) { source = 1.5; } IMHO, making a default value a function of both the plugin version and the Maven version introduces unnecessary complexity to the code and confusion

about MCOMPILER-80 (set compiler default to 1.5)

2009-06-04 Thread nicolas de loof
Hi, just an suggestion for a potential fix to http://jira.codehaus.org/browse/MCOMPILER-80 as maven 2.0.9 fixes the plugin version in super POM, we can consider that - if maven 2.0.9 + is detected - any version of maven compiler > 2.0.2 (the one set in super-pom) has been set by the user. In such