Re: relativePath for parent poms in our plugins

2019-12-22 Thread Hervé BOUTEMY
Le samedi 21 décembre 2019, 19:22:42 CET Mark Struberg a écrit : > To be honest, I didn't even know that there is a 'main project' with tons of > git-submodules to emulate our old maven master build. yes, I imagine, I did not make much noise about it :) It's not about emulating an old master build

Re: relativePath for parent poms in our plugins

2019-12-21 Thread Mark Struberg
To be honest, I didn't even know that there is a 'main project' with tons of git-submodules to emulate our old maven master build. I still wonder whether it has any benefit to have the relativePath in our plugins. It is useful if you have a reactor build where maven then knows how to search for

Re: relativePath for parent poms in our plugins

2019-12-21 Thread Romain Manni-Bucau
Le sam. 21 déc. 2019 à 15:03, Hervé BOUTEMY a écrit : > how does the current relativePath work less than without it? > Does it really break anything more than just "people don't understand the > value" then consider it "wrong"? > Well, it is unlikely but it can break the build yes, at least if i

Re: relativePath for parent poms in our plugins

2019-12-21 Thread Hervé BOUTEMY
how does the current relativePath work less than without it? Does it really break anything more than just "people don't understand the value" then consider it "wrong"? in addition, I know that intermittent Maven contributor will clone only one Git repository, but I personally work on every Maven

Re: relativePath for parent poms in our plugins

2019-12-21 Thread Romain Manni-Bucau
Agree with Robert, git clone && mvn install must always work and be straight forward if we want people to be able to help/work imho. Le sam. 21 déc. 2019 à 13:33, Robert Scholte a écrit : > that only works for the very, very few that uses this repository. > It should work as to how contributors

Re: relativePath for parent poms in our plugins

2019-12-21 Thread Robert Scholte
that only works for the very, very few that uses this repository.  It should work as to how contributors work with it, otherwise you'll see other issues compared to them. Robert On 21-12-2019 12:33:53, Hervé BOUTEMY wrote: disagree We have the repo configuration which brings a location for ever

Re: relativePath for parent poms in our plugins

2019-12-21 Thread Hervé BOUTEMY
disagree We have the repo configuration which brings a location for every Git repository: https://maven.apache.org/scm.html or https://github.com/apache/maven-sources/ The relative paths are calculated against that. And I recently even added aggregator poms to build absolutely everything in one

Re: relativePath for parent poms in our plugins

2019-12-19 Thread Robert Scholte
I agree. RelativePath is only useful within a Maven MultiModule project (in 1 git repo) Using is even a bit better, because it overwrites the default of ../pom.xml and forces to look in the local/remote repo Robert On 19-12-2019 12:14:40, Mark Struberg wrote: Hi folks! Looking at massembler

Re: relativePath for parent poms in our plugins

2019-12-19 Thread Romain Manni-Bucau
Agree Le jeu. 19 déc. 2019 à 12:14, Mark Struberg a écrit : > Hi folks! > > Looking at massembler right now I stumbled across a parentPom section > > > maven-plugins > org.apache.maven.plugins > 33 > ../../pom/maven/maven-plugins/pom.xml > > > This was perfectly fine when we had all in

relativePath for parent poms in our plugins

2019-12-19 Thread Mark Struberg
Hi folks! Looking at massembler right now I stumbled across a parentPom section maven-plugins org.apache.maven.plugins 33 ../../pom/maven/maven-plugins/pom.xml This was perfectly fine when we had all in SVN under one big project. But nowadays - having all in GIT - I'd we should remove