Re: svn commit: r1127943 - in /maven/plugins/trunk/maven-shade-plugin: pom.xml src/main/java/org/apache/maven/plugins/shade/DefaultShader.java src/main/java/org/apache/maven/plugins/shade/Shader.java

2011-05-27 Thread Lukas Theussl
Daniel, This commit breaks jenkins: https://builds.apache.org//view/M-R/view/Maven/job/maven-plugins-ITs-2.x/ and I also see it locally, can you review? Thanks, -Lukas dk...@apache.org wrote: Author: dkulp Date: Thu May 26 14:30:55 2011 New Revision: 1127943 URL:

Re: svn commit: r1127943 - in /maven/plugins/trunk/maven-shade-plugin: pom.xml src/main/java/org/apache/maven/plugins/shade/DefaultShader.java src/main/java/org/apache/maven/plugins/shade/Shader.java

2011-05-27 Thread Daniel Kulp
On Friday, May 27, 2011 4:37:45 AM Lukas Theussl wrote: Daniel, This commit breaks jenkins: https://builds.apache.org//view/M-R/view/Maven/job/maven-plugins-ITs-2.x/ and I also see it locally, can you review? I committed a fix and re-triggered a Jenkins build and it looks OK now.

Re: svn commit: r1127943 - in /maven/plugins/trunk/maven-shade-plugin: pom.xml src/main/java/org/apache/maven/plugins/shade/DefaultShader.java src/main/java/org/apache/maven/plugins/shade/Shader.java

2011-05-27 Thread Benson Margulies
That's interesting. *how* did it break that build? On Fri, May 27, 2011 at 8:49 AM, Daniel Kulp dk...@apache.org wrote: On Friday, May 27, 2011 4:37:45 AM Lukas Theussl wrote: Daniel, This commit breaks jenkins: https://builds.apache.org//view/M-R/view/Maven/job/maven-plugins-ITs-2.x/ and

Re: svn commit: r1127943 - in /maven/plugins/trunk/maven-shade-plugin: pom.xml src/main/java/org/apache/maven/plugins/shade/DefaultShader.java src/main/java/org/apache/maven/plugins/shade/Shader.java

2011-05-27 Thread Daniel Kulp
On Friday, May 27, 2011 9:32:20 AM Benson Margulies wrote: That's interesting. *how* did it break that build? Honestly, I didn't really dig into it. I just noticed in the pom that you updated the asm version to 3.3.1, but you didn't update the asm-common version to match it.On a whim, I

Re: svn commit: r1127943 - in /maven/plugins/trunk/maven-shade-plugin: pom.xml src/main/java/org/apache/maven/plugins/shade/DefaultShader.java src/main/java/org/apache/maven/plugins/shade/Shader.java

2011-05-27 Thread Lukas Theussl
Daniel Kulp wrote: On Friday, May 27, 2011 9:32:20 AM Benson Margulies wrote: That's interesting. *how* did it break that build? Honestly, I didn't really dig into it. I just noticed in the pom that you updated the asm version to 3.3.1, but you didn't update the asm-common version to