Just so it's clear, I'm -1 on this commit. I see things like:
-private Map managedVersionMap;
+private Map managedVersionMap;
And that means it wasn't done properly and thus I have no faith in the rest
of the commit. Please revert this.
On Mon, May 4, 2009 at 8:54 AM, wrote:
> Author: n
...and the new version with the changes builds fine, with ITs passing.
This may seem like a good thing, but the fact that the build/ITs work in
both cases is pretty disturbing, IMO. It means that we can't necessarily
depend on these criteria to determine whether the syntax conversion is
workin
the version before this commit did actually build and run the ITs. I
really have no idea how, TBH.
Brian Fox wrote:
Changes like this are pretty disastrous:
-private Map managedVersionMap;
+private Map managedVersionMap;
Does it even compile?
John Casey wrote:
Can you please take a lo
Changes like this are pretty disastrous:
-private Map managedVersionMap;
+private Map managedVersionMap;
Does it even compile?
John Casey wrote:
Can you please take a look at any other code you might have
automatically "fixed" using Eclipse's tooling without then reviewing
yourself, so
Can you please take a look at any other code you might have
automatically "fixed" using Eclipse's tooling without then reviewing
yourself, so we can avoid the obvious problems that could be caused by
this sort of thing creeping in? For anyone looking at this code
interactions and converting it
