Re: svn commit: r789993 - in /maven/components/trunk/maven-core/src: main/java/org/apache/maven/ main/java/org/apache/maven/execution/ main/java/org/apache/maven/lifecycle/ main/java/org/apache/mave

2009-07-02 Thread Igor Fedorenko
Olivier, What are the advantages of using an interface in this particular case? Abstract class will allow core to add new callback methods without breaking all existing participants, assuming participants honour beforeXXX/afterXXX naming convention. -- Regards, Igor Olivier Lamy wrote: Wh

Re: svn commit: r789993 - in /maven/components/trunk/maven-core/src: main/java/org/apache/maven/ main/java/org/apache/maven/execution/ main/java/org/apache/maven/lifecycle/ main/java/org/apache/mave

2009-07-01 Thread Olivier Lamy
Why an abstract class (abstract class AbstractMavenLifecycleParticipant) and not an interface ? Perso, I'd prefer to lifecycleListeners = container.lookupList( MavenLifecycleParticipant.class ); instead of lifecycleListeners = container.lookupList( AbstractMavenLifecycleParticipant.class ); --