asfgit merged pull request #9: [DOXIA-570] Escape links to xml based
figureGraphics image elements
URL: https://github.com/apache/maven-doxia/pull/9
This is an automated message from the Apache Git Service.
To respond to
slachiewicz removed a comment on issue #8: [DOXIA-534] Migrate logging to slf4j
and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#issuecomment-457848628
@hboutemy ping?
This is an automated
slachiewicz commented on issue #17: [DOXIA-583] Avoid over-escaping table
captions
URL: https://github.com/apache/maven-doxia/pull/17#issuecomment-496932864
looks good to me. Please squash commits related to table caption to one and
separate only related to .contains. Thx for time spent
harawata commented on issue #17: [DOXIA-583] Avoid over-escaping table captions
URL: https://github.com/apache/maven-doxia/pull/17#issuecomment-496942515
Updated. Please let me know if there is anything you want me to change.
Thanks again for your time! =)
harawata commented on issue #17: [DOXIA-583] Avoid over-escaping table captions
URL: https://github.com/apache/maven-doxia/pull/17#issuecomment-496907294
Hi again,
As I mentioned, the 'expected value' of the assertions had to be modified to
pass the tests after replacing
harawata commented on issue #17: [DOXIA-583] Avoid over-escaping table captions
URL: https://github.com/apache/maven-doxia/pull/17#issuecomment-496582698
There seems to be the same issue in Xhtml5Sink indeed.
I have already committed the fix.
By the way, I noticed that the
slachiewicz commented on issue #17: [DOXIA-583] Avoid over-escaping table
captions
URL: https://github.com/apache/maven-doxia/pull/17#issuecomment-496611474
That's exactly what I had in mind. Your changes are consistent with my local
changes.
Good catch with `indexOf` - we can
harawata commented on issue #17: [DOXIA-583] Avoid over-escaping table captions
URL: https://github.com/apache/maven-doxia/pull/17#issuecomment-496616990
Sure! =)
However, simply replacing `!= 1` with `contains` made some (?) assertions
fail, so I'll take a deeper look at the literal
michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487516043
Pushed more changes. If Jenkins is happy, I will merge.
This is an automated
asfgit closed pull request #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
asfgit merged pull request #12: DOXIA-576 Upgrade HttpComponents: httpclient to
4.5.8 and httpcore to 4.4.11
URL: https://github.com/apache/maven-doxia/pull/12
This is an automated message from the Apache Git Service.
To
minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487409020
I built the project on a different VM with a completely clean .m2 directory
and uncovered a non-checked-in part of the code.
I currently
michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487394681
I have now pushed a branch and get this error:
```
[ERROR] Failures:
[ERROR] Xhtml5BaseSinkTest.testContent:518 expected:<[]
michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487417796
Checkout my branch, and perform a cherry pick on your two subsequent
commits, that's it.
minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487419995
Code was developed on MacOS Mojave, testing above done on CentOS7:
[minfrin@localhost maven-doxia-DOXIA-575]$ rpm -q -a | grep release
minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487416967
I've been googling how to rebase a branch for the last hour, and it has me
stumped. The closest I got was an attempt that saw me trying to push
michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487421589
you can simulate this by changing {{line.separator}}.
This is an automated
michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487410626
Please rebase your latest changes against the branch I have pushed.
This is an
michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487417872
I have force-pushed an updated branch. The issue still persists:
```
[INFO]
minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487419827
Thanks for this.
I checked out a completely clean copy of the DOXIA-575 branch, then deleted
my .m2 directory and ran "mvn clean install",
michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487420147
It also fails on Jenkins:
minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487420628
Works on MacOS Mojave:
[INFO]
[INFO] Reactor Summary for Doxia
minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487423150
Can you try with the attached patch? There were some hard coded line feeds
in the test that didn't fit the pattern, this uses the EOL variable as
JLLeitschuh opened a new pull request #18: [SECURITY] Use HTTPS to resolve
dependencies in Maven Build
URL: https://github.com/apache/maven-doxia/pull/18
minfrin commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593088806
The tag is a formal part of the html5 spec as follows:
https://www.w3.org/TR/2014/REC-html5-20141028/single-page.html#the-keygen-element
elharo commented on a change in pull request #19: [DOXIA-607] Add support for
Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#discussion_r386104912
##
File path:
doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java
##
@@ -473,6
michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593093527
Branch pushed, awaiting tests...
This is an automated message from the
asfgit closed pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19
This is an automated message from the Apache Git Service.
To respond to the message, please log
michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593087315
Mozilla says this is obsolete:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/keygen
michael-o commented on a change in pull request #19: [DOXIA-607] Add support
for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#discussion_r386105109
##
File path:
doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java
##
@@ -473,6
michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593093142
Surprinsingly, the most recent version does not mention a deprecation:
https://html.spec.whatwg.org/#keygen
minfrin opened a new pull request #19: [DOXIA-607] Add support for Xhtml5
keygen tag
URL: https://github.com/apache/maven-doxia/pull/19
This will allow maven generated documentation to include a demo of the
keygen tag, as with other form elements.
elharo merged pull request #18: [SECURITY] Use HTTPS to resolve dependencies in
Maven Build
URL: https://github.com/apache/maven-doxia/pull/18
This is an automated message from the Apache Git Service.
To respond to the
elharo opened a new pull request #3:
URL: https://github.com/apache/maven-doxia-site/pull/3
@michael-o
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
elharo merged pull request #20: [MNGSITE-393] remove old Maven 1 and 2 info
URL: https://github.com/apache/maven-doxia/pull/20
This is an automated message from the Apache Git Service.
To respond to the message, please log
elharo opened a new pull request #20: [MNGSITE-393] remove old Maven 1 and 2
info
URL: https://github.com/apache/maven-doxia/pull/20
@hboutemy
This is an automated message from the Apache Git Service.
To respond to the
nhojpatrick commented on a change in pull request #158:
URL: https://github.com/apache/maven-site/pull/158#discussion_r415862987
##
File path: content/apt/guides/development/guide-maven-development.apt
##
@@ -56,6 +56,15 @@ Developing Maven
You will find many unit tests.
elharo commented on a change in pull request #158:
URL: https://github.com/apache/maven-site/pull/158#discussion_r415874640
##
File path: content/apt/guides/development/guide-maven-development.apt
##
@@ -56,6 +56,15 @@ Developing Maven
You will find many unit tests. If at
elharo opened a new pull request #6:
URL: https://github.com/apache/maven-doxia-site/pull/6
@michael-o
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
elharo opened a new pull request #5:
URL: https://github.com/apache/maven-doxia-site/pull/5
@michael-o
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
pzygielo opened a new pull request #11:
URL: https://github.com/apache/maven-artifact-transfer/pull/11
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
khmarbaise commented on pull request #11:
URL:
https://github.com/apache/maven-artifact-transfer/pull/11#issuecomment-619615368
Checking via CI...
This is an automated message from the Apache Git Service.
To respond to the
elharo opened a new pull request #4:
URL: https://github.com/apache/maven-doxia-site/pull/4
@michael-o
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
khmarbaise commented on pull request #11:
URL:
https://github.com/apache/maven-artifact-transfer/pull/11#issuecomment-619619471
Merged into master. Thanks. Good spot.
This is an automated message from the Apache Git
dzikoysk opened a new pull request #168:
URL: https://github.com/apache/maven-site/pull/168
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
michael-o commented on pull request #168:
URL: https://github.com/apache/maven-site/pull/168#issuecomment-629828239
@rfscholte Does this infringe our Maven name?
This is an automated message from the Apache Git Service.
To
dzikoysk commented on pull request #168:
URL: https://github.com/apache/maven-site/pull/168#issuecomment-629830357
Oh, good point actually 樂
`You can choose to release the modified or derived products under different
licenses, the unmodified parts of the software, however, must
slachiewicz commented on pull request #168:
URL: https://github.com/apache/maven-site/pull/168#issuecomment-629831753
Project looks active only in last month, website, hosting repo site - not
very clear about how to use it, who manages it etc.
dzikoysk commented on pull request #168:
URL: https://github.com/apache/maven-site/pull/168#issuecomment-629833688
>
> Project looks active only in last month, website, hosting repo site - not
very clear about how to use it, who manages it etc.
This is just a minimal project
dzikoysk edited a comment on pull request #168:
URL: https://github.com/apache/maven-site/pull/168#issuecomment-629833688
>
> Project looks active only in last month, website, hosting repo site - not
very clear about how to use it, who manages it etc.
This is just a minimal
rfscholte commented on pull request #168:
URL: https://github.com/apache/maven-site/pull/168#issuecomment-629865416
I do think the name conflicts. NanoMaven is clearly referring to Apache
Maven, but it is unclear that the project is not part of Apache Maven. To
prevent any possible
khmarbaise commented on pull request #168:
URL: https://github.com/apache/maven-site/pull/168#issuecomment-629832309
I opened already some issues related the usage/docs but I find that a very
interesting project. Apart from that I don't think it violates legals (I'm not
a lawyer).
The
dzikoysk edited a comment on pull request #168:
URL: https://github.com/apache/maven-site/pull/168#issuecomment-630034983
I agree that the name was referring to Apache Maven, but I don't think it
makes any confusion, it's like saying that GitHub or GitLab is a part of Git
and its
dzikoysk edited a comment on pull request #168:
URL: https://github.com/apache/maven-site/pull/168#issuecomment-630034983
I agree that the name was referring to Apache Maven, but I don't think it
makes any confusion, it's like saying that GitHub or GitLab is a part of Git
and its
dzikoysk commented on pull request #168:
URL: https://github.com/apache/maven-site/pull/168#issuecomment-630034983
I agree that the name was referring to Apache Maven, but I don't think it
makes any confusion, it's like saying that GitHub or GitLab is a part of Git
and its specification 路
dzikoysk edited a comment on pull request #168:
URL: https://github.com/apache/maven-site/pull/168#issuecomment-630034983
I agree that the name was referring to Apache Maven, but I don't think it
makes any confusion, it's like saying that GitHub or GitLab is a part of Git
and its
elharo opened a new pull request #162:
URL: https://github.com/apache/maven-site/pull/162
@slachiewicz
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
elharo opened a new pull request #161:
URL: https://github.com/apache/maven-site/pull/161
@slachiewicz
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
slachiewicz commented on pull request #161:
URL: https://github.com/apache/maven-site/pull/161#issuecomment-624080725
We can skipbook about maven 2
This is an automated message from the Apache Git Service.
To respond to the
elharo opened a new pull request #164:
URL: https://github.com/apache/maven-site/pull/164
@khmarbaise
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
slachiewicz commented on pull request #164:
URL: https://github.com/apache/maven-site/pull/164#issuecomment-626516421
For our site changes - no need to create jira every time
This is an automated message from the Apache Git
elharo merged pull request #167:
URL: https://github.com/apache/maven-site/pull/167
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r426105614
##
File path: Jenkinsfile
##
@@ -17,4 +17,4 @@
* under the License.
*/
-asfMavenTlpPlgnBuild(jdk:['7','8','11','12'], maven:['3.0.x', '3.2.x',
elharo merged pull request #169:
URL: https://github.com/apache/maven-site/pull/169
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
elharo opened a new pull request #169:
URL: https://github.com/apache/maven-site/pull/169
@rfscholte and fix some grammar
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
elharo commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r425124986
##
File path: Jenkinsfile
##
@@ -17,4 +17,4 @@
* under the License.
*/
-asfMavenTlpPlgnBuild(jdk:['7','8','11','12'], maven:['3.0.x', '3.2.x',
slachiewicz commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r425130232
##
File path: Jenkinsfile
##
@@ -17,4 +17,4 @@
* under the License.
*/
-asfMavenTlpPlgnBuild(jdk:['7','8','11','12'], maven:['3.0.x',
olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r425568135
##
File path: pom.xml
##
@@ -196,11 +196,11 @@ under the License.
3.0
-7
+8
Review comment:
we need 8 for the change so
olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r425567345
##
File path: pom.xml
##
@@ -211,6 +211,9 @@ under the License.
2.7
2.22.1
2020-03-06T20:49:49Z
+1.8
+1.8
+
rfscholte commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r425670278
##
File path: Jenkinsfile
##
@@ -17,4 +17,4 @@
* under the License.
*/
-asfMavenTlpPlgnBuild(jdk:['7','8','11','12'], maven:['3.0.x',
olamy opened a new pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mthmulders commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r425085702
##
File path: pom.xml
##
@@ -211,6 +211,9 @@ under the License.
2.7
2.22.1
2020-03-06T20:49:49Z
+1.8
+1.8
+
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to
slf4j and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993498
##
File path:
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to
slf4j and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993483
##
File path:
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to
slf4j and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993340
##
File path:
doxia-core/src/main/java/org/apache/maven/doxia/util/XmlValidator.java
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to
slf4j and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993381
##
File path:
doxia-core/src/main/java/org/apache/maven/doxia/util/XmlValidator.java
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to
slf4j and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993426
##
File path:
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to
slf4j and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993290
##
File path:
doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to
slf4j and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993269
##
File path:
doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java
elharo opened a new pull request #160:
URL: https://github.com/apache/maven-site/pull/160
@michael-o
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
elharo opened a new pull request #163:
URL: https://github.com/apache/maven-site/pull/163
@hboutemy
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
michael-o commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427583663
##
File path: pom.xml
##
@@ -196,11 +196,11 @@ under the License.
3.0
-7
+8
Review comment:
@olamy I am the
olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427588408
##
File path: src/it/projects/new-configuration/pom.xml
##
@@ -76,7 +76,7 @@ under the License.
org.apache.maven.plugins
olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427588408
##
File path: src/it/projects/new-configuration/pom.xml
##
@@ -76,7 +76,7 @@ under the License.
org.apache.maven.plugins
olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427595053
##
File path: pom.xml
##
@@ -473,28 +474,28 @@ under the License.
org.slf4j
slf4j-api
- 1.5.3
+ 1.7.29
test
olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427603657
##
File path: src/it/projects/new-configuration/pom.xml
##
@@ -76,7 +76,7 @@ under the License.
org.apache.maven.plugins
michael-o commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427603026
##
File path: src/it/projects/new-configuration/pom.xml
##
@@ -76,7 +76,7 @@ under the License.
olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427601611
##
File path: src/it/projects/new-configuration/pom.xml
##
@@ -76,7 +76,7 @@ under the License.
org.apache.maven.plugins
michael-o commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427584057
##
File path: pom.xml
##
@@ -211,6 +211,8 @@ under the License.
2.7
2.22.1
2020-03-06T20:49:49Z
+1.8
Review comment:
michael-o commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427591833
##
File path: src/it/projects/new-configuration/pom.xml
##
@@ -76,7 +76,7 @@ under the License.
olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427591510
##
File path: pom.xml
##
@@ -473,28 +474,28 @@ under the License.
org.slf4j
slf4j-api
- 1.5.3
+ 1.7.29
test
michael-o commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427591526
##
File path: pom.xml
##
@@ -196,11 +196,11 @@ under the License.
3.0
-7
+8
Review comment:
Good, let's re-merge
olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427587877
##
File path: pom.xml
##
@@ -196,11 +196,11 @@ under the License.
3.0
-7
+8
Review comment:
it's ALREADY there
elharo opened a new pull request #22:
URL: https://github.com/apache/maven-site-plugin/pull/22
@michael-o
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
elharo opened a new pull request #23:
URL: https://github.com/apache/maven-site-plugin/pull/23
@olamy
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
elharo opened a new pull request #170:
URL: https://github.com/apache/maven-site/pull/170
@slachiewicz
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
elharo commented on pull request #170:
URL: https://github.com/apache/maven-site/pull/170#issuecomment-633090938
This doesn't change that. It just removes mention of Maven 2 from this page
as part of a long effort to purge all Maven 2 from or main docs.
elharo merged pull request #170:
URL: https://github.com/apache/maven-site/pull/170
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
elharo merged pull request #23:
URL: https://github.com/apache/maven-site-plugin/pull/23
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
slachiewicz commented on pull request #24:
URL: https://github.com/apache/maven-site-plugin/pull/24#issuecomment-633230040
We already have PR #12
This is an automated message from the Apache Git Service.
To respond to the
101 - 200 of 1543 matches
Mail list logo
