[GitHub] [maven-site] michael-o commented on a change in pull request #212: [/MNGSITE-393} Remove legacy Maven 2 info

2020-10-22 Thread GitBox
michael-o commented on a change in pull request #212: URL: https://github.com/apache/maven-site/pull/212#discussion_r510405068 ## File path: content/apt/guides/mini/guide-http-settings.apt ## @@ -30,31 +30,13 @@ Advanced Configuration of the HttpClient HTTP Wagon %{toc}

[GitHub] [maven-site] michael-o commented on a change in pull request #212: [MNGSITE-393] Remove legacy Maven 2 info

2020-10-27 Thread GitBox
michael-o commented on a change in pull request #212: URL: https://github.com/apache/maven-site/pull/212#discussion_r512874854 ## File path: content/apt/guides/mini/guide-http-settings.apt ## @@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon You can

[GitHub] [maven-site] elharo commented on a change in pull request #212: [MNGSITE-393] Remove legacy Maven 2 info

2020-10-27 Thread GitBox
elharo commented on a change in pull request #212: URL: https://github.com/apache/maven-site/pull/212#discussion_r512861684 ## File path: content/apt/guides/mini/guide-http-settings.apt ## @@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon You can use

[GitHub] [maven-site] michael-o commented on a change in pull request #212: [MNGSITE-393] Remove legacy Maven 2 info

2020-10-27 Thread GitBox
michael-o commented on a change in pull request #212: URL: https://github.com/apache/maven-site/pull/212#discussion_r512876692 ## File path: content/apt/guides/mini/guide-http-settings.apt ## @@ -88,7 +88,7 @@ the target server's authentication. problems with HTTP servers and

[GitHub] [maven-site] sparsick opened a new pull request #222: MNGSITE-437 - Intellij IDEA code style setting file is outdated

2020-12-28 Thread GitBox
sparsick opened a new pull request #222: URL: https://github.com/apache/maven-site/pull/222 This setting file was created by importing checkstyle settings in idea. Then I compared it with @bmarwell self-created Intellji setting file for Maven projects and add his XML code settings.

[GitHub] [maven-site] michael-o commented on a change in pull request #191: docs: system dependencies are not always available

2020-12-28 Thread GitBox
michael-o commented on a change in pull request #191: URL: https://github.com/apache/maven-site/pull/191#discussion_r549468517 ## File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt ## @@ -174,9 +174,10 @@ Introduction to the Dependency

[GitHub] [maven-site] sparsick commented on pull request #222: MNGSITE-437 - Intellij IDEA code style setting file is outdated

2020-12-28 Thread GitBox
sparsick commented on pull request #222: URL: https://github.com/apache/maven-site/pull/222#issuecomment-751847950 @slawekjaranowski Thanks for reviewing This is an automated message from the Apache Git Service. To respond

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #222: MNGSITE-437 - Intellij IDEA code style setting file is outdated

2020-12-28 Thread GitBox
slawekjaranowski commented on a change in pull request #222: URL: https://github.com/apache/maven-site/pull/222#discussion_r549464651 ## File path: content/resources/developers/maven-idea-codestyle.xml ## @@ -216,17 +79,34 @@ under the License. + + +

[GitHub] [maven-site] elharo commented on a change in pull request #222: MNGSITE-437 - Intellij IDEA code style setting file is outdated

2020-12-28 Thread GitBox
elharo commented on a change in pull request #222: URL: https://github.com/apache/maven-site/pull/222#discussion_r549498982 ## File path: content/resources/developers/maven-idea-codestyle.xml ## @@ -16,186 +16,49 @@ KIND, either express or implied. See the License for the

[GitHub] [maven-site] mthmulders commented on pull request #222: MNGSITE-437 - Intellij IDEA code style setting file is outdated

2020-12-28 Thread GitBox
mthmulders commented on pull request #222: URL: https://github.com/apache/maven-site/pull/222#issuecomment-751827068 I don't know what the current style guidelines are, so I cannot really review. But I'm definitely +1 for maintaining it in configuration files so we can all easily conform

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #222: MNGSITE-437 - Intellij IDEA code style setting file is outdated

2020-12-28 Thread GitBox
slawekjaranowski commented on a change in pull request #222: URL: https://github.com/apache/maven-site/pull/222#discussion_r549502187 ## File path: content/resources/developers/maven-idea-codestyle.xml ## @@ -16,186 +16,49 @@ KIND, either express or implied. See the License

[GitHub] [maven-site] philsttr commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-29 Thread GitBox
philsttr commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r549926035 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,230 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-site] philsttr commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-29 Thread GitBox
philsttr commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r549927249 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,230 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-doxia] asfgit closed pull request #48: Bump xmlunit-core from 2.7.0 to 2.8.2

2020-12-30 Thread GitBox
asfgit closed pull request #48: URL: https://github.com/apache/maven-doxia/pull/48 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-doxia] asfgit closed pull request #47: Bump xmlunit-matchers from 2.7.0 to 2.8.2

2020-12-30 Thread GitBox
asfgit closed pull request #47: URL: https://github.com/apache/maven-doxia/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site] philsttr edited a comment on pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-29 Thread GitBox
philsttr edited a comment on pull request #223: URL: https://github.com/apache/maven-site/pull/223#issuecomment-752319875 @slachiewicz , since [all the other guides](https://github.com/apache/maven-site/tree/master/content/apt/guides) are in apt, I'd rather keep this one in apt for

[GitHub] [maven-site] philsttr commented on pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-29 Thread GitBox
philsttr commented on pull request #223: URL: https://github.com/apache/maven-site/pull/223#issuecomment-752319875 @slachiewicz , since all the other guides are in apt, I'd rather keep this one in apt for consistency. I'm focused on the content for now. If it is indeed important to

[GitHub] [maven-site] philsttr commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-29 Thread GitBox
philsttr commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r549926099 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,230 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-site] michael-o commented on pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-30 Thread GitBox
michael-o commented on pull request #223: URL: https://github.com/apache/maven-site/pull/223#issuecomment-752641357 > > > @slachiewicz , since [all the other guides](https://github.com/apache/maven-site/tree/master/content/apt/guides) are in apt, I'd rather keep this one in apt

[GitHub] [maven-site] philsttr commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-30 Thread GitBox
philsttr commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r550308234 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,230 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-site] philsttr commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-30 Thread GitBox
philsttr commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r550285056 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,230 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-site] michael-o commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-30 Thread GitBox
michael-o commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r550299955 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,230 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-site] philsttr commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-30 Thread GitBox
philsttr commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r550285056 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,230 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-site] philsttr opened a new pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-28 Thread GitBox
philsttr opened a new pull request #223: URL: https://github.com/apache/maven-site/pull/223 Suggested by @michael-o via https://github.com/apache/maven-deploy-plugin/pull/15#issuecomment-750933613 This is an automated

[GitHub] [maven-doxia] bertysentry opened a new pull request #49: [DOXIA-616]

2020-12-28 Thread GitBox
bertysentry opened a new pull request #49: URL: https://github.com/apache/maven-doxia/pull/49 Broad update to **doxia-module-markdown** * Properly exposed language class in fenced code blocks * Re-implemented metadata processing * Added unit tests * Added integration tests

[GitHub] [maven-artifact-transfer] slachiewicz closed pull request #21: [MSHARED-801] Add functionality to collect raw dependencies in Maven 3+

2020-12-30 Thread GitBox
slachiewicz closed pull request #21: URL: https://github.com/apache/maven-artifact-transfer/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [maven-artifact-transfer] slachiewicz commented on pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1

2020-12-30 Thread GitBox
slachiewicz commented on pull request #20: URL: https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-752469411 Do we have anywhere documented this recommendation? I think we still have on wiki to use this artefact. Also with this changes we can easily switch to new

[GitHub] [maven-artifact-transfer] rfscholte commented on pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1

2020-12-30 Thread GitBox
rfscholte commented on pull request #20: URL: https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-752440522 Please don't do this. The intention of maven-artifact-transfer is a bridge to any Aether implementation.

[GitHub] [maven-artifact-transfer] rfscholte commented on pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1

2020-12-30 Thread GitBox
rfscholte commented on pull request #20: URL: https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-752454346 Sorry @slachiewicz if you've spend a lot of time on this, but I need to close this. Once everything is using Maven 3.1+ we can simply archive

[GitHub] [maven-artifact-transfer] rfscholte closed pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1

2020-12-30 Thread GitBox
rfscholte closed pull request #20: URL: https://github.com/apache/maven-artifact-transfer/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-artifact-transfer] rfscholte commented on pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1

2020-12-30 Thread GitBox
rfscholte commented on pull request #20: URL: https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-752506877 I still consider adding the `org.apache.maven.shared.transfer.project` package a bad choice, because it introduces a dependency on Maven.

[GitHub] [maven-site] michael-o commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-30 Thread GitBox
michael-o commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r550214607 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,230 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-site] khmarbaise commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-30 Thread GitBox
khmarbaise commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r550224261 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,230 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-site] michael-o commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-30 Thread GitBox
michael-o commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r550329282 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,241 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-site] philsttr commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-30 Thread GitBox
philsttr commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r550377021 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,241 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-site] philsttr commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-30 Thread GitBox
philsttr commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r550376753 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,241 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-site] philsttr commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-30 Thread GitBox
philsttr commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r550376789 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,241 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-site] philsttr commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-30 Thread GitBox
philsttr commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r550376753 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,241 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-site] michael-o commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-31 Thread GitBox
michael-o commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r550452528 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,241 @@ + -- + Guide to Large Scale Centralized

[GitHub] [maven-site] asfgit closed pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2021-01-01 Thread GitBox
asfgit closed pull request #223: URL: https://github.com/apache/maven-site/pull/223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site-plugin] bertysentry opened a new pull request #34: [DOXIA-616]

2021-01-03 Thread GitBox
bertysentry opened a new pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34 * Fixed integration tests for **doxia-formats* wrt fenced code blocks * Upgraded to Doxia 1.10-SNAPSHOT This is an

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-03 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-753665247 @michael-o Please note: * I upgraded to Doxia 1.10-SNAPSHOT (not sure you wanted this here, just let me know) * I wondered whether we should actually remove

[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]

2021-01-03 Thread GitBox
michael-o commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-753673025 Thanks, will look into it. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]

2021-01-03 Thread GitBox
michael-o commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-753697914 I won't merge before anyway because I never depend on snapshots. This is an automated message from the

[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]

2021-01-05 Thread GitBox
elharo commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754589531 I think I agree that these should be moved. If they're only testing doxia functionality, and we can test them in doxia, then that's better. Or perhaps tests belong in both

[GitHub] [maven-doxia] elharo closed pull request #51: Bump commons-io from 2.6 to 2.8.0

2021-01-05 Thread GitBox
elharo closed pull request #51: URL: https://github.com/apache/maven-doxia/pull/51 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-05 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754944421 @hboutemy We will keep some integration tests in *maven-site-plugin* that involve *doxia-module-markdown*. I want to remove specific Doxia tests (like "quotes were

[GitHub] [maven-site-plugin] bertysentry edited a comment on pull request #34: [DOXIA-616]

2021-01-05 Thread GitBox
bertysentry edited a comment on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754944421 @hboutemy We will keep some integration tests in *maven-site-plugin* that involve *doxia-module-markdown*. I want to remove specific Doxia tests (like "quotes

[GitHub] [maven-site-plugin] hboutemy commented on pull request #34: [DOXIA-616]

2021-01-05 Thread GitBox
hboutemy commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754936536 is it causing issues, so they *need* to be removed? if you're sure you have sufficient tests nowadays in Doxia, Doxia Sitetools and skins to check that a new feature

[GitHub] [maven-doxia] bertysentry opened a new pull request #52: [DOXIA-618]

2021-01-05 Thread GitBox
bertysentry opened a new pull request #52: URL: https://github.com/apache/maven-doxia/pull/52 * doxia-module-markdown: Re-incorporated integration tests from **maven-site-plugin** * doxia-module-markdown: Merged DOXIA-616 integration tests into **general**

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-05 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754969798 Submitted PR for Doxia: https://github.com/apache/maven-doxia/pull/52 Thank you! This is an

[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]

2021-01-04 Thread GitBox
michael-o commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754273143 In my opinion they need to bemoved because we test the entire site generation, and not Doxia specific modules. @hboutemy WDYT?

[GitHub] [maven-site] mthmulders opened a new pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
mthmulders opened a new pull request #225: URL: https://github.com/apache/maven-site/pull/225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
slawekjaranowski commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553961399 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -100,9 +100,11 @@ Introduction to Build Profiles profile

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
slawekjaranowski commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553964597 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
slawekjaranowski commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553964597 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal

[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
mthmulders commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553966399 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-doxia] elharo closed pull request #53: rollback Java 7 breaking change

2021-01-08 Thread GitBox
elharo closed pull request #53: URL: https://github.com/apache/maven-doxia/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
mthmulders commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553965389 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -100,9 +100,11 @@ Introduction to Build Profiles profile IDs to

[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
michael-o commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554041608 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] MartinKanters commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
MartinKanters commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554058099 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] pzygielo commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
pzygielo commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554014876 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
michael-o commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553996067 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
michael-o commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554064780 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] MartinKanters commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
MartinKanters commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554007128 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
mthmulders commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554024978 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] pzygielo commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-09 Thread GitBox
pzygielo commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554014876 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-09 Thread GitBox
slawekjaranowski commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553961399 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -100,9 +100,11 @@ Introduction to Build Profiles profile

[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-09 Thread GitBox
michael-o commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553996067 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-09 Thread GitBox
mthmulders commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553965389 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -100,9 +100,11 @@ Introduction to Build Profiles profile IDs to

[GitHub] [maven-doxia] elharo closed pull request #53: rollback Java 7 breaking change

2021-01-09 Thread GitBox
elharo closed pull request #53: URL: https://github.com/apache/maven-doxia/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site] MartinKanters commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-09 Thread GitBox
MartinKanters commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554007128 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] rfscholte commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-10 Thread GitBox
rfscholte commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554558015 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site-plugin] strkkk opened a new pull request #35: Fix script injection example in docs

2021-01-15 Thread GitBox
strkkk opened a new pull request #35: URL: https://github.com/apache/maven-site-plugin/pull/35 Example is not good since self-closing tag wont work, so it is changed to correct example. See

[GitHub] [maven-site-plugin] michael-o merged pull request #35: Fix script injection example in docs

2021-01-15 Thread GitBox
michael-o merged pull request #35: URL: https://github.com/apache/maven-site-plugin/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-doxia] dependabot[bot] opened a new pull request #55: Bump fop from 2.5 to 2.6

2021-01-20 Thread GitBox
dependabot[bot] opened a new pull request #55: URL: https://github.com/apache/maven-doxia/pull/55 Bumps fop from 2.5 to 2.6. [![Dependabot compatibility

[GitHub] [maven-doxia] elharo merged pull request #55: Bump fop from 2.5 to 2.6

2021-01-21 Thread GitBox
elharo merged pull request #55: URL: https://github.com/apache/maven-doxia/pull/55 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site-plugin] bertysentry edited a comment on pull request #34: [DOXIA-616]

2021-01-14 Thread GitBox
bertysentry edited a comment on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-760137856 More build failures: Connection timeout with www.w3.org, which is totally unrelated to this PR. Edit: Things run smoothly on my fork. See

[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]

2021-01-14 Thread GitBox
elharo commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-760160299 We really should resolve the CI issues before proceeding with this or any other changes. This is an

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-14 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-760182619 @elharo IMO there is no need to wait to merge this PR. This PR ensures the integration tests won't break when upgrading to Doxia 1.10. The integration tests

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-14 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-760137856 More build failures: Connection timeout with www.w3.org, which is totally unrelated to this PR. This

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-14 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-760124289 Oh, last update: I reverted Doxia version to **1.9.1**. MSITE integration tests will pass with both 1.9.1 and 1.10 (no more checks on specific Doxia formatting

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-14 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-760381651 @elharo Any idea on how to retrieve the **build.log** files from GitHub Actions/Workflows? I must be missing something here, but I can't find any link to any

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-25 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766418215 @michael-o @hboutemy @elharo Friendly reminder that this PR is still waiting, and its content is not going to change with regards to the failed builds, which are

[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]

2021-01-25 Thread GitBox
michael-o commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766434017 I won't be able to review before mid Feb due to circumstances here. This is an automated message from

[GitHub] [maven-site-plugin] slachiewicz commented on pull request #34: [DOXIA-616]

2021-01-25 Thread GitBox
slachiewicz commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766441620 I'll look at it tomorrow This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-doxia] elharo merged pull request #55: Bump fop from 2.5 to 2.6

2021-01-22 Thread GitBox
elharo merged pull request #55: URL: https://github.com/apache/maven-doxia/pull/55 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-archiver] mabrarov commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

2021-01-19 Thread GitBox
mabrarov commented on pull request #10: URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-763180478 Is this PR still actual? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
elharo commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762430570 That one wasn't merged by me. :-) This is an automated message from the Apache Git Service. To respond to

[GitHub] [maven-archiver] michael-o commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

2021-01-20 Thread GitBox
michael-o commented on pull request #10: URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-763471268 Likely, @hboutemy WDYT? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-archiver] elharo closed pull request #10: [MSHARED-955] make parseOutputTimestamp static

2021-01-20 Thread GitBox
elharo closed pull request #10: URL: https://github.com/apache/maven-archiver/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-13 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-759814944 Okay, PR has been updated as below: * Removed Doxia-specific integration tests * Added integration tests on the various document formats * Integration tests on

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762494128 One recurring error is: ```log Error: |[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.10.0-SNAPSHOT:site (default-cli) on

[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
elharo commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762208210 Some though not all of the errors seem related to this: : |[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.10.0-SNAPSHOT:site

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762209071 This was just a temporary network issue of GitHub Actions. If you re-run the workflow, you won't get these errors.

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762210778 Also, PR #35 just got merged to *master* 3 days ago, with the same CI failures. This is an automated

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762187924 @hboutemy @michael-o @elharo Will you have a chance to review these changes? This ensures the **maven-site-plugin** integration tests don't break when upgrading from

[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
elharo commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762197773 Before this can move further, someone needs to debug and fix the CI failures. That's likely not caused by this PR, but checking in when the CI is broken is never a good

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762198733 @elharo We cannot access the integration test logs, how are we going to fix this? This is an

[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
elharo commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762205983 It might need someone who has more permissions on the project. I'm not sure. This is an automated message

<    2   3   4   5   6   7   8   9   10   11   >