Re: Review Request 15200: refactor mesos-ps to display allocated cpu and used/allocated memory

2013-11-07 Thread Shingo Omura
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15200/ --- (Updated Nov. 8, 2013, 6:54 a.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 15200: refactor mesos-ps to display used/allocated cpu and memory

2013-11-07 Thread Shingo Omura
> On Nov. 4, 2013, 6:18 p.m., Ben Mahler wrote: > > src/cli/mesos-ps, line 93 > > > > > > usage.json is now deprecated in favor of statistics.json > > > > statistics.json returns snapshot information, which mea

Re: Review Request 15200: refactor mesos-ps to display used/allocated cpu and memory

2013-11-07 Thread Shingo Omura
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15200/ --- (Updated Nov. 8, 2013, 6:53 a.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 15215: Support displaying some charts in mesos webui

2013-11-07 Thread Shingo Omura
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15215/ --- (Updated Nov. 8, 2013, 5:16 a.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 15336: Refactored mesos-tail to use helpers from cli.py.

2013-11-07 Thread Shingo Omura
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15336/ --- (Updated Nov. 8, 2013, 4:14 a.m.) Review request for mesos, Benjamin Hindman, B

Review Request 15336: Refactored mesos-tail to use helpers from cli.py.

2013-11-07 Thread Shingo Omura
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15336/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, Du Li, and Vinod Kone.

Re: Review Request 15336: Refactored mesos-tail to use helpers from cli.py.

2013-11-07 Thread Shingo Omura
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15336/ --- (Updated Nov. 8, 2013, 4:11 a.m.) Review request for mesos, Benjamin Hindman, B

[jira] [Commented] (MESOS-726) src/Makefile.am:55: `pkglibexecdir' is not a legitimate directory for `SCRIPTS'

2013-11-07 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816973#comment-13816973 ] Niklas Quarfot Nielsen commented on MESOS-726: -- Vinson, can we close this tick

Review Request 15333: Added Owned::share().

2013-11-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15333/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Reposit

Re: Review Request 15301: Refactored mesos-cat to use helpers from cli.py.

2013-11-07 Thread Benjamin Hindman
> On Nov. 7, 2013, 7:11 p.m., Ben Mahler wrote: > > src/cli/mesos-cat, line 87 > > > > > > http.get(...) would seem more intuitive? Great, done. - Benjamin --

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

2013-11-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15198/#review28477 --- Ship it! Thanks Ross! - Ben Mahler On Nov. 7, 2013, 11:31 p.m.,

Re: Review Request 15300: Created 'usage' and moved 'get' helper to cli.py.

2013-11-07 Thread Benjamin Hindman
> On Nov. 7, 2013, 7:05 p.m., Ben Mahler wrote: > > src/cli/python/mesos/cli.py, line 4 > > > > > > Should we just do the newline printing here and avoid the callers > > having to always add a \n? Sounds good to me, up

Re: Review Request 15319: Propagate discarding in process::dispatch.

2013-11-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15319/#review28471 --- 3rdparty/libprocess/include/process/dispatch.hpp

[jira] [Commented] (MESOS-798) ExamplesTest.PythonFramework failing

2013-11-07 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816810#comment-13816810 ] Niklas Quarfot Nielsen commented on MESOS-798: -- @Bernardo, check out https://i

[jira] [Commented] (MESOS-799) Mesos python egg is faulty on OS X Mavericks

2013-11-07 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816808#comment-13816808 ] Niklas Quarfot Nielsen commented on MESOS-799: -- The issue was solved in distut

Re: Review Request 15215: Support displaying some charts in mesos webui

2013-11-07 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15215/#review28465 --- src/webui/master/static/js/controllers.js

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

2013-11-07 Thread Ross Allen
> On Nov. 4, 2013, 6:38 p.m., Ben Mahler wrote: > > src/webui/master/static/js/services.js, line 6 > > > > > > Can we call this service alert? Since that seems to be the standard > > terminology for this kind of ui comp

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

2013-11-07 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15198/ --- (Updated Nov. 7, 2013, 11:31 p.m.) Review request for mesos and Ben Mahler. B

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

2013-11-07 Thread Ross Allen
> On Nov. 5, 2013, 10:08 p.m., Ben Mahler wrote: > > src/webui/master/static/js/services.js, lines 23-27 > > > > > > Rather than a String or an Object, what if we only take an Object and > > allow the omission of title

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

2013-11-07 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15198/ --- (Updated Nov. 7, 2013, 11:28 p.m.) Review request for mesos. Bugs: MESOS-802

Re: Review Request 15215: Support displaying some charts in mesos webui

2013-11-07 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15215/#review28460 --- src/webui/master/static/home.html

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

2013-11-07 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15198/ --- (Updated Nov. 7, 2013, 10:58 p.m.) Review request for mesos. Bugs: MESOS-802

Re: Review Request 15319: Propagate discarding in process::dispatch.

2013-11-07 Thread Ben Mahler
> On Nov. 7, 2013, 9:45 p.m., Ben Mahler wrote: > > I think these are the semantics one would expect, since I would expect > > these two operations to behave the same: > > > > Future f = p->foo(); > > f.discard(); // Discards the future returned by foo(). > > > > Future f = dispatch(p, P::foo)

Re: Review Request 15319: Propagate discarding in process::dispatch.

2013-11-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15319/#review28452 --- I think these are the semantics one would expect, since I would expe

Re: Review Request 15143: Implemented the stateful Master.

2013-11-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15143/ --- (Updated Nov. 7, 2013, 8:57 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 15226: Added a performance test for the Registrar.

2013-11-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15226/ --- (Updated Nov. 7, 2013, 8:58 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 15114: Small cleanups of the Master code.

2013-11-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15114/#review28427 --- src/master/master.cpp

Review Request 15319: Propagate discarding in process::dispatch.

2013-11-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15319/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Reposit

[jira] [Commented] (MESOS-798) ExamplesTest.PythonFramework failing

2013-11-07 Thread Bernardo Gomez Palacio (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816302#comment-13816302 ] Bernardo Gomez Palacio commented on MESOS-798: -- Failing on my MBP. Environmen

Re: Review Request 15301: Refactored mesos-cat to use helpers from cli.py.

2013-11-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15301/#review28413 --- Ship it! src/cli/mesos-cat

Re: Review Request 15300: Created 'usage' and moved 'get' helper to cli.py.

2013-11-07 Thread Shingo Omura
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15300/#review28404 --- Ship it! Ship It! - Shingo Omura On Nov. 7, 2013, 8:42 a.m., Ben

Re: Review Request 15299: Included mesos-cat and mesos-tail in installation.

2013-11-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15299/#review28409 --- Ship it! Ship It! - Ben Mahler On Nov. 7, 2013, 8:42 a.m., Benja

Re: Review Request 15300: Created 'usage' and moved 'get' helper to cli.py.

2013-11-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15300/#review28403 --- Ship it! src/cli/python/mesos/cli.py

Re: Review Request 15301: Refactored mesos-cat to use helpers from cli.py.

2013-11-07 Thread Shingo Omura
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15301/#review28407 --- Ship it! Ship It! - Shingo Omura On Nov. 7, 2013, 8:42 a.m., Ben

Re: Review Request 15299: Included mesos-cat and mesos-tail in installation.

2013-11-07 Thread Shingo Omura
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15299/#review28405 --- Ship it! Ship It! - Shingo Omura On Nov. 7, 2013, 8:42 a.m., Ben

Re: Review Request 15302: Revised os::realpath to return Result for when path does not exist.

2013-11-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15302/#review28402 --- Ship it! Thanks for fixing this! - Ben Mahler On Nov. 7, 2013, 8

Re: Review Request 15100: Added slave retrieval in the Registrar.

2013-11-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15100/#review28386 --- please attach the bug. src/master/registrar.hpp

Re: Review Request 15099: Cleaned up the Registrar.

2013-11-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15099/#review28384 --- src/master/registrar.cpp

Review Request 15301: Refactored mesos-cat to use helpers from cli.py.

2013-11-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15301/ --- Review request for mesos, Ben Mahler, Du Li, Shingo Omura, and Vinod Kone. Repo

Re: Review Request 15299: Included mesos-cat and mesos-tail in installation.

2013-11-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15299/ --- (Updated Nov. 7, 2013, 8:42 a.m.) Review request for mesos, Ben Mahler, Du Li,

Review Request 15300: Created 'usage' and moved 'get' helper to cli.py.

2013-11-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15300/ --- Review request for mesos, Ben Mahler, Du Li, Shingo Omura, and Vinod Kone. Repo

Review Request 15299: Included mesos-cat and mesos-tail in installation.

2013-11-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15299/ --- Review request for mesos, Ben Mahler, Shingo Omura, and Vinod Kone. Repository:

Review Request 15302: Revised os::realpath to return Result for when path does not exist.

2013-11-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15302/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description --