Re: Review Request 19575: http auth for webui supported through libprocess

2014-03-23 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19575/ --- (Updated March 24, 2014, 6:40 a.m.) Review request for mesos, Adam B and Benjam

Review Request 19575: http auth for webui supported through libprocess

2014-03-23 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19575/ --- Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1131 htt

Re: Review Request 19383: Implemented the Registry-backed Master.

2014-03-23 Thread Ben Mahler
> On March 20, 2014, 9:21 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 421 > > > > > > Why cache instead of a circular buffer? > > Ben Mahler wrote: > What's the issue here? > > Circular buffer

[jira] [Created] (MESOS-1140) During slave recovery store completed frameworks, tasks, etc

2014-03-23 Thread Benjamin Hindman (JIRA)
Benjamin Hindman created MESOS-1140: --- Summary: During slave recovery store completed frameworks, tasks, etc Key: MESOS-1140 URL: https://issues.apache.org/jira/browse/MESOS-1140 Project: Mesos

[jira] [Created] (MESOS-1139) Task validation in scheduler driver should be done in the master

2014-03-23 Thread Benjamin Hindman (JIRA)
Benjamin Hindman created MESOS-1139: --- Summary: Task validation in scheduler driver should be done in the master Key: MESOS-1139 URL: https://issues.apache.org/jira/browse/MESOS-1139 Project: Mesos

[jira] [Created] (MESOS-1138) Collect more statistics per container

2014-03-23 Thread Benjamin Hindman (JIRA)
Benjamin Hindman created MESOS-1138: --- Summary: Collect more statistics per container Key: MESOS-1138 URL: https://issues.apache.org/jira/browse/MESOS-1138 Project: Mesos Issue Type: Improve

Re: Review Request 19361: Add support to look up thread ids using /proc on Linux

2014-03-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19361/#review38266 --- Patch looks great! Reviews applied: [19361] All tests passed. - M

[jira] [Resolved] (MESOS-1136) Add better exception handling in JNI code

2014-03-23 Thread Benjamin Hindman (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Hindman resolved MESOS-1136. - Resolution: Duplicate > Add better exception handling in JNI code > -

[jira] [Resolved] (MESOS-983) Expose log coordinator demotion.

2014-03-23 Thread Benjamin Hindman (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Hindman resolved MESOS-983. Resolution: Fixed Fix Version/s: 0.19.0 > Expose log coordinator demotion. >

[jira] [Resolved] (MESOS-873) Crash in os::killtree on Mavericks

2014-03-23 Thread Benjamin Hindman (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Hindman resolved MESOS-873. Resolution: Fixed Fix Version/s: 0.19.0 Assignee: Benjamin Hindman > Crash i

Re: Review Request 18957: Added --disable-bundled flag as well as the first override implementation --with-leveldb[=DIR]

2014-03-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/#review38265 --- Patch looks great! Reviews applied: [18957] All tests passed. - M

Re: Review Request 18601: Added command line argument option in mesos-executor.

2014-03-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18601/#review38264 --- Patch looks great! Reviews applied: [18601] All tests passed. - M

Re: Review Request 18957: Added --disable-bundled flag as well as the first override implementation --with-leveldb[=DIR]

2014-03-23 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/ --- (Updated March 23, 2014, 11:18 p.m.) Review request for mesos and Benjamin Hind

Re: Review Request 18957: Added --disable-bundled flag as well as the first override implementation --with-leveldb[=DIR]

2014-03-23 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/ --- (Updated March 23, 2014, 11:17 p.m.) Review request for mesos and Benjamin Hind

Re: Review Request 18957: Added --disable-bundled flag as well as the first override implementation --with-leveldb[=DIR]

2014-03-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/#review38260 --- Bad patch! Reviews applied: [18957] Failed command: ./configure E

Re: Review Request 18947: Fixed Python-Egg to adhere to --without-included-zookeeper

2014-03-23 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18947/ --- (Updated March 23, 2014, 9:36 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 18957: Added --disable-bundled flag as well as the first override implementation --with-leveldb[=DIR]

2014-03-23 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/ --- (Updated March 23, 2014, 9:29 p.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 18957: Added --enable-proper flag as well as its first implementation --with-leveldb[=DIR]

2014-03-23 Thread Till Toenshoff
> On March 20, 2014, 4:46 p.m., Benjamin Hindman wrote: > > Just so I understand clearly, do we not want to allow people to try and use > > system installed libraries but fall back on what's bundled otherwise? > > Consider someone who has leveldb installed with snappy, so they'd like to > > us

Re: Review Request 18957: Added --disable-bundled flag as well as the first override implementation --with-leveldb[=DIR]

2014-03-23 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/ --- (Updated March 23, 2014, 9:28 p.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 18957: Added --enable-proper flag as well as its first implementation --with-leveldb[=DIR]

2014-03-23 Thread Till Toenshoff
> On March 17, 2014, 4:07 p.m., Timothy St. Clair wrote: > > configure.ac, line 250 > > > > > > Given that this block has the potential for becoming large it may be > > easier to read using 'if test' vs. AS_IF around

Re: Review Request 18957: Added --enable-proper flag as well as its first implementation --with-leveldb[=DIR]

2014-03-23 Thread Till Toenshoff
> On March 22, 2014, 8:14 a.m., Adam B wrote: > > configure.ac, line 250 > > > > > > +1 on making this easier to read. Just decoded it and here's my > > pseudocode interpretation: > > if (enable-proper) { > >