Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #1999

2014-07-17 Thread Apache Jenkins Server
See Changes: [vinodkone] Disabled HealthCheckTest.ConsecutiveFailures flaky test. -- [...truncated 100128 lines...] I0718 05:48:30.543437 31876 hierarchical_allocat

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #221

2014-07-17 Thread Apache Jenkins Server
See

Build failed in Jenkins: mesos-reviewbot #1182

2014-07-17 Thread Apache Jenkins Server
See Changes: [vinodkone] Disabled HealthCheckTest.ConsecutiveFailures flaky test. -- [...truncated 256 lines...] 3rdparty/Makefile.am:132: warning: source file '$(STOUT)/tests/set_tests.cpp' is

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2255

2014-07-17 Thread Apache Jenkins Server
See Changes: [vinodkone] Disabled HealthCheckTest.ConsecutiveFailures flaky test. -- [...truncated 212 lines...] 3rdparty/Makefile.am:132: warning: source file

Re: Review Request 23661: Unified status update logging in the master.

2014-07-17 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23661/ --- (Updated July 18, 2014, 1:51 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23661: Unified status update logging in the master.

2014-07-17 Thread Ben Mahler
> On July 18, 2014, 12:06 a.m., Vinod Kone wrote: > > src/master/master.cpp, lines 3164-3167 > > > > > > It is a bit confusing to know when to call this overload vs the other. > > Why not just have the above one? I'

Re: Review Request 23661: Unified status update logging in the master.

2014-07-17 Thread Ben Mahler
> On July 17, 2014, 11:52 p.m., Dominic Hamon wrote: > > src/master/master.hpp, line 365 > > > > > > should this be private? Yeah many of these Master methods should probably be private, but I'll defer on moving them

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #1997

2014-07-17 Thread Apache Jenkins Server
See

Build failed in Jenkins: Mesos-Ubuntu-distcheck #220

2014-07-17 Thread Apache Jenkins Server
See Changes: [yujie.jay] Fixed a bug in port mapping metrics. -- [...truncated 60223 lines...] I0718 01:27:51.216940 1336 auxprop.cpp:103] Skipping auxiliary property '*userPassword' sinc

Build failed in Jenkins: mesos-reviewbot #1181

2014-07-17 Thread Apache Jenkins Server
See Changes: [yujie.jay] Allowed the port mapping isolator to tolerate early child process -- [...truncated 255 lines...] 3rdparty/Makefile.am:132: warning: source file '$(STOUT)/tests/set_tests.

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2254

2014-07-17 Thread Apache Jenkins Server
See Changes: [yujie.jay] Allowed the port mapping isolator to tolerate early child process -- [...truncated 212 lines...] 3rdparty/Makefile.am:132: warning: sou

Re: Review Request 23659: Allowed the port mapping isolator to tolerate early child process termination.

2014-07-17 Thread Jie Yu
> On July 17, 2014, 9:08 p.m., Chi Zhang wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 2014 > > > > > > not sure if this is a good place to use VLOG instead? I still prefer a LOG(INFO) a

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2253

2014-07-17 Thread Vinod Kone
+Jake This box (ubuntu-5 ) doesn't seem to have sasl library installed? On Thu, Jul 17, 2014 at 4:59 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See < > https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HO

Re: Review Request 23661: Unified status update logging in the master.

2014-07-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23661/#review48090 --- src/master/master.cpp

Build failed in Jenkins: mesos-reviewbot #1180

2014-07-17 Thread Apache Jenkins Server
See Changes: [yujie.jay] Fixed a bug in port mapping metrics. -- [...truncated 255 lines...] 3rdparty/Makefile.am:132: warning: source file '$(STOUT)/tests/set_tests.cpp' is in a subdirectory, 3

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2253

2014-07-17 Thread Apache Jenkins Server
See Changes: [yujie.jay] Fixed a bug in port mapping metrics. -- [...truncated 212 lines...] 3rdparty/Makefile.am:132: warning: source file '$(STOUT)/tests/some

Re: Review Request 23661: Unified status update logging in the master.

2014-07-17 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23661/#review48088 --- src/master/master.hpp

Re: Review Request 23661: Unified status update logging in the master.

2014-07-17 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23661/ --- (Updated July 17, 2014, 11:49 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 23661: Unified status update logging in the master.

2014-07-17 Thread Ben Mahler
> On July 17, 2014, 9:29 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4221 > > > > > > How about > > > > "Sending status update " << update << " as the slave " << > > slaveInfo.id() << " (" << sla

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2252

2014-07-17 Thread Apache Jenkins Server
d ping from slave-observer(2)@67.195.138.8:44024 I0717 22:52:13.715895 15154 hierarchical_allocator_process.hpp:750] Offering cpus(*):8; mem(*):6961; disk(*):23038; ports(*):[31000-32000] on slave 20140717-210712-143311683-44024-15124-0 to framework 20140717-210712-143311683-44024-15124- I0717

Re: Review Request 23453: Unbundle glog

2014-07-17 Thread Vinod Kone
> On July 17, 2014, 9:38 p.m., Vinod Kone wrote: > > configure.ac, line 286 > > > > > > would this macro work for user provided glog location? nm. realized you set the CPP flags above and i'm assuming that should do t

Re: Review Request 23661: Added a log line for status updates sent for removed slaves.

2014-07-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23661/#review48078 --- Patch looks great! Reviews applied: [23661] All tests passed. - M

Re: Review Request 23535: Add support for installing libprocess headers.

2014-07-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23535/ --- (Updated July 17, 2014, 10:19 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 23563: Added support for installing stout headers.

2014-07-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23563/ --- (Updated July 17, 2014, 10:18 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 23535: Add support for installing libprocess headers.

2014-07-17 Thread Vinod Kone
> On July 16, 2014, 8:24 p.m., Timothy St. Clair wrote: > > 3rdparty/libprocess/Makefile.am, line 79 > > > > > > Should probably verify that removing from sources doesn't break > > incremental builds. > > > >

Re: Review Request 23561: Fixed the checkpoint configuration bug in example frameworks.

2014-07-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23561/#review48073 --- src/examples/low_level_scheduler_pthread.cpp

Re: Review Request 23544: Fixed a bug in port mapping metrics.

2014-07-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23544/#review48072 --- Ship it! Ship It! - Vinod Kone On July 16, 2014, 6:09 a.m., Jie

Re: Review Request 23453: Unbundle glog

2014-07-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23453/#review48065 --- 3rdparty/libprocess/configure.ac

Re: Review Request 23659: Allowed the port mapping isolator to tolerate early child process termination.

2014-07-17 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23659/#review48066 --- Ship it! src/slave/containerizer/isolators/network/port_mapping.cp

Re: Review Request 22796: Add timeout to rescind unused offers

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22796/ --- (Updated July 17, 2014, 9:30 p.m.) Review request for mesos, Adam B and Niklas

Re: Review Request 23661: Added a log line for status updates sent for removed slaves.

2014-07-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23661/#review48063 --- Ship it! src/master/master.cpp

Review Request 23661: Added a log line for status updates sent for removed slaves.

2014-07-17 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23661/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description --

Re: Review Request 23086: Update system check to unbundle protobuf

2014-07-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/#review48049 --- configure.ac

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #1996

2014-07-17 Thread Apache Jenkins Server
o receive offers for role '*' I0717 21:10:42.180656 15270 log.cpp:680] Attempting to append 327 bytes to the log I0717 21:10:42.180666 15274 master.cpp:1306] Registering framework 20140717-211042-160088899-57566-15248- at scheduler-9077254c-f9d5-45ed-9dce-c29c764629a1@67.195.138.9:5

Re: Review Request 23659: Allowed the port mapping isolator to tolerate early child process termination.

2014-07-17 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23659/#review48057 --- src/slave/containerizer/isolators/network/port_mapping.cpp

Re: Review Request 23659: Allowed the port mapping isolator to tolerate early child process termination.

2014-07-17 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23659/#review48055 --- src/slave/containerizer/isolators/network/port_mapping.cpp

Jenkins build is back to normal : mesos-reviewbot #1177

2014-07-17 Thread Apache Jenkins Server
See

Re: Review Request 23640: Revised comments to reflect DockerContainerizer implementation.

2014-07-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23640/#review48051 --- Bad patch! Reviews applied: [23637] Failed command: git apply --in

Review Request 23659: Allowed the port mapping isolator to tolerate early child process termination.

2014-07-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23659/ --- Review request for mesos, Chi Zhang, Ian Downes, and Vinod Kone. Bugs: MESOS-16

Re: Review Request 23637: Refactored some Docker tests to be more generic.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23637/ --- (Updated July 17, 2014, 8:30 p.m.) Review request for mesos, Ian Downes, Jie Yu

Build failed in Jenkins: mesos-reviewbot #1176

2014-07-17 Thread Apache Jenkins Server
See Changes: [vinodkone] Disabled flaky low level scheduler tests. -- [...truncated 7519 lines...] apply_reviews(api(review_url)["review_request"], applied) File "./support/verify-reviews.p

Re: Review Request 22796: Add timeout to rescind unused offers

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22796/ --- (Updated July 17, 2014, 8:08 p.m.) Review request for mesos, Adam B and Niklas

Re: Review Request 23491: Modify validate Docker to call 'info' instead.

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23491/ --- (Updated July 17, 2014, 7:52 p.m.) Review request for mesos, Benjamin Hindman a

Build failed in Jenkins: mesos-reviewbot #1175

2014-07-17 Thread Apache Jenkins Server
See -- [...truncated 7523 lines...] apply_reviews(api(review_url)["review_request"], applied) File "./support/verify-reviews.py", line 80, in apply_reviews apply_reviews(api(review_url)["review_

Re: Review Request 23506: Refactored docker::usage() and docker::run().

2014-07-17 Thread Yifan Gu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23506/ --- (Updated July 17, 2014, 7:48 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23505: Moved cpu/mem constants from cpushare.cpp/mem.cpp to cpushare.hpp/mem.hpp

2014-07-17 Thread Yifan Gu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23505/ --- (Updated July 17, 2014, 7:47 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23502: Added docker::killAndRm() to performs 'docker kill && docker rm (-f)'

2014-07-17 Thread Yifan Gu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23502/ --- (Updated July 17, 2014, 7:46 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23503: Refactored docker::ps(), added 'prefix' option to inspect only interested containers.

2014-07-17 Thread Yifan Gu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23503/ --- (Updated July 17, 2014, 7:46 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23503: Refactored docker::ps(), added 'prefix' option to inspect only interested containers.

2014-07-17 Thread Yifan Gu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23503/ --- (Updated July 17, 2014, 7:44 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23501: Added docker_tests to test the docker abstraction.

2014-07-17 Thread Yifan Gu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23501/ --- (Updated July 17, 2014, 7:43 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23499: Added license in docker/docker.cpp.

2014-07-17 Thread Yifan Gu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23499/ --- (Updated July 17, 2014, 7:43 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23497: Added usage() for the docker containerizer.

2014-07-17 Thread Yifan Gu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23497/ --- (Updated July 17, 2014, 7:41 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23496: Changed docker.kill() to docker.rm().

2014-07-17 Thread Yifan Gu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23496/ --- (Updated July 17, 2014, 7:40 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23495: Added rm() in docker.hpp/cpp to enable users remove containers.

2014-07-17 Thread Yifan Gu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23495/ --- (Updated July 17, 2014, 7:39 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23494: Added Docker::ps() "all" option.

2014-07-17 Thread Yifan Gu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23494/ --- (Updated July 17, 2014, 7:37 p.m.) Review request for mesos, Benjamin Hindman a

Re: flaky tests

2014-07-17 Thread Jie Yu
+1 for doing MESOS-1559 On Thu, Jul 17, 2014 at 12:31 PM, Vinod Kone wrote: > Hi folks, > > Sorry for the increased noised in flaky tests the past few days. We are > still trying to find the root cause. As part of the effort we are going to > do https://issues.apache.org/jira/browse/MESOS-1559.

Re: Review Request 23493: Added pid() in docker/docker.cpp to get the pid of the container.

2014-07-17 Thread Yifan Gu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23493/ --- (Updated July 17, 2014, 7:36 p.m.) Review request for mesos, Benjamin Hindman a

flaky tests

2014-07-17 Thread Vinod Kone
Hi folks, Sorry for the increased noised in flaky tests the past few days. We are still trying to find the root cause. As part of the effort we are going to do https://issues.apache.org/jira/browse/MESOS-1559. Also, I'm going to disable the newly added low level scheduler tests as they seem to be

Re: Review Request 23636: Improved failure handling of DockerContainerizer.

2014-07-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23636/#review48039 --- Bad patch! Reviews applied: [23506] Failed command: git apply --in

Re: Review Request 23629: Be more mock friendly in MockDockerContainerizer.

2014-07-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23629/#review48038 --- Bad patch! Reviews applied: [23497] Failed command: git apply --in

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2251

2014-07-17 Thread Apache Jenkins Server
See

Re: Review Request 23511: Await container termination in docker kill test

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23511/ --- (Updated July 17, 2014, 6:59 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23510: Fix docker usage unit test

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23510/ --- (Updated July 17, 2014, 6:58 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23508: Added a DockerContainerizer::recover test.

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23508/ --- (Updated July 17, 2014, 6:51 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23491: Modify validate Docker to call 'info' instead.

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23491/ --- (Updated July 17, 2014, 6:51 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23490: Add environment test for Docker.

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23490/ --- (Updated July 17, 2014, 6:49 p.m.) Review request for mesos, Benjamin Hindman a

Review Request 23627: Refactored Docker::Container::pid() to return an Option.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23627/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23619: Added a 'Docker' abstraction.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23619/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23635: Modified Docker example framework to use busybox.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23635/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23629: Be more mock friendly in MockDockerContainerizer.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23629/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23633: Used the new cgroups helpers when updating Docker container resources.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23633/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23631: Used unsigned constants for older compilers.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23631/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23640: Revised comments to reflect DockerContainerizer implementation.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23640/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23637: Refactored some Docker tests to be more generic.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23637/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23632: Added a helper for determining the cgroup of particular pid.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23632/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23639: Checked for mounted 'cpu' cgroups subsystem in Docker::validate.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23639/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23636: Improved failure handling of DockerContainerizer.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23636/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23634: Moved WSTRINGIFY out of a namespace.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23634/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23628: Made Docker::ps/rm default arguments match CLI defaults.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23628/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23638: Added DockerContainerizer kill task test.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23638/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23626: Renamed variable to be more accurate.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23626/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23630: Added an example Docker framework for testing.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23630/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23620: Added a Docker containerizer.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23620/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23625: Exposed and used the Docker container name prefix.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23625/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23623: Integrated DockerContainerizer.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23623/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23624: Used 'flags.docker' in tests.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23624/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Review Request 23622: Bug fixes and cleanups in Docker abstraction.

2014-07-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23622/ --- Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-152

Re: Review Request 23513: Implemented launching executors in DockerContainerizer.

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23513/ --- (Updated July 17, 2014, 6:21 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23512: Update docker uri to expect 3 slashes in prefix

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23512/ --- (Updated July 17, 2014, 6:20 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23511: Await container termination in docker kill test

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23511/ --- (Updated July 17, 2014, 6:20 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23510: Fix docker usage unit test

2014-07-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23510/#review48031 --- Bad patch! Reviews applied: [23490] Failed command: git apply --in

Re: Review Request 23510: Fix docker usage unit test

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23510/ --- (Updated July 17, 2014, 6:17 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23508: Added a DockerContainerizer::recover test.

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23508/ --- (Updated July 17, 2014, 6:17 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23507: Added Docker unit test, Docker flag and fixs

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23507/ --- (Updated July 17, 2014, 6:17 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23491: Modify validate Docker to call 'info' instead.

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23491/ --- (Updated July 17, 2014, 6:16 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23649: Implemented DockerContainerizer::update.

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23649/ --- (Updated July 17, 2014, 6:03 p.m.) Review request for mesos, Benjamin Hindman a

Review Request 23649: Implemented DockerContainerizer::update.

2014-07-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23649/ --- Review request for mesos, Benjamin Hindman and Yifan Gu. Repository: mesos-git

Re: Review Request 23507: Added Docker unit test, Docker flag and fixs

2014-07-17 Thread Benjamin Hindman
Tim: yes, that's true. Drat. :-( Unless anyone else has another suggestion for the review bot, Tim and Yifan, please update your reviews to properly depend on the right review! My reviews will all be published shortly (read: next 10 minutes). On Wed, Jul 16, 2014 at 6:07 PM, Timothy Chen wrote:

Re: Review Request 23592: Fixed a deadlock bug in Mutex.

2014-07-17 Thread Jie Yu
> On July 17, 2014, 12:55 a.m., Benjamin Hindman wrote: > > To Vinod's point, I think adding a comment where you declare the > > Owned> (at the top of the function) that explains that you > > need to grab this but set it outside of the critical section because > > setting it might trigger call

Re: Review Request 23592: Fixed a deadlock bug in Mutex.

2014-07-17 Thread Jie Yu
> On July 17, 2014, 12:25 a.m., Vinod Kone wrote: > > 3rdparty/libprocess/include/process/mutex.hpp, lines 55-57 > > > > > > Can you add a comment on what the bug was and how you are fixing it? Done. - Jie

  1   2   >