Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2275

2014-07-22 Thread Yan Xu
Filed https://issues.apache.org/jira/browse/MESOS-1632 -- Jiang Yan Xu @xujyan On Tue, Jul 22, 2014 at 7:18 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See < > https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable

Re: Mesos/Libprocess API

2014-07-22 Thread Tom Arnfeld
Hey! Thanks for the reply. After a painful few days I managed to narrow it down to an error (that was being swallowed, grr!!) as a result of an implementation bug in Tornado (the python library we're using for the libprocess http service). I've since submitted a patch here https://github.com/t

Re: Review Request 22796: Add timeout to rescind unused offers

2014-07-22 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22796/#review48478 --- Ship it! Ship it! Super-trivial changes, which I can fix before com

Re: Mesos/Libprocess API

2014-07-22 Thread Vetoshkin Nikita
Hi, Tom! I would gladly help you to debug if you could provide some information about your setup. Is it localhost only communication? Any code snippet to reproduce the problem? P.S. I'm trying to setup pesos and it seems like python3.3 is a requirement but it isn't mentioned anywhere. On Tue, Ju

Re: Review Request 23704: Fixed header paths for proto files during installation.

2014-07-22 Thread Zuyu Zhang
> On July 22, 2014, 9:33 p.m., Dominic Hamon wrote: > > If anyone is already building C++ frameworks, they'll have an extra include > > path in their build script after this, with the 'mesos' path included, > > right? This shouldn't break them as far as I can see. Is that assumption > > correc

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2275

2014-07-22 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] More docs for attributes and resources. [benjamin.hindman] Removed trailing '/' in Makefile.am. --

Build failed in Jenkins: Mesos-Ubuntu-distcheck #233

2014-07-22 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] Removed trailing '/' in Makefile.am. -- [...truncated 4391 lines...] g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"0.20.0\" -

Re: Review Request 23828: Introduce script for generating test coverage report.

2014-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23828/#review48463 --- Ship it! support/coverage.sh

Re: Review Request 23698: MESOS-1616 Changed ReregisterCompletedFrameworks to use stout JSON framework

2014-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23698/#review48461 --- Bad patch! Reviews applied: [23698] Failed command: ./support/meso

Jenkins build is back to normal : mesos-reviewbot #1209

2014-07-22 Thread Apache Jenkins Server
See

Re: Build failed in Jenkins: mesos-reviewbot #1206

2014-07-22 Thread Dominic Hamon
Fix committed. On Jul 22, 2014 5:37 PM, "Yan Xu" wrote: > + Isabel > > Looks like there is an issue: > > Makefile:1446: *** Recursive variable `EXAMPLESCRIPTSPYTHON' references > itself (eventually). Stop. > > -- > Jiang Yan Xu @xujyan > > > On Tue, Jul 22, 2014 at

Re: Build failed in Jenkins: mesos-reviewbot #1206

2014-07-22 Thread Yan Xu
+ Isabel Looks like there is an issue: Makefile:1446: *** Recursive variable `EXAMPLESCRIPTSPYTHON' references itself (eventually). Stop. -- Jiang Yan Xu @xujyan On Tue, Jul 22, 2014 at 4:55 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See

Build failed in Jenkins: mesos-reviewbot #1208

2014-07-22 Thread Apache Jenkins Server
See -- [...truncated 561 lines...] checking for Python site-packages path... /usr/lib/python2.7/dist-packages checking python extra libraries... -lpthread -ldl -lutil checking python extra linking flags.

Review Request 23828: Introduce script for generating test coverage report.

2014-07-22 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23828/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-987 https://issues.apa

Build failed in Jenkins: mesos-reviewbot #1207

2014-07-22 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] More docs for attributes and resources. -- [...truncated 482 lines...] checking for Python site-packages path... /usr/lib/python2.7/dist-packages checking python e

Re: Review Request 23707: Fix line comments end punctuation in mesos source

2014-07-22 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23707/#review48458 --- src/tests/slave_recovery_tests.cpp

Build failed in Jenkins: Mesos-Ubuntu-distcheck #232

2014-07-22 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] More docs for attributes and resources. -- [...truncated 380 lines...] checking python extra linking flags... -Xlinker -export-dynamic -Wl,-O1 -Wl,-Bsymboli

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2266

2014-07-22 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] More docs for attributes and resources. -- [...truncated 519 lines...] config.status: creating Makefile config.status: creating

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2010

2014-07-22 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] More docs for attributes and resources. -- [...truncated 477 lines...] checking python extra linking flags... -Xlinker -export-dynam

Build failed in Jenkins: Mesos-Ubuntu-distcheck #231

2014-07-22 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] Removed unnecessary includes and inline definitions. -- [...truncated 380 lines...] checking python extra linking flags... -Xlinker -export-dynamic -Wl,-O1

Re: Review Request 23752: More docs for attributes and resources.

2014-07-22 Thread Benjamin Hindman
> On July 22, 2014, 11:56 p.m., Benjamin Hindman wrote: > > Ship It! Committed, thank you! - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23752/#review48456 --

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2009

2014-07-22 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] Removed unnecessary includes and inline definitions. -- [...truncated 473 lines...] checking python extra linking flags... -Xlinker

Build failed in Jenkins: mesos-reviewbot #1206

2014-07-22 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] Removed unnecessary includes and inline definitions. -- [...truncated 339 lines...] checking for Python site-packages path... /usr/lib/python2.7/dist-packages chec

Re: Review Request 23752: More docs for attributes and resources.

2014-07-22 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23752/#review48456 --- Ship it! Ship It! - Benjamin Hindman On July 21, 2014, 6:19 p.m.

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2265

2014-07-22 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] Removed unnecessary includes and inline definitions. -- [...truncated 519 lines...] config.status: creating Makefile config.stat

Re: Review Request 23771: Added a Docker containerizer.

2014-07-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23771/#review48287 --- This is the first half of the review from Jie and Ian. We will conti

Re: Review Request 23749: Missing Apache headers for mesos

2014-07-22 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23749/ --- (Updated July 22, 2014, 10:34 p.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 23784: Missing Apache headers for stout

2014-07-22 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23784/ --- (Updated July 22, 2014, 10:32 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 23784: Missing Apache headers for mesos

2014-07-22 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23784/ --- (Updated July 22, 2014, 10:30 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 23783: Missing Apache headers for libprocess

2014-07-22 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23783/ --- (Updated July 22, 2014, 10:29 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 23696: Made LoadGeneratorFramework a check program instead of a bin program.

2014-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23696/#review48437 --- Patch looks great! Reviews applied: [23696] All tests passed. - M

Re: Review Request 23704: Fixed header paths for proto files during installation.

2014-07-22 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23704/#review48436 --- Ship it! If anyone is already building C++ frameworks, they'll have

Re: Review Request 23704: Fixed header paths for proto files during installation.

2014-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23704/ --- (Updated July 22, 2014, 9:30 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 20507: Fixed master to reject completed frameworks from re-registering.

2014-07-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20507/#review48435 --- Ship it! These tests are definitely not flaky, right? :) - Ben Mah

Re: Review Request 23771: Added a Docker containerizer.

2014-07-22 Thread Timothy Chen
> On July 22, 2014, 8:45 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 53 > > > > > > It is at least manifested when this is launched on GCE, so we want to > > make sure the minimum cgroup support is there.

Re: Review Request 23771: Added a Docker containerizer.

2014-07-22 Thread Timothy St. Clair
> On July 22, 2014, 8:38 p.m., Timothy St. Clair wrote: > > src/docker/docker.hpp, line 74 > > > > > > Graceful termination? How does signal escalation get handled? > > Timothy Chen wrote: > This is just an abstra

Re: Review Request 23771: Added a Docker containerizer.

2014-07-22 Thread Timothy Chen
> On July 22, 2014, 8:38 p.m., Timothy St. Clair wrote: > > src/slave/containerizer/isolators/cgroups/cpushare.cpp, line 59 > > > > > > Umm this is not always true, it's a weight based on the total across > > all group

Re: Review Request 23771: Added a Docker containerizer.

2014-07-22 Thread Timothy Chen
> On July 22, 2014, 8:38 p.m., Timothy St. Clair wrote: > > src/docker/docker.hpp, line 74 > > > > > > Graceful termination? How does signal escalation get handled? This is just an abstraction for Docker kill, in the

Re: Review Request 23771: Added a Docker containerizer.

2014-07-22 Thread Timothy St. Clair
> On July 22, 2014, 8:45 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 53 > > > > > > It is at least manifested when this is launched on GCE, so we want to > > make sure the minimum cgroup support is there.

Re: Review Request 23771: Added a Docker containerizer.

2014-07-22 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23771/#review48426 --- src/docker/docker.cpp

Re: Review Request 23771: Added a Docker containerizer.

2014-07-22 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23771/#review48402 --- only 1/2 way through, this may take a bit. src/docker/docker.hpp

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2264

2014-07-22 Thread Vinod Kone
looks like the "build" directory is not being deleted when doing "git clean -fdx" due to leveldb. Skipping repository build/mesos-0.20.0/_build/3rdparty/leveldb not sure what's special about leveldb. anyway, i will just add a "rm -rf build" after "git clean" for now. On Tue, Jul 22, 2014 at

Re: Review Request 23785: fix libev-unbundled.

2014-07-22 Thread Vinod Kone
> On July 22, 2014, 4:56 p.m., Vinod Kone wrote: > > Have you tested this with a non-standard libev install? > > Timothy St. Clair wrote: > This mod is very small so the logic for prefix would be outside. In > thinking about it, I could roll this a full prefix check and compile check > fo

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2264

2014-07-22 Thread Apache Jenkins Server
See Changes: [vinodkone] Minor fix for libev-unbundled in python setup. -- [...truncated 122 lines...] m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from... con

Re: Review Request 23785: fix libev-unbundled.

2014-07-22 Thread Timothy St. Clair
> On July 22, 2014, 4:56 p.m., Vinod Kone wrote: > > Have you tested this with a non-standard libev install? > > Timothy St. Clair wrote: > This mod is very small so the logic for prefix would be outside. In > thinking about it, I could roll this a full prefix check and compile check > fo

Re: Review Request 23785: fix libev-unbundled.

2014-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23785/#review48396 --- Ship it! Ship It! - Vinod Kone On July 22, 2014, 6:08 p.m., Timo

Jenkins build is back to normal : mesos-reviewbot #1202

2014-07-22 Thread Apache Jenkins Server
See

Re: Review Request 23785: fix libev-unbundled.

2014-07-22 Thread Timothy St. Clair
> On July 22, 2014, 4:56 p.m., Vinod Kone wrote: > > Have you tested this with a non-standard libev install? This mod is very small so the logic for prefix would be outside. In thinking about it, I could roll this a full prefix check and compile check for -DEV_CHILD_ENABLE. Does this make mo

Re: Review Request 23086: Update system check to unbundle protobuf

2014-07-22 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated July 22, 2014, 6:14 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 23745: Unnecessary includes and inline definitions from RR 18295

2014-07-22 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23745/ --- (Updated July 22, 2014, 6:13 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 23771: Added a Docker containerizer.

2014-07-22 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23771/ --- (Updated July 22, 2014, 6:12 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 23785: fix libev-unbundled.

2014-07-22 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23785/ --- (Updated July 22, 2014, 6:08 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 23785: fix libev-unbundled.

2014-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23785/#review48374 --- Have you tested this with a non-standard libev install? - Vinod Kon

Re: Review Request 23086: Update system check to unbundle protobuf

2014-07-22 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated July 22, 2014, 4:54 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 23453: Unbundle glog

2014-07-22 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23453/ --- (Updated July 22, 2014, 4:54 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 23453: Unbundle glog

2014-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23453/#review48373 --- lgtm as much as i understand autotools. i will be happy to commit th

Re: Review Request 23783: Missing Apache headers for libprocess

2014-07-22 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23783/#review48369 --- Ship it! Ship It! - Dominic Hamon On July 21, 2014, 5:35 p.m., I

Re: Review Request 23783: Missing Apache headers for libprocess

2014-07-22 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23783/#review48368 --- Ship it! Ship It! - Dominic Hamon On July 21, 2014, 5:35 p.m., I

Re: Review Request 23784: Missing Apache headers for mesos

2014-07-22 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23784/#review48367 --- Ship it! Ship It! - Dominic Hamon On July 21, 2014, 6:17 p.m., I

Build failed in Jenkins: mesos-reviewbot #1201

2014-07-22 Thread Apache Jenkins Server
See -- [...truncated 4803 lines...] test -z "mesos.pc bin/mesos.sh bin/mesos-local.sh bin/mesos-master.sh bin/mesos-slave.sh bin/mesos-tests.sh bin/mesos-local-flags.sh bin/mesos-master-flags.sh bin/mes

Re: Review Request 23710: Add line comments end punctuation style rule

2014-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23710/#review48349 --- Bad patch! Reviews applied: [23596, 23597, 23598, 23599, 23707] Fa

Jenkins build is back to normal : mesos-reviewbot #1200

2014-07-22 Thread Apache Jenkins Server
See