Re: Review Request 24784: Disabled glog signal handler for libprocess tests.

2014-08-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24784/#review50841 --- Ship it! Ship It! - Vinod Kone On Aug. 17, 2014, 4:52 a.m., Jie

Re: Review Request 24783: Disabled glog signal handler for stout tests.

2014-08-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24783/#review50840 --- Ship it! Ship It! - Vinod Kone On Aug. 17, 2014, 4:51 a.m., Jie

Review Request 24784: Disabled glog signal handler for libprocess tests.

2014-08-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24784/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description --

Review Request 24783: Disabled glog signal handler for stout tests.

2014-08-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24783/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description --

Re: Review Request 24775: Add documentation for Docker

2014-08-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24775/#review50839 --- Ship it! Tim, I'll commit this doc for the release. We can revise i

Re: Review Request 24781: Updated the upgrades.md for 0.20.0.

2014-08-16 Thread Benjamin Hindman
Ship It! On Saturday, August 16, 2014, Jie Yu wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24781/ > Review request for mesos, Benjamin Hindman and Vinod Kone. > By Jie Yu. > *Repository: * mesos-git > Description > > See summary. > >

Review Request 24781: Updated the upgrades.md for 0.20.0.

2014-08-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24781/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Repository: mesos-gi

Re: Review Request 24780: Disabled glog signal handler for mesos tests.

2014-08-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24780/#review50836 --- Ship it! Ship It! - Vinod Kone On Aug. 17, 2014, 2:47 a.m., Jie

Review Request 24780: Disabled glog signal handler for mesos tests.

2014-08-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24780/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Repository: mesos-gi

Re: Review Request 24776: Add docker containerizer destroy tests

2014-08-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review50835 --- Patch looks great! Reviews applied: [24776] All tests passed. - M

Re: Review Request 24775: Add documentation for Docker

2014-08-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24775/ --- (Updated Aug. 17, 2014, 12:42 a.m.) Review request for mesos, Benjamin Hindman

Review Request 24776: Add docker containerizer destroy tests

2014-08-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #283

2014-08-16 Thread Apache Jenkins Server
See

Jenkins build is back to normal : mesos-reviewbot #1362

2014-08-16 Thread Apache Jenkins Server
See

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2058

2014-08-16 Thread Apache Jenkins Server
See

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2349

2014-08-16 Thread Apache Jenkins Server
See

Re: Review Request 24765: Added some slave recovery DockerContainerizer tests.

2014-08-16 Thread Benjamin Hindman
> On Aug. 16, 2014, 4:17 p.m., Jie Yu wrote: > > src/tests/docker_containerizer_tests.cpp, line 1449 > > > > > > I don't see it being DISABLED? Oops, forgot to update the review. > On Aug. 16, 2014, 4:17 p.m., Jie

Re: Review Request 24774: Cleanup mesos due to the new io::read semantics.

2014-08-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24774/#review50831 --- Ship it! Ship It! - Benjamin Hindman On Aug. 16, 2014, 6:41 p.m.

Re: Review Request 24773: Fix style issues around docker

2014-08-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24773/#review50830 --- Ship it! Ship It! - Benjamin Hindman On Aug. 16, 2014, 5:49 p.m.

Review Request 24774: Cleanup mesos due to the new io::read semantics.

2014-08-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24774/ --- Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-1710

Re: Review Request 24766: Set ownership of stdout/stderr and container directory properly.

2014-08-16 Thread Benjamin Hindman
> On Aug. 16, 2014, 4:25 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 801-807 > > > > > > Do you want to chown for fetched stuff as well? The mesos-fetcher already does that. > On Aug. 16, 2014,

Re: Review Request 24772: Fixed libprocess tests due to the new io::read semantics.

2014-08-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24772/#review50828 --- Ship it! Thanks Jie. :-/ - Benjamin Hindman On Aug. 16, 2014, 5:

Re: Review Request 24773: Fix style issues around docker

2014-08-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24773/#review50826 --- Ship it! Ship It! - Jie Yu On Aug. 16, 2014, 5:49 p.m., Timothy

Review Request 24772: Fixed libprocess tests due to the new io::read semantics.

2014-08-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24772/ --- Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone. Bugs:

Review Request 24773: Fix style issues around docker

2014-08-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24773/ --- Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. Repository:

Build failed in Jenkins: Mesos-Ubuntu-distcheck #282

2014-08-16 Thread Apache Jenkins Server
See Changes: [vinodkone] Added missing stout/glog.hpp. -- Started by an SCM change Building remotely on ubuntu-5 (Ubuntu ubuntu5 ubuntu) in workspace

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2057

2014-08-16 Thread Vinod Kone
my bad..fixed. On Sat, Aug 16, 2014 at 10:36 AM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See < > https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2057/changes > > > > Changes: > > [vinodkone] Moved > 'mesos::internal::logging::installSignalFailureHa

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2057

2014-08-16 Thread Apache Jenkins Server
See Changes: [vinodkone] Moved 'mesos::internal::logging::installSignalFailureHandler()' to stout/logging.hpp. -- [...truncated 1118 lines...] yes checking for an

Build failed in Jenkins: mesos-reviewbot #1361

2014-08-16 Thread Apache Jenkins Server
See Changes: [vinodkone] Moved 'mesos::internal::logging::installSignalFailureHandler()' to stout/logging.hpp. -- Started by an SCM change Building remotely on ubuntu-4 (Ubuntu ubuntu4 ubuntu) i

Build failed in Jenkins: Mesos-Ubuntu-distcheck #281

2014-08-16 Thread Apache Jenkins Server
See Changes: [vinodkone] Moved 'mesos::internal::logging::installSignalFailureHandler()' to stout/logging.hpp. -- Started by an SCM change Building remotely on ubuntu3 (Ubuntu ubuntu) in w

Build failed in Jenkins: mesos-reviewbot #1360

2014-08-16 Thread Apache Jenkins Server
See -- [URLTrigger] A change within the response URL invocation (log) Building remotely on ubuntu-4 (Ubuntu ubuntu4 ubuntu) in workspace > git rev-par

Re: Review Request 24753: Moved 'mesos::internal::logging::installSignalFailureHandler()' to stout/logging.hpp.

2014-08-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24753/#review50825 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/Makefile.am

Build failed in Jenkins: mesos-reviewbot #1359

2014-08-16 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] Revert "Make sure the mesos-fetcher exits if the slave terminates." [benjamin.hindman] Added some slave recovery DockerContainerizer tests. [benjamin.hindman] Set ownership of stdout/stderr and contain

Re: Review Request 24767: Validate Docker version since we require >= 1.0.0.

2014-08-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24767/#review50824 --- Ship it! Ship It! - Jie Yu On Aug. 16, 2014, 2:58 p.m., Benjamin

Re: Review Request 24766: Set ownership of stdout/stderr and container directory properly.

2014-08-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24766/#review50823 --- src/slave/containerizer/docker.cpp

Re: Review Request 24765: Added some slave recovery DockerContainerizer tests.

2014-08-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24765/#review50822 --- Ship it! src/tests/docker_containerizer_tests.cpp

Re: Review Request 24767: Validate Docker version since we require >= 1.0.0.

2014-08-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24767/ --- (Updated Aug. 16, 2014, 2:58 p.m.) Review request for mesos, Jie Yu and Timothy

Re: Review Request 24761: Made DockerContainerizer be the default.

2014-08-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24761/ --- (Updated Aug. 16, 2014, 2:57 p.m.) Review request for mesos, Ben Mahler, Ian Do

Re: Review Request 24765: Added some slave recovery DockerContainerizer tests.

2014-08-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24765/ --- (Updated Aug. 16, 2014, 2:57 p.m.) Review request for mesos, Jie Yu and Timothy

Re: Review Request 24768: Save docker pid for subsequent containerizer updates

2014-08-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24768/#review50821 --- Ship it! Ship It! - Benjamin Hindman On Aug. 16, 2014, 6:17 a.m.