Review Request 24840: fix attributes docstring

2014-08-19 Thread Nikita Vetoshkin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24840/ --- Review request for mesos. Bugs: MESOS-1722

Re: Review Request 24840: fix attributes docstring

2014-08-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24840/#review50978 --- Patch looks great! Reviews applied: [24840] All tests passed. -

Re: Review Request 24840: fix attributes docstring

2014-08-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24840/#review50987 --- Ship it! Thanks Nikita. I'll get this committed shortly. - Vinod

Re: [VOTE] Release Apache Mesos 0.20.0 (rc2)

2014-08-19 Thread Vinod Kone
+1 make check passes on OSX Mavericks and CentOS 5.5 On Mon, Aug 18, 2014 at 11:26 PM, Jie Yu yujie@gmail.com wrote: Hi all, Please vote on releasing the following candidate as Apache Mesos 0.20.0. NOTE: 0.20.0-rc1 has a bug on Mac (MESOS-1713) which is fixed in 0.20.0-rc2.

Re: [VOTE] Release Apache Mesos 0.20.0 (rc2)

2014-08-19 Thread Ian Downes
+1 make check passes on CentOS 5.5 with 3.4 kernel. Docker tests were ignored. On Aug 19, 2014, at 10:54 AM, Vinod Kone vinodk...@gmail.com wrote: +1 make check passes on OSX Mavericks and CentOS 5.5 On Mon, Aug 18, 2014 at 11:26 PM, Jie Yu yujie@gmail.com wrote: Hi all,

Re: [VOTE] Release Apache Mesos 0.20.0 (rc2)

2014-08-19 Thread Niklas Nielsen
+1 make check on Ubuntu 14.04 gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1) and Mac OS X clang-503.0.40 Looking so much forward to this release! Niklas On 19 August 2014 11:28, Ian Downes idow...@twitter.com.invalid wrote: +1 make check passes on CentOS 5.5 with 3.4 kernel. Docker tests were

Re: [VOTE] Release Apache Mesos 0.20.0 (rc2)

2014-08-19 Thread Timothy Chen
Make check passes with Docker tests passed as well on Ubuntu 14.04 +1 Tim On Tue, Aug 19, 2014 at 11:28 AM, Ian Downes idow...@twitter.com.invalid wrote: +1 make check passes on CentOS 5.5 with 3.4 kernel. Docker tests were ignored. On Aug 19, 2014, at 10:54 AM, Vinod Kone

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-19 Thread Ben Mahler
On Aug. 14, 2014, 5:47 p.m., Nikita Vetoshkin wrote: I don't think that si_uid can give something interesting because it can be either 0 or UID of receiving process. How about logging si_pid too? Ben Mahler wrote: si_uid represents the user id of the _sending_ process, not the

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24700/#review51038 --- 3rdparty/libprocess/3rdparty/stout/include/stout/glog.hpp

Re: Review Request 22066: Added timeout to rescind unused offers

2014-08-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/#review51039 --- Ok, almost there! One main suggestion: can this flag be optional

Re: Review Request 24178: Basic filesystem isolator for Linux.

2014-08-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24178/#review51046 --- Nice to see this! Added some high level comments. src/Makefile.am

Re: Review Request 23710: Add line comments end punctuation style rule

2014-08-19 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23710/ --- (Updated Aug. 20, 2014, 12:32 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 23707: Fix line comments end punctuation in mesos source

2014-08-19 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23707/ --- (Updated Aug. 20, 2014, 12:35 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 23710: Add line comments end punctuation style rule

2014-08-19 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23710/ --- (Updated Aug. 20, 2014, 12:36 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 23708: Fix line comments end punctuation in stout

2014-08-19 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23708/ --- (Updated Aug. 20, 2014, 12:36 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 23709: Fix line comments end punctuation in libprocess

2014-08-19 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23709/ --- (Updated Aug. 20, 2014, 12:36 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 24178: Basic filesystem isolator for Linux.

2014-08-19 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24178/#review51049 --- src/slave/containerizer/isolators/filesystem.hpp

Re: [VOTE] Release Apache Mesos 0.20.0 (rc2)

2014-08-19 Thread Tim St Clair
./bootstrap ./configure make check '+1 make check' on clean el7 is green However on machines that already have deps installed, my F20 machine: I've seen '[ FAILED ] ExamplesTest.PythonFramework' for a while. Digging I find: Traceback (most recent call last): File

Re: Review Request 22066: Added timeout to rescind unused offers

2014-08-19 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/ --- (Updated Aug. 19, 2014, 9:54 p.m.) Review request for mesos, Adam B, Ben

Re: Review Request 22066: Added timeout to rescind unused offers

2014-08-19 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/#review51057 --- src/tests/master_tests.cpp

Re: [VOTE] Release Apache Mesos 0.20.0 (rc2)

2014-08-19 Thread Jie Yu
Tim, I demangled the symbol: google::FlagRegisterer::FlagRegisterer(char const*, char const*, char const*, char const*, void*, void*) Doesn't seem to be from mesos. - Jie On Tue, Aug 19, 2014 at 6:44 PM, Tim St Clair tstcl...@redhat.com wrote: ./bootstrap ./configure make check '+1 make

Re: [VOTE] Release Apache Mesos 0.20.0 (rc2)

2014-08-19 Thread Jie Yu
Synced with Tim. We both think this shouldn't be a blocker for the release. - Jie On Tue, Aug 19, 2014 at 7:21 PM, Jie Yu yujie@gmail.com wrote: Tim, I demangled the symbol: google::FlagRegisterer::FlagRegisterer(char const*, char const*, char const*, char const*, void*, void*)