Re: Review Request 26670: Added reconciliation to the documentation home.

2014-10-14 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26670/#review56537 --- Ship it! Sounds great! - Dominic Hamon On Oct. 13, 2014, 5:36 p.

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-10-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review56536 --- Bad patch! Reviews applied: [17431] Failed command: git apply --in

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-10-14 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review56533 --- The latest diff looks broken - Thomas, mind updating it (if you stil

Re: Review Request 25184: Delete framework data in TaskStatus to avoid OOM

2014-10-14 Thread Timothy St. Clair
> On Oct. 14, 2014, 2:21 p.m., Timothy St. Clair wrote: > > I tested locally but not to any great extent, and it passed my make check. > > > > Could you please elaborate on your testing in the review. On second ship-it + updated test comment I'll push post haste. - Timothy ---

Re: Review Request 25184: Delete framework data in TaskStatus to avoid OOM

2014-10-14 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25184/#review56526 --- Ship it! I tested locally but not to any great extent, and it passe

Re: Review Request 26605: Cleanup right angle bracket in the code base.

2014-10-14 Thread Till Toenshoff
> On Oct. 13, 2014, 9:17 a.m., Till Toenshoff wrote: > > Thanks for proposing this patch Evelina. > > > > Could you please split this into seperate patches for stout, libprocess and > > mesos itself? > > Evelina Dumitrescu wrote: > What do you mean by three separate patches? I suppose thre

Re: Review Request 26634: Implemented array subscript lookup in JSON::Object::find.

2014-10-14 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/#review56504 --- It looks to me that adding this functionality imposes a restriction

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2167

2014-10-14 Thread Apache Jenkins Server
See Changes: [adam] stout: Always use stout ABORT() rather than system abort() [adam] libprocess: Always use stout ABORT() rather than system abort() -- [...trunca

Re: Review Request 26605: Cleanup right angle bracket in the code base.

2014-10-14 Thread Evelina Dumitrescu
> On Oct. 13, 2014, 9:17 a.m., Till Toenshoff wrote: > > Thanks for proposing this patch Evelina. > > > > Could you please split this into seperate patches for stout, libprocess and > > mesos itself? What do you mean by three separate patches? I suppose three different commits ... It is not v

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2440

2014-10-14 Thread Apache Jenkins Server
See

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2166

2014-10-14 Thread Apache Jenkins Server
See

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2439

2014-10-14 Thread Apache Jenkins Server
Modify configure.ac to fix --with-sasl. -- [...truncated 60828 lines...] I1014 07:45:16.772703 29155 gc.cpp:56] Scheduling '/tmp/StatusUpdateManagerTest_DuplicateTerminalUpdateAfterAck_Ptf7B0/meta/slaves/20141014-074516-3142697795-60149-29137-0/frameworks/2014

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26472/#review56498 --- Ship it! Minor consistency nit, but otherwise quite shippable. 3r

Re: Review Request 26473: libprocess: Always use stout ABORT() rather than system abort()

2014-10-14 Thread Adam B
> On Oct. 9, 2014, 2:14 a.m., Adam B wrote: > > 3rdparty/libprocess/src/httpd.cpp, lines 32-37 > > > > > > Why are you removing this here? Doesn't seem related to the abort > > change. Or did you just notice that these

<    1   2