Re: Review Request 28720: Adjusted the calculation of unused resources in _launchTasks by considering persistent disk acquisition.

> On Dec. 13, 2014, 1:21 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 1804 > > > > > > It's interesting to compare this to state::Variable's mutate() method, > > perhaps we should call this transformation?

Re: Review Request 28720: Adjusted the calculation of unused resources in _launchTasks by considering persistent disk acquisition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28720/ --- (Updated Dec. 13, 2014, 5:58 a.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 29018: Added abstraction for resources transformation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29018/ --- (Updated Dec. 13, 2014, 5:57 a.m.) Review request for mesos and Ben Mahler. B

Review Request 29018: Added abstraction for resources transformation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29018/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2030 https://issues.ap

Re: using std::unique_ptr

Good start Dominic! I have another example which I think using unique_ptr is preferred. We need to store a vector of pointers to the base class (which means we have to use pointers here). However, storing raw pointer makes the ownership tracking not explicit. What do you guys think? // Base cla

Re: travis-ci

It hasn't caught up to today yet :) On Dec 12, 2014 5:43 PM, "Chris Aniszczyk" wrote: > interesting, not sure why it's not finding the .travis.yml, it's definitely > there: > https://github.com/apache/mesos/blob/master/.travis.yml > > On Fri, Dec 12, 2014 at 7:24 PM, Benjamin Mahler < > benjamin.

Re: travis-ci

interesting, not sure why it's not finding the .travis.yml, it's definitely there: https://github.com/apache/mesos/blob/master/.travis.yml On Fri, Dec 12, 2014 at 7:24 PM, Benjamin Mahler wrote: > Cool! It looks broken? > > WARNING: We were unable to find a .travis.yml file. This may not be what

Re: travis-ci

Cool! It looks broken? WARNING: We were unable to find a .travis.yml file. This may not be what you want. Build will be run with default settings. Then it tries to run rake? On Fri, Dec 12, 2014 at 3:52 PM, Dominic Hamon wrote: > I just pushed a config that will allow travis-ci.org to build

Re: Review Request 28720: Adjusted the calculation of unused resources in _launchTasks by considering persistent disk acquisition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28720/#review65007 --- I'd like to use the mutation stuff in the allocator, can you split i

Re: Review Request 28957: Fixed coding style issues related to the variable naming convention in the routing library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28957/#review65001 --- I committed a fix for you. src/linux/routing/link/link.cpp

travis-ci

I just pushed a config that will allow travis-ci.org to build mesos from our github mirror. It is currently set to build the matrix: gcc/clang osx/linux debug/release https://travis-ci.org/apache/mesos This is an experiment meant to supplement our use of jenkins at Apache. Please let me know if

Re: Review Request 28683: Add travis config file for travis-ci.org

> On Dec. 12, 2014, 3:29 p.m., Chris Aniszczyk wrote: > > Do you have the Travis CI webhook for Mesos enabled? > > https://github.com/apache/mesos yes .. apache infra already did that. however it's using the default build which is trying to use rake. - Dominic -

Re: Review Request 28683: Add travis config file for travis-ci.org

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28683/#review64993 --- Do you have the Travis CI webhook for Mesos enabled? https://github

Re: Review Request 28683: Add travis config file for travis-ci.org

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28683/#review64991 --- Ship it! Ship It! - Chris Aniszczyk On Dec. 4, 2014, 1:38 a.m.,

Re: Review Request 28966: PortMappingIsolator: added a metric to expose the number of TC IP filters on eth0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28966/#review64992 --- Patch looks great! Reviews applied: [28966] All tests passed. - M

Re: Review Request 28959: Introduce process::network namespace to encapsulate socket call wrappers and Socket class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28959/#review64990 --- Ship it! Ship It! - Dominic Hamon On Dec. 12, 2014, 3:22 p.m., E

Re: Review Request 28959: Introduce process::network namespace to encapsulate socket call wrappers and Socket class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28959/ --- (Updated Dec. 12, 2014, 11:22 p.m.) Review request for mesos, Ben Mahler and Do

Re: Review Request 28959: Introduce process::network namespace to encapsulate socket call wrappers and Socket class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28959/#review64989 --- 3rdparty/libprocess/include/process/socket.hpp

Re: Review Request 28959: Introduce process::network namespace to encapsulate socket call wrappers and Socket class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28959/ --- (Updated Dec. 12, 2014, 11:14 p.m.) Review request for mesos, Ben Mahler and Do

Re: using std::unique_ptr

Great idea. There is one place that immediately springs to mind that I think is trivial but will get us used to the idea and exercise some of the demons: Unit tests. Within a test we regularly create some object on the heap and then delete it at the end of the test, or for the lifetime of a test f

Re: Review Request 28966: PortMappingIsolator: added a metric to expose the number of TC IP filters on eth0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28966/#review64986 --- src/slave/containerizer/isolators/network/port_mapping.hpp

Re: Review Request 28966: PortMappingIsolator: added a metric to expose the number of TC IP filters on eth0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28966/ --- (Updated Dec. 12, 2014, 10:45 p.m.) Review request for mesos, Dominic Hamon, Ia

Re: Review Request 28824: Fixed the two level sorting in the allocator.

> On Dec. 12, 2014, 7:35 p.m., Jie Yu wrote: > > src/master/hierarchical_allocator_process.hpp, line 757 > > > > > > Why changed it to +=? It was for symmetry: ``` offerable[frameworkId][slaveId] += resources; slaves

Re: Review Request 28959: Introduce process::network namespace to encapsulate socket call wrappers and Socket class

> On Dec. 12, 2014, 9:39 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/event.hpp, line 105 > > > > > > i'm still stuck on why this and other lines in the process namespace > > needs process:: pref

Re: Review Request 28959: Introduce process::network namespace to encapsulate socket call wrappers and Socket class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28959/#review64979 --- 3rdparty/libprocess/include/process/event.hpp

Re: Review Request 28983: Added multiplication and division operators for Bytes.

> On Dec. 12, 2014, 6:31 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp, lines 99-110 > > > > > > Ditto Dominic's comment. You probably wanna at least add a CHECK here. Will go with

Re: Review Request 28983: Added multiplication and division operators for Bytes.

> On Dec. 12, 2014, 5:02 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp, line 101 > > > > > > what happens if someone passes in a negative multiplier? I'll add an ABORT for t

Re: Review Request 29006: Added output streaming for persistence id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29006/#review64969 --- Bad patch! Reviews applied: [28711, 28720] Failed command: ./suppo

Review Request 29006: Added output streaming for persistence id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29006/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2030 https://issues.ap

Re: Proposal: shared Mesos framework hosting and registry

Hey Connor, It would be great to hear back about this and get the ball rolling on a shared registry. Let me know what you think! Thanks, Dave On Wed, Dec 3, 2014 at 1:11 PM, Dave Lester wrote: > > Hi Connor, > > Thanks for sharing the work you've been doing with Universe. Sounds > complimentary

Re: Review Request 28824: Fixed the two level sorting in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28824/#review64958 --- Ship it! src/master/hierarchical_allocator_process.hpp

Re: Review Request 28983: Added multiplication and division operators for Bytes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28983/#review64957 --- Ship it! Giving a ship it as it's trivial to fix. - Jie Yu On De

Re: Review Request 28984: Split apart the Bytes test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28984/#review64947 --- Ship it! Ship It! - Jie Yu On Dec. 12, 2014, 7:21 a.m., Ben Mahl

Re: Review Request 28983: Added multiplication and division operators for Bytes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28983/#review64946 --- 3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp

Re: Review Request 28987: Added an allocator unit test for allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28987/#review64945 --- Ship it! Ship It! - Jie Yu On Dec. 12, 2014, 7:21 a.m., Ben Mahl

Re: Review Request 28986: Removed Resources::extract in favor of reservation-based helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28986/#review64939 --- Ship it! Thanks for the clean ups! - Jie Yu On Dec. 12, 2014, 7:

Re: Review Request 28985: Updated Resources interface to expose reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28985/#review64937 --- Ship it! include/mesos/resources.hpp

Re: Review Request 28904: echo command in sh doesn't have options

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28904/#review64933 --- Ship it! Thank you for fixing this. I'll get this committed. - Jie

Re: Review Request 28983: Added multiplication and division operators for Bytes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28983/#review64924 --- 3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp

Re: Review Request 28904: echo command in sh doesn't have options

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28904/#review64922 --- Ship it! Ship It! - Dominic Hamon On Dec. 12, 2014, 8:22 a.m., K

Re: Review Request 28904: echo command in sh doesn't have options

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28904/#review64923 --- [~idownes] can you commit this if it looks good to you? - Dominic H

Re: Review Request 28904: echo command in sh doesn't have options

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28904/#review64918 --- Patch looks great! Reviews applied: [28904] All tests passed. - M

Re: Review Request 28904: echo command in sh doesn't have options

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28904/ --- (Updated 12月 12, 2014, 4:22 p.m.) Review request for mesos and Ian Downes. Ch

Re: Review Request 28904: echo command in sh doesn't have options

> On 12月 12, 2014, 1:22 a.m., Ian Downes wrote: > > I too am not sure how this was working before. What environment did you see > > this under? > > > > We don't actually need to use a tab to separate the values when writing to > > the special file; let's remove that as well: > > ``` > > sh-4.1

Re: Review Request 28824: Fixed the two level sorting in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28824/#review64886 --- Patch looks great! Reviews applied: [28983, 28984, 28985, 28986, 28