Re: Review Request 29918: Introduced a generic checkpoint function.

2015-01-24 Thread Michael Park
> On Jan. 23, 2015, 6:44 p.m., Jie Yu wrote: > > src/slave/state.hpp, line 120 > > > > > > One more thought: > > > > Can we introduce a third parameter for this function to let users opt > > out the temp + re

Re: Review Request 30111: Added support for RepeatedPtrField to ::protobuf::read.

2015-01-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30111/ --- (Updated Jan. 25, 2015, 1:13 a.m.) Review request for mesos, Ben Mahler and Jie

mesos-dns

2015-01-24 Thread Christos Kozyrakis
A few days ago, we open sourced a simple DNS server for Mesos clusters that automatically draws information from the Mesos master(s). It should be helpful for service discovery in multi-framework clusters. The code: https://github.com/mesosphere/mesos-dns Docs: https://mesosphere.github.com/mesos-

Re: Review Request 29337: Launch docker container and log through docker executor.

2015-01-24 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29337/#review69545 --- src/docker/executor.cpp

Re: Review Request 29333: Add docker_sock to slave flags

2015-01-24 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/#review69544 --- Ship it! Ship It! - Bernd Mathiske On Jan. 16, 2015, 5:35 p.m.,

Re: Review Request 29331: Re-enable docker recover test.

2015-01-24 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29331/#review69543 --- Ship it! Ship It! - Bernd Mathiske On Jan. 16, 2015, 5:27 p.m.,

Re: Review Request 29327: Add slave id to docker container name prefix.

2015-01-24 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29327/#review69542 --- Ship it! Ship It! - Bernd Mathiske On Jan. 16, 2015, 3:21 p.m.,

Re: Review Request 30006: Enabled concurrent downloading into the fetcher cache

2015-01-24 Thread Timothy Chen
> On Jan. 21, 2015, 7:45 p.m., Timothy Chen wrote: > > src/slave/containerizer/fetcher.cpp, line 222 > > > > > > Can't you directly bind(&collect, pendingDownloads)? > > Bernd Mathiske wrote: > Don't know how to b